From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B4B0ECAAA1 for ; Tue, 30 Aug 2022 20:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hGd75h3s91EnBah7QnKV7/nudT4GgFK7rmggTOnlPuo=; b=BCVOXFb5JGYlju lvWiROceWW5CbhVM59JkFt98ygJVEftryH4dl6pcLFeXyC5A7xH4kLwFjIdvw441amVFYewWp56JR PKx5sNiYheLkI/VsI5CnnA+FWOOw5TRLzECKnXQ82/rF/beqPiaVrtXxTQ9DLWzb8ZpNOreOr+5al vHk8uY3/TDYCj63797cZGa4ZkCHmuDL+xZ2KG6dZFb78dz46WroytQUGR46goOrEnYcFcLzQACOiA VD/MSWWP2enBWh6Xf56/VUKzhpyvaOEj29lymip8tqUhwi/pCCvqlwBsQezEStuJ3nhOrRCObrxN/ grgVcVIX+AXIy3LI3dTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT7dd-001mFG-Cr; Tue, 30 Aug 2022 20:15:09 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oT7dZ-001mAX-IX for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 20:15:06 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 27UKF0WK121458; Tue, 30 Aug 2022 15:15:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1661890500; bh=A0BlvOSQ12/5GaL+fYj9FbzXtl74CQwQ8TXPJ6fkYes=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=o5IcDExDxDk5SS6eGU43aAkufQIz6a13dDcqwYlRf0G8vHSRScugzamg91sHu2PWM 2ufKIUh1FAHV+eCl6jEJB2qdOpawg4tYFewF6v+khSy0E85OAsr+FXH+jsqTx5AeVn PJ/djN4r2dzPpovszLmxap3Cs0i+xUnY2UmLhGas= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 27UKF0mK067861 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Aug 2022 15:15:00 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Tue, 30 Aug 2022 15:15:00 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Tue, 30 Aug 2022 15:15:00 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 27UKF0BD129398; Tue, 30 Aug 2022 15:15:00 -0500 Date: Tue, 30 Aug 2022 15:15:00 -0500 From: Nishanth Menon To: Arnd Bergmann CC: Subject: Re: [PATCH 2/4] arm64: dts: ti: j721e*: Define aliases in board files Message-ID: <20220830201500.sowmkdyrlizpt6o2@confider> References: <20220830152132.23916-1-nm@ti.com> <20220830152132.23916-3-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_131505_680259_FFB40D95 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20:18-20220830, Arnd Bergmann wrote: > On Tue, Aug 30, 2022, at 5:21 PM, Nishanth Menon wrote: > > Define aliases in board files, instead of in the SoC dtsi file. > > > > Reported-by: Daniel Thompson > > Signed-off-by: Nishanth Menon > > The patch is a good step in the right direction, but > > > > > + aliases { > > + serial0 = &wkup_uart0; > > + serial1 = &mcu_uart0; > > + serial2 = &main_uart0; > > + serial3 = &main_uart1; > > + serial4 = &main_uart2; > > + serial5 = &main_uart3; > > + serial6 = &main_uart4; > > + serial7 = &main_uart5; > > + serial8 = &main_uart6; > > + serial9 = &main_uart7; > > + serial10 = &main_uart8; > > + serial11 = &main_uart9; > > + ethernet0 = &cpsw_port1; > > + mmc0 = &main_sdhci0; > > + mmc1 = &main_sdhci1; > > + mmc2 = &main_sdhci2; > > Are all these devices actually used on both of the boards? > > There is no point in defining an alias if the board > does not route these to a device or a connector. Thanks and true, I had indeed missed cross checking against the usage. Will recheck, cleanup and respin this series. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel