Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on

Francesco Dolcini
2022-09-02T12:59:17Z

On Thu, Sep 01, 2022 at 07:44:43PM +0100, Mark Brown wrote:
> On Thu, Sep 01, 2022 at 09:29:13PM +0300, Laurent Pinchart wrote:
> > On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> > > From: Max Krummenacher <max.krummenacher@toradex.com>
>
> > > These regulators are switched on by HW during power up and can not
> > > be influenced by SW.
> > > Set the always-on property.
> >
> > Is this needed ? When a fixed regulator has no control GPIO or clock, as
> > is the case here, I would expect the driver and/or regulator core to
> > understand that it's always on, as the alternative is always-off, which
> > is pointless :-) Mark, Liam, what do you think ?
>
> If there's no physical control setting always-on does nothing.

The patch was posted because of a warning on trying to disable an unused
regulator.

However this was changed with
261f06315cf7 ("regulator: Flag uncontrollable regulators as always_on").

Max was testing with a kernel without this patch in and forgot to verify
on latest upstream kernel.

Just disregard this.

Francesco