From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2F46ECAAD5 for ; Mon, 5 Sep 2022 01:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MSmAoBgjj4VyIILBhgILGl2/cWYABbtciIS1SS0tZVE=; b=BGhfO1ZvJTR6gc NZkgszd/zLZa40hzsm/epwMgLSIws0LiYXfVS1zlVeX0x+A0D6fNwUYUYgJMoqyAfPZ4tc0BUWCuT Q9cf63ktPEZNHN7Mfo2URrdQwFBqt+E7YwR0unpMKpBrcG0M2xGzMwQQ3b2z54AMD7lWGjXrEeowX +2sugRSbNTqTedQLA0U4VxbzzaR5AW+VKMcJTGqefQdOIeHG+lpCsksMk0hv0MlsMbzoCZe9DE4+h bstj2G0oJhSOr+ckpsx/NYAGBbCNv5IgkLjYcPJqPNOKHzNCGGcd9hMtTM7DWbHHsIITWczGwcM4D yYGqvFfLBbwCfXOS8eWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV19p-004pLX-Sv; Mon, 05 Sep 2022 01:44:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV0dl-003cDA-P0 for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 01:11:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD23961049; Mon, 5 Sep 2022 01:11:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DE76C433C1; Mon, 5 Sep 2022 01:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662340264; bh=ldNva4ftghdca/S3rxMHbDvUKXG5rCNxNXiZuTq45Bk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t6AHCdWvp8NdxkxYDlPI+aCgz4tVB2GJJ9harmqq1gV2Dd10QrAwZ2J3HjX45Q6rZ 14mR7y+Xm0bJo04Q+Gj+mCDiEZ8VXBgjyV+lK/P4Z3S7RpLLPdt9Rfwohaz0yJkPP2 4ELQEY6SoNHYF3v28Se8afGYaEFKPgBYv+/d8VlBX/bO/uVSI5Q0pmi1okSFKedZ2P GaYNF3IPYW5v8mbU0IiJ673nh/YtV5R2B5FZLrAB4ZdcQlgrQAIUdZoKF/KtLcEiaQ Sb9cpkAc9eIByp8BBs26k1bJCvL2mOeRE0E42/QSmNPOTb+Q8CNKigpW+9YGsl4Wi+ 0suH8ltnR/9CA== Date: Mon, 5 Sep 2022 09:10:59 +0800 From: Shawn Guo To: Li Yang Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xiaowei Bao Subject: Re: [PATCH 2/9] arm64: dts: ls1046a: Add the PME interrupt to PCIe EP nodes Message-ID: <20220905011059.GR1728671@dragon> References: <20220824231200.494-1-leoyang.li@nxp.com> <20220824231200.494-3-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220824231200.494-3-leoyang.li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220904_181106_037957_4FD703B8 X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 24, 2022 at 06:11:53PM -0500, Li Yang wrote: > From: Xiaowei Bao > > Add the PME interrupt property to the PCIe EP nodes. > > Signed-off-by: Xiaowei Bao > Signed-off-by: Li Yang > --- > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > index ddae3cb0a977..fce3c6401653 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi > @@ -813,6 +813,8 @@ pcie_ep1: pcie_ep@3400000 { > reg = <0x00 0x03400000 0x0 0x00100000>, > <0x40 0x00000000 0x8 0x00000000>; > reg-names = "regs", "addr_space"; > + interrupts = ; /* PME interrupt */ The comment seems unnecessary, considering we have the interrupt-names below? Shawn > + interrupt-names = "pme"; > num-ib-windows = <6>; > num-ob-windows = <8>; > status = "disabled"; > @@ -849,6 +851,8 @@ pcie_ep2: pcie_ep@3500000 { > reg = <0x00 0x03500000 0x0 0x00100000>, > <0x48 0x00000000 0x8 0x00000000>; > reg-names = "regs", "addr_space"; > + interrupts = ; /* PME interrupt */ > + interrupt-names = "pme"; > num-ib-windows = <6>; > num-ob-windows = <8>; > status = "disabled"; > @@ -885,6 +889,8 @@ pcie_ep3: pcie_ep@3600000 { > reg = <0x00 0x03600000 0x0 0x00100000>, > <0x50 0x00000000 0x8 0x00000000>; > reg-names = "regs", "addr_space"; > + interrupts = ; /* PME interrupt */ > + interrupt-names = "pme"; > num-ib-windows = <6>; > num-ob-windows = <8>; > status = "disabled"; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel