From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tim Harvey <tharvey@gateworks.com>, Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH v2 1/1] arm64: dts: tqma8mpql: add USB DR support
Date: Mon, 5 Sep 2022 10:22:28 +0800 [thread overview]
Message-ID: <20220905022228.GB1728671@dragon> (raw)
In-Reply-To: <20220831074606.1677052-1-alexander.stein@ew.tq-group.com>
On Wed, Aug 31, 2022 at 09:46:06AM +0200, Alexander Stein wrote:
> Add support for USB DR on USB1 interface. Host/Device detection is done
> using the usb-role-switch connector.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Split from previous series
> * For now enable USB OTG only
>
> .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> index d8ca52976170..b30d75b1fa47 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> @@ -459,6 +459,37 @@ &usdhc2 {
> status = "okay";
> };
>
> +&usb3_phy0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb0>;
Should the pinctrl be in USB controller instead of PHY node?
> + status = "okay";
> +};
> +
> +&usb3_0 {
> + fsl,over-current-active-low;
> + status = "okay";
> +};
> +
> +&usb_dwc3_0 {
These nodes are not in alphabetic order.
> + /* dual role is implemented, but not a full featured OTG */
> + hnp-disable;
> + srp-disable;
> + adp-disable;
> + dr_mode = "otg";
> + usb-role-switch;
> + role-switch-default-mode = "peripheral";
> + status = "okay";
> +
> + connector {
> + compatible = "gpio-usb-b-connector", "usb-b-connector";
> + type = "micro";
> + label = "X29";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbcon0>;
> + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>;
> + };
> +};
> +
> &iomuxc {
> pinctrl_backlight: backlightgrp {
> fsl,pins = <MX8MP_IOMUXC_SAI5_RXFS__GPIO3_IO19 0x14>;
> @@ -666,6 +697,15 @@ pinctrl_uart4: uart4grp {
> <MX8MP_IOMUXC_UART4_TXD__UART4_DCE_TX 0x140>;
> };
>
> + pinctrl_usbcon0: usb0congrp {
> + fsl,pins = <MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 0x1c0>;
> + };
> +
> + pinctrl_usb0: usb0grp {
pinctrl_usb0 should go before pinctrl_usbcon0?
Shawn
> + fsl,pins = <MX8MP_IOMUXC_GPIO1_IO13__USB1_OTG_OC 0x1c0>,
> + <MX8MP_IOMUXC_GPIO1_IO12__USB1_OTG_PWR 0x1c0>;
> + };
> +
> pinctrl_usdhc2: usdhc2grp {
> fsl,pins = <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x192>,
> <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d2>,
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-05 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 7:46 [PATCH v2 1/1] arm64: dts: tqma8mpql: add USB DR support Alexander Stein
2022-09-05 2:22 ` Shawn Guo [this message]
2022-09-05 6:28 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905022228.GB1728671@dragon \
--to=shawnguo@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox