From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 999B2ECAAD5 for ; Mon, 5 Sep 2022 19:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=smT+M4GfVlj8701U+e+5S4Cjmq24X413CFTjU6hMbVg=; b=nli3so8NmxhWVO xEG8NOoNwQI6PeY086aceFeQdBKR1QIMSfmAxyV2vfXO/eCqEHhnhfHH2bEv+tI9u0G6Um3WCU6ts ekc3mQRnU1E+OGAucsSz32GmLfk7gW7FtA/hq2ABymzBocOF64sCAgxOXsVIwNeuvFmtM313tnk2d CC6UWjXbp6L+VJ/Gk1n/jKP7xMdc6q3jm+4z6PZ/TF7IcFB3Y8JI+AOB7NgbHjzISkpAnU73ZZCj9 022iRrSGRIpSn+TA7GiV7iVLZa6TLBAqafCwSfHu2kUmMQDpXKn6bdJPLEJKl14xC1s9OpP/XI2cF vdhNsKPYgBNOqQDRn7AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVI2X-009asn-Hc; Mon, 05 Sep 2022 19:45:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVHif-009FcG-Kc for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 19:25:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C5CE66146B; Mon, 5 Sep 2022 19:25:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4594CC433D6; Mon, 5 Sep 2022 19:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662405916; bh=57jshmal4TifwCJhJwupFxar74e24FF1+DL9zAhrS5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rUxGWg3ezE9iIUy2FENdwgwYONsygNkGTOVZlZVZL9ItoHzrQxHwefODWbouAZEl7 iE+prkF6c1Yp+K1xtYMUrVD1WMye+SPoAHhrBA6ZXSH89Z23gl2FW1GRLwo0mAh8x+ qfqNLXdHffKLS7qJah25bhHYQ6IprtWBF6JVVzJg5/DrZz+juUlYXlJlFGRp7EF6FH coPfjOyhN0BXcu9Cq8SIT5z45szPlyXp2c5hOT9qNabz4mjqOlmI1Z+hB6NLeuPzhY LXBVTTghhB3muVM7vpKs8mAsf2gCV66I0apOGleltS22hrXBlzSgd4uhPfsATkuZRT 4wANWTGTWapyg== Received: by pali.im (Postfix) id F2CBD7D7; Mon, 5 Sep 2022 21:25:15 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Thomas Petazzoni , Mauri Sandberg Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/7] PCI: mvebu: Cleanup error handling in mvebu_pcie_probe() Date: Mon, 5 Sep 2022 21:23:08 +0200 Message-Id: <20220905192310.22786-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220905192310.22786-1-pali@kernel.org> References: <20220718202843.6766-1-maukka@ext.kapsi.fi> <20220905192310.22786-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_122517_991736_609E1001 X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TW92ZSBjbGVhbnVwIGNhbGxzIHRvIGVycm9yIGxhYmVscy4gVGhpcyBzaW1wbGlmeSBlcnJvciBo YW5kbGluZyB3aGVuCnJlZ2lzdGVyaW5nIG9mIHNvbWUgcG9ydCBmYWlscy4KClNpZ25lZC1vZmYt Ynk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+Ci0tLQpDaGFuZ2VzIGluIHYzOgoqIE5l dyBwYXRjaAotLS0KIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMgfCA1OSArKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25z KCspLCAzMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVy L3BjaS1tdmVidS5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZlYnUuYwppbmRleCBk OWU0NmJkN2E0ZWMuLjk5ODZkZDQ4NjY4MCAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29udHJv bGxlci9wY2ktbXZlYnUuYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1tdmVidS5j CkBAIC0xODU2LDE4ICsxODU2LDE0IEBAIHN0YXRpYyBpbnQgbXZlYnVfcGNpZV9wcm9iZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQlpZiAoSVNfRVJSKHBvcnQtPmJhc2UpKSB7CiAJ CQlkZXZfZXJyKGRldiwgIiVzOiBjYW5ub3QgbWFwIHJlZ2lzdGVyc1xuIiwgcG9ydC0+bmFtZSk7 CiAJCQlwb3J0LT5iYXNlID0gTlVMTDsKLQkJCW12ZWJ1X3BjaWVfcG93ZXJkb3duKHBvcnQpOwot CQkJY29udGludWU7CisJCQlnb3RvIGVycl9wb3J0X2Rvd247CiAJCX0KIAogCQlyZXQgPSBtdmVi dV9wY2lfYnJpZGdlX2VtdWxfaW5pdChwb3J0KTsKIAkJaWYgKHJldCA8IDApIHsKIAkJCWRldl9l cnIoZGV2LCAiJXM6IGNhbm5vdCBpbml0IGVtdWxhdGVkIGJyaWRnZVxuIiwKIAkJCQlwb3J0LT5u YW1lKTsKLQkJCWRldm1faW91bm1hcChkZXYsIHBvcnQtPmJhc2UpOwotCQkJcG9ydC0+YmFzZSA9 IE5VTEw7Ci0JCQltdmVidV9wY2llX3Bvd2VyZG93bihwb3J0KTsKLQkJCWNvbnRpbnVlOworCQkJ Z290byBlcnJfYmFzZV91bm1hcDsKIAkJfQogCiAJCWlmIChwb3J0LT5lcnJvcl9pcnEgPiAwIHx8 IHBvcnQtPmludHhfaXJxID4gMCkgewpAQCAtMTg3NSwxMSArMTg3MSw3IEBAIHN0YXRpYyBpbnQg bXZlYnVfcGNpZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQkJaWYgKHJl dCkgewogCQkJCWRldl9lcnIoZGV2LCAiJXM6IGNhbm5vdCBpbml0IGlycSBkb21haW5cbiIsCiAJ CQkJCXBvcnQtPm5hbWUpOwotCQkJCXBjaV9icmlkZ2VfZW11bF9jbGVhbnVwKCZwb3J0LT5icmlk Z2UpOwotCQkJCWRldm1faW91bm1hcChkZXYsIHBvcnQtPmJhc2UpOwotCQkJCXBvcnQtPmJhc2Ug PSBOVUxMOwotCQkJCW12ZWJ1X3BjaWVfcG93ZXJkb3duKHBvcnQpOwotCQkJCWNvbnRpbnVlOwor CQkJCWdvdG8gZXJyX2JyaWRnZV9jbGVhbnVwOwogCQkJfQogCQl9CiAKQEAgLTE4OTEsMTUgKzE4 ODMsNyBAQCBzdGF0aWMgaW50IG12ZWJ1X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKIAkJCWlmIChyZXQpIHsKIAkJCQlkZXZfZXJyKGRldiwgIiVzOiBjYW5ub3QgcmVn aXN0ZXIgZXJyb3IgaW50ZXJydXB0IGhhbmRsZXI6ICVkXG4iLAogCQkJCQlwb3J0LT5uYW1lLCBy ZXQpOwotCQkJCWlmIChwb3J0LT5pbnR4X2lycV9kb21haW4pCi0JCQkJCWlycV9kb21haW5fcmVt b3ZlKHBvcnQtPmludHhfaXJxX2RvbWFpbik7Ci0JCQkJaWYgKHBvcnQtPnJwX2lycV9kb21haW4p Ci0JCQkJCWlycV9kb21haW5fcmVtb3ZlKHBvcnQtPnJwX2lycV9kb21haW4pOwotCQkJCXBjaV9i cmlkZ2VfZW11bF9jbGVhbnVwKCZwb3J0LT5icmlkZ2UpOwotCQkJCWRldm1faW91bm1hcChkZXYs IHBvcnQtPmJhc2UpOwotCQkJCXBvcnQtPmJhc2UgPSBOVUxMOwotCQkJCW12ZWJ1X3BjaWVfcG93 ZXJkb3duKHBvcnQpOwotCQkJCWNvbnRpbnVlOworCQkJCWdvdG8gZXJyX2RvbWFpbl9yZW1vdmU7 CiAJCQl9CiAJCX0KIApAQCAtMTkxMSwxNyArMTg5NSw3IEBAIHN0YXRpYyBpbnQgbXZlYnVfcGNp ZV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQkJaWYgKHJldCkgewogCQkJ CWRldl9lcnIoZGV2LCAiJXM6IGNhbm5vdCByZWdpc3RlciBpbnR4IGludGVycnVwdCBoYW5kbGVy OiAlZFxuIiwKIAkJCQkJcG9ydC0+bmFtZSwgcmV0KTsKLQkJCQlpZiAocG9ydC0+ZXJyb3JfaXJx ID4gMCkKLQkJCQkJZGV2bV9mcmVlX2lycShkZXYsIHBvcnQtPmVycm9yX2lycSwgcG9ydCk7Ci0J CQkJaWYgKHBvcnQtPmludHhfaXJxX2RvbWFpbikKLQkJCQkJaXJxX2RvbWFpbl9yZW1vdmUocG9y dC0+aW50eF9pcnFfZG9tYWluKTsKLQkJCQlpZiAocG9ydC0+cnBfaXJxX2RvbWFpbikKLQkJCQkJ aXJxX2RvbWFpbl9yZW1vdmUocG9ydC0+cnBfaXJxX2RvbWFpbik7Ci0JCQkJcGNpX2JyaWRnZV9l bXVsX2NsZWFudXAoJnBvcnQtPmJyaWRnZSk7Ci0JCQkJZGV2bV9pb3VubWFwKGRldiwgcG9ydC0+ YmFzZSk7Ci0JCQkJcG9ydC0+YmFzZSA9IE5VTEw7Ci0JCQkJbXZlYnVfcGNpZV9wb3dlcmRvd24o cG9ydCk7Ci0JCQkJY29udGludWU7CisJCQkJZ290byBlcnJfZnJlZV9lcnJvcl9pcnE7CiAJCQl9 CiAJCX0KIApAQCAtMjAxNSw2ICsxOTg5LDI5IEBAIHN0YXRpYyBpbnQgbXZlYnVfcGNpZV9wcm9i ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCQltdmVidV9wY2llX3NldHVwX2h3KHBv cnQpOwogCQltdmVidV9wY2llX3NldF9sb2NhbF9kZXZfbnIocG9ydCwgMSk7CiAJCW12ZWJ1X3Bj aWVfc2V0X2xvY2FsX2J1c19ucihwb3J0LCAwKTsKKworCQljb250aW51ZTsKKworZXJyX2ZyZWVf ZXJyb3JfaXJxOgorCQlpZiAocG9ydC0+ZXJyb3JfaXJxID4gMCkKKwkJCWRldm1fZnJlZV9pcnEo ZGV2LCBwb3J0LT5lcnJvcl9pcnEsIHBvcnQpOworCitlcnJfZG9tYWluX3JlbW92ZToKKwkJaWYg KHBvcnQtPmludHhfaXJxX2RvbWFpbikKKwkJCWlycV9kb21haW5fcmVtb3ZlKHBvcnQtPmludHhf aXJxX2RvbWFpbik7CisKKwkJaWYgKHBvcnQtPnJwX2lycV9kb21haW4pCisJCQlpcnFfZG9tYWlu X3JlbW92ZShwb3J0LT5ycF9pcnFfZG9tYWluKTsKKworZXJyX2JyaWRnZV9jbGVhbnVwOgorCQlw Y2lfYnJpZGdlX2VtdWxfY2xlYW51cCgmcG9ydC0+YnJpZGdlKTsKKworZXJyX2Jhc2VfdW5tYXA6 CisJCWRldm1faW91bm1hcChkZXYsIHBvcnQtPmJhc2UpOworCQlwb3J0LT5iYXNlID0gTlVMTDsK KworZXJyX3BvcnRfZG93bjoKKwkJbXZlYnVfcGNpZV9wb3dlcmRvd24ocG9ydCk7CiAJfQogCiAJ YnJpZGdlLT5zeXNkYXRhID0gcGNpZTsKLS0gCjIuMjAuMQoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK