From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FD5CECAAD3 for ; Tue, 6 Sep 2022 00:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yhU9WJK/utOvDVg6/lEQ6QsB3kSJ22sEigJdqMhtTs4=; b=KAxT1yWEB8qWmH k83aIZY5il0C7hKsnACCeW/xnhF7xsAgD287btR3KcDMmBH0QHGQzbzPEwiJmpRhMQ92PAK2kbH54 exhZOJmok6WUFT5giahhFE4gXm9cpNV8VKqR8BAALdOUxr4/l7na10LiE8LYxdSKoiqyc5TRiu3Ps rBSFdRVx6TCRs7iE1PDAyIys8mxhCjxXVA5W/lpaVc5YlSL/gDJGxQ5Zh95/GBi2J9tNFqucDI1Hu lM0NvqsPIQi7aCz1xxwknnXxNmrhcSc33J1uO16/EdDXy/HajjVvplLCdhN/26xjtKe2d6Am7d8tx 2AAvWL86JJihG+db+DHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVMBv-000bND-N2; Tue, 06 Sep 2022 00:11:48 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVM7v-000YZF-Hj for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 00:07:40 +0000 Received: by mail-pg1-x532.google.com with SMTP id 78so9131102pgb.13 for ; Mon, 05 Sep 2022 17:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schmorgal.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=ccOJio8OvVhKT9eRWLFa93p1CadNtYx//Tt6F1LDlyY=; b=VAuUUzX4L5paItKgWwiAmhZtw5rZDMEKCZZ/f8RY9HkMjK8G4xyvnDZow5EtwC0oc4 E8Bi/cgpFtB5AKtIOjoCYZWuEgnC/24DNq5Qww6pIDWQ6NdGbC/q/dfbgREz3sIFbIWa TaigSDcbQPcp7MvoUhWkOdw6Hqtnv8yGux49g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=ccOJio8OvVhKT9eRWLFa93p1CadNtYx//Tt6F1LDlyY=; b=TntVONpmiHM3oSVsLZHwI8u7JsiCuvQo+ErazTsovedsSoGgE9GsYWbT7i62PGyCgP pOjgaIEe5igtEHYzyYK3o/mDH+ezjc9esNhtkJAA23i9ICtFnSdOvRCoKxuUD1UaTzor NruITrT9wTgweKpLxx6Pda1EUOtBsWCAonBxg55qVghEHqRLPLy+0wrYdeDMx5fDtDAD FjKMGz4VkLn5FlyIf+DZa+NRzLfHif9o7DLWyd6Y70atIObwFNWOkL4YKi8vuPwDLCFW YOsfUFMAwsG2lLXrMIYmOcg/yOJosSazj0FGb9mlQZTszlc7Mesr+9Gbk7TlR6ijXqoR cAVw== X-Gm-Message-State: ACgBeo2ZRrG+KjdQj+cMF871oarcOLDhPdqhyWDSMjAn2cjvNZmj2bqe 8u0j+hqFag0zKN0VWBVAvl30iA== X-Google-Smtp-Source: AA6agR6dP+N069mNXwdxsq3HUnT7M0IZLsP6Iy12XKSHEYo5sfAf6ztqQiV4xezj3K00SmvXqbP9yQ== X-Received: by 2002:a63:5702:0:b0:42a:b77b:85b3 with SMTP id l2-20020a635702000000b0042ab77b85b3mr42537847pgb.263.1662422855464; Mon, 05 Sep 2022 17:07:35 -0700 (PDT) Received: from localhost.localdomain ([50.45.132.243]) by smtp.gmail.com with ESMTPSA id ik12-20020a170902ab0c00b00176ca089a7csm607538plb.165.2022.09.05.17.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 17:07:34 -0700 (PDT) From: Doug Brown To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Vinod Koul Cc: linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, Doug Brown Subject: [PATCH] dmaengine: pxa_dma: use platform_get_irq_optional Date: Mon, 5 Sep 2022 17:07:09 -0700 Message-Id: <20220906000709.52705-1-doug@schmorgal.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_170739_678887_FAB66D4E X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The first IRQ is required, but IRQs 1 through (nb_phy_chans - 1) are optional, because on some platforms (e.g. PXA168) there is a single IRQ shared between all channels. This change inhibits a flood of "IRQ index # not found" messages at startup. Tested on a PXA168-based device. Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()" Signed-off-by: Doug Brown --- drivers/dma/pxa_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index e7034f6f3994..22a392fe6d32 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -1247,14 +1247,14 @@ static int pxad_init_phys(struct platform_device *op, return -ENOMEM; for (i = 0; i < nb_phy_chans; i++) - if (platform_get_irq(op, i) > 0) + if (platform_get_irq_optional(op, i) > 0) nr_irq++; for (i = 0; i < nb_phy_chans; i++) { phy = &pdev->phys[i]; phy->base = pdev->base; phy->idx = i; - irq = platform_get_irq(op, i); + irq = platform_get_irq_optional(op, i); if ((nr_irq > 1) && (irq > 0)) ret = devm_request_irq(&op->dev, irq, pxad_chan_handler, -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel