From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A014DECAAD3 for ; Tue, 6 Sep 2022 02:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aoeCr14cNYDjOoDxzawFabM+bSanECKh87vfGE9pavA=; b=FtDwDeCC3SElgI 1QrrOaP8wg0spwaUtY3yZ07XLaRJovkZrNFdIvj/jvYXqvXwCGxxELbrM83p3flY4grd4yQEl1ZgQ xn3QiqW2hAFwFzzZM0VPByJa1+XvaGmZ66OTXvN37a2UIP5aJIz7a5Chlec8xw99BE6n8tgxfqKeZ jBw5zJCFA8IR/iA1UA9wR6aT2fvPyDaUgz6pSWB0PD7WweY/IeQP5VrTxY/nWkL5XXBnKhzbVW5+c 11nbUVQ21FB8o6T5NGuuPn++s1e22dL2KVtvaXLa/vaWN+wwFowQkWHBCa/pzIuEo7xog9U1SqI7I WRQLstz9/cuX6nNNJySg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVO1q-001azU-0I; Tue, 06 Sep 2022 02:09:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVO1m-001axc-IW for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 02:09:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 310DD6009F; Tue, 6 Sep 2022 02:09:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BBF9C433C1; Tue, 6 Sep 2022 02:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662430164; bh=OqhKXbWG5ke7d+FfI5lTae10PqHJN1Ent44NtvHaBtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ew2akOycaeTNbsadj1hHiJ8rMvhJGelayvJW+N1y/4D8QZ+mYqwUQXtx/alo3G7RE AYaU4T3AOnLBnDttLY9Gb+QcKfMynsS5C3uZF+iIhzqUdbsOYe9xqqq7kAVt/YQN55 pZa/+jO3BuSHMOXYWQeMHhOwV42/wL8gj1zqhLN9RquWvwRjAYPxSNI/KbcNFDo3ya 0hwZ1U1wnGoJ6hYu8LxtPtJ83P32RxIwj2XRuENPmBTerYkVL/Zo8/8mrOs/r4hN2S 0ssbLuGRKfQJ8ajhAM8aaYNTfJSpFOEDWlQixI+ih5rfSMAZuTwVIGd9oIao6ONaQE JCVXnrbgXdWFA== Date: Tue, 6 Sep 2022 10:09:17 +0800 From: Shawn Guo To: Peng Fan Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, aisheng.dong@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , kernel test robot Subject: Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver Message-ID: <20220906020917.GM1728671@dragon> References: <20220823055215.1139197-1-peng.fan@oss.nxp.com> <20220823055215.1139197-5-peng.fan@oss.nxp.com> <20220904104403.GJ1728671@dragon> <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <26552553-b598-3179-40f8-170e766e3809@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_190926_683271_2459E0B0 X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote: [...] > > > +struct imx93_blk_ctrl_data { > > > + const struct imx93_blk_ctrl_domain_data *domains; > > > + const struct imx93_blk_ctrl_domain_data *bus; > > > > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data. I > > would suggest you have 'related' fields directly defined in > > imx93_blk_ctrl_data. > > This would implies a bit large change to this driver. > > Should I use a new V1 for the patchset or continue V9 for next version? I think v9 is fine. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel