From: Cristian Marussi <cristian.marussi@arm.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com,
etienne.carriere@linaro.org, vincent.guittot@linaro.org,
daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com,
adrian.slatineanu@arm.com, souvik.chakravarty@arm.com,
wleavitt@marvell.com, wbartczak@marvell.com,
dan.carpenter@oracle.com, lukasz.luba@arm.com
Subject: [PATCH v2 2/3] powercap: arm_scmi: Fix signedness bug in probe
Date: Tue, 6 Sep 2022 15:23:36 +0100 [thread overview]
Message-ID: <20220906142337.1697569-3-cristian.marussi@arm.com> (raw)
In-Reply-To: <20220906142337.1697569-1-cristian.marussi@arm.com>
From: Dan Carpenter <dan.carpenter@oracle.com>
The "pr->num_zones" variable is an unsigned int so it can't be less than
zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/powercap/arm_scmi_powercap.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c
index a91438867f8c..76200c004cad 100644
--- a/drivers/powercap/arm_scmi_powercap.c
+++ b/drivers/powercap/arm_scmi_powercap.c
@@ -389,11 +389,12 @@ static int scmi_powercap_probe(struct scmi_device *sdev)
if (!pr)
return -ENOMEM;
- pr->num_zones = powercap_ops->num_domains_get(ph);
- if (pr->num_zones < 0) {
+ ret = powercap_ops->num_domains_get(ph);
+ if (ret < 0) {
dev_err(dev, "number of powercap domains not found\n");
- return pr->num_zones;
+ return ret;
}
+ pr->num_zones = ret;
pr->spzones = devm_kcalloc(dev, pr->num_zones,
sizeof(*pr->spzones), GFP_KERNEL);
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 14:23 [PATCH v2 0/3] Add ARM SCMI Powercap driver Cristian Marussi
2022-09-06 14:23 ` [PATCH v2 1/3] powercap: arm_scmi: Add SCMI Powercap based driver Cristian Marussi
2022-10-07 15:09 ` Rafael J. Wysocki
2022-10-07 15:39 ` Cristian Marussi
2022-10-10 9:21 ` Sudeep Holla
2022-10-10 13:14 ` Lukasz Luba
2022-09-06 14:23 ` Cristian Marussi [this message]
2022-09-06 14:23 ` [PATCH v2 3/3] powercap: arm_scmi: Fix a NULL vs IS_ERR() bug Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906142337.1697569-3-cristian.marussi@arm.com \
--to=cristian.marussi@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=adrian.slatineanu@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tarek.el-sherbiny@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=wbartczak@marvell.com \
--cc=wleavitt@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).