From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23CC8C54EE9 for ; Wed, 7 Sep 2022 13:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OJ9UhN/BKQBmEOnxVcYMeriC1PO5h51BhgxV8xFDV3Q=; b=4sna8pnBelFRKC BRx6AlNOtrCBb1fusFnsFIz4GAjJM8di2kzZG8ZxYH7uXmhnS4rfUjeio7utm9xPASs7Jba/6E0yR REiZT900wfoyem7QQxzCBQ/lzpcRMqve+IFKsYRf1WwmPN2gfGBGO6Ngqm5vyDEfILPol14GFfJux AY5vu+yrfOxxGrPb3UOv1CA12Az6sDgW8149ugEbF4eoIvOgM6c6XZ3QWd87cASgf/ZFb/+hRhDAA HGm6owFxBrUCBlhNkiQdcN5znGujDDOSs+XQX7Ywfv3lsYbf4ngEvpzHt8ixoDme0kGlXRaj5Id0u b04RZ5mt6LjHP6lS7odg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVumL-006MQ6-UR; Wed, 07 Sep 2022 13:07:42 +0000 Received: from mail-am6eur05on2079.outbound.protection.outlook.com ([40.107.22.79] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVumG-006MN7-Ju for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 13:07:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MH01MFBWvRSG4Cr62pZ3HtBgGBvHTg1KWj96Fth6IOjDIXSFx0+anT9YKXiik0oTJqFhKCCsChEzDWdaDOm4dn6Vq7uFETqR39G8VhQiLnuoPGOO7iURVn9pkDzTYq36pA9ejEbkR13ksx4MOQV2pzogRY/smDUE3/TXfoxR5QP55iX/c4pTrZ//tQLRPSmI+xFusyE8Lx2fICIGof+xqfLhxUwEPn7rz+W2F32D2xLnJcoVWMyiwJqapP+nR7lIc8jZDFEK6E1StkTUAK7AgRiQxkZaHJJrvfw9pRoNtzCmhiRsYzBRstain5g/oVcPbVxKBrGpz7eEoPSfOhPgHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s34KHKknZTa+rkIpTlVInSTNphNzELlWBVbzHrk/JQk=; b=nFW91C//B2gDRJcFZ+qXsC0kFiPdDCPY/nR9Y1Wjal/he/NWlLKrWw2YDZTdeUmu+FbAYr3SI1ZHSLyDh5Vk5fSWrWmimvQ9t5dtLVfvcZfuQ33s+FwpMzZzSwtERV2CGBX8mJcJT7uj3AsgYXQtiDsL2sKtxC7MV7SZP2+SskprAOgpuPXSE+PC8q690Bc4fLAGRYO809/ReNQe2FhRCAHvYxtmmVvr4TF6g+/RfIN6Ep2jN09gbfEiLV0Hd+yENLfx/8N6WMRGqx+NEAGd4uK5luuuvBL1oiU7TO8NCjKbzsVRr0gbxHPPJBrxzKEaHQyETHNjjf2gGNYEVt9/Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s34KHKknZTa+rkIpTlVInSTNphNzELlWBVbzHrk/JQk=; b=blV95CgzL3G75lAceV7wH4nwBzw9ZD2DnWm1SbYCkwkJsMhtzXpG33PY0B4dnIIXMrazTU317yS4WDack2teiQ3P9u4rwrWWEfWM1hBO1AzpcBeJaqeSLVo6zobvWYuoprE54fRW7vo1nsMLnxcwSL3fZquVpCIWBRiIGNcJwaI= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by PAXPR04MB8591.eurprd04.prod.outlook.com (2603:10a6:102:21a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 13:07:30 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::3412:9d57:ec73:fef3]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::3412:9d57:ec73:fef3%5]) with mapi id 15.20.5588.017; Wed, 7 Sep 2022 13:07:30 +0000 From: Vladimir Oltean To: Michael Walle CC: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Shawn Guo , Leo Li , Rob Herring , Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH devicetree] arm64: dts: ls1028a-rdb: add more ethernet aliases Thread-Topic: [PATCH devicetree] arm64: dts: ls1028a-rdb: add more ethernet aliases Thread-Index: AQHYwW37dzULUFcX/0OQXQkpZmzQZq3RZ7aAgAAbB4CAAIrBAIAAIAOAgAF/HICAAEYXgA== Date: Wed, 7 Sep 2022 13:07:30 +0000 Message-ID: <20220907130729.whphxfmcp7odwkkf@skbuf> References: <20220905212458.1549179-1-vladimir.oltean@nxp.com> <20220905235413.6nfqi6vsp7iv32q3@skbuf> <0c1b726c6791cc97f9ba15f923264630@walle.cc> <20220906100525.mhjomm6f2y4lr3lw@skbuf> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72a976aa-e163-4770-e278-08da90d1ebc9 x-ms-traffictypediagnostic: PAXPR04MB8591:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: naHCSRfzgGkG0sI1j+ME/OHRU72oWsh79lU46NDHvydYxGrupNWVCkdt1JBOIfofSF+RZDdPP5JijdbfcLLrNyJo/MEs6OWm44/WwOOIcXNdsx+afNgJr2tBrPZrmNQlPXWE326fmWBecnNBO3C9kGAosjPw2+bez8klZiPqxPZF4P4GgNYFOQnXbkxvzdf//kH+j9wb0Um1ffGtUKMRPRL4ZHpmy5MkVs52zwk6+YtGL1qFlnxlPWmQsZh/I4iIdnTCZ5qIk4b2ym/vaZu468zAZMPZRlrrhQcZVMLSsaBW5TUeA1fYVK8GvTpnuD387MdKIBioSKXbfgoMDplWwLKbNWV8RShQ/RlCzvhbVdWRnKzL9UEy6BZ67eNaZc84HB2Ac5MmUeZA50xKifQdmyZVgWqKc99bphXBSqfrmwayowHu4J0bVrFNr0EynJPSzXMyHhGRIyJHXEpmnZeF4ERdnttKSM5pOLMH+n+u7ymyO5+Y6QdUDZRKM3sl+F9VwoALQzpGRG3PEeO6aH2paWR6s5tNVndKZkkJjBj3AkuLexlyvSYK7nXyxe5Ndc6RDvsqmNqFKmM1vKtyqW74AqxnzFf77W0x0gB2yNhCHLVz2EwL3Zg/Xo+lzutDHMN1XxJ0Ry8L/Grr2oriYSzfk9cOPmcUW6A9PHVZfKPBLdtEM+4/R0SI4CFTHVSTbQ2Y7HykTikYSAO5B9QgI/NPVt1YxlyrBhT1vqYPkuccf0RQlbtAGbb0ve9+dBOO7/bCPSzo8yfmY+RbmLsG9uJ/Bw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5136.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(39860400002)(376002)(396003)(366004)(346002)(136003)(5660300002)(41300700001)(8936002)(26005)(6512007)(9686003)(2906002)(86362001)(6506007)(38100700002)(44832011)(33716001)(122000001)(38070700005)(1076003)(66946007)(186003)(6916009)(66476007)(66556008)(54906003)(66446008)(478600001)(76116006)(64756008)(6486002)(8676002)(71200400001)(316002)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zbACn1u7tP2Zb4OLExanIm+JMPFjDftiDLlDgufSNJFrnrKiRBx3tEpKtmFK?= =?us-ascii?Q?P8XR160Uvoy5E8a2NPGtJ3vB3vYzc4b00LdJEI9tyTVrLs+0AObcfJE4y4Pl?= =?us-ascii?Q?3AQOOx5r/F1MeNdOG9sWQEltu2jtYdDvLAhS6SzzJFpDUzmRai0x9NQ4oMkm?= =?us-ascii?Q?SuKdjtBYPQ0zyP8jI7rCzVJMnD924EfH0FVt5poCtrdnu4rR/fbNbIg/dHJe?= =?us-ascii?Q?lzi7nlL+JqqjmjUurIem+VuqineENa++FAT34f2qHL18LLE7juyCUDIXSVXS?= =?us-ascii?Q?QPrOUpeDaOYXaGNiq7KIPNAGOhNZGFjvTewQKwHb5OYpHhhA5cKnbNXvM4Vk?= =?us-ascii?Q?2s1cm3pLIg4bAK7Pc0yXJHN6xLOIftEU3HK3R20+c05PbwR8x2H3e47FCBwz?= =?us-ascii?Q?keo8h/bgFlJpdlrT8cKoJOyWBewNjlsLgmdlXOXz98mJ+gKVSolMtp3IZn6W?= =?us-ascii?Q?v7D3n3Z3eJi+MQnVJWh4tC9qxNnv+qf92FuNJ/FuyPFGQ8rF0hmGLcb+azVJ?= =?us-ascii?Q?+2B+Uj3kaWIMNr+PjHD+ZCOvDc8HHEz6uopORRHVfonQCNZMTz3chvwettF9?= =?us-ascii?Q?mNx9DuPjO2IU+aitq2Uzw375cwdbKLiMKDRdkaiSNTyhF32SyA0DtA+f/vRC?= =?us-ascii?Q?ZKy7WleTT/ycrylXlcxgF8JRRN/hmTyTUWGCFX6iD68E50ro/1y6Tdy9DpK1?= =?us-ascii?Q?a49yovH5IUDP7sDYm4gnd2YxhAplGF/nbjURmsYa5ecnADXLhpNNHqZc719a?= =?us-ascii?Q?7tyWpNrnqm59DoNlA/BA05Cp9bZVsbXDHLN2cnIijOnr2LkrEMvGQ++v7Bqx?= =?us-ascii?Q?qm+LPYGAwZmmpD1IVRk0iTPBjn1thgy2tZFJG+aMR4KmIy0HkqGq7PH+OzSF?= =?us-ascii?Q?4VvWWtI0+PYMjKH/JnRNMJ1kd8rPGvX2ZLqk4rf8/6vXPgg1bZ1XN2MrH+qf?= =?us-ascii?Q?ewVpJyM6NnjU2wlcN1YBIPdyBKdAzfFQbbo2L6yjGMSXUtrpGYZ1s45idA8q?= =?us-ascii?Q?XijeMEGnvTrG7+CHAzhhl1MsCur3mJ4mHcyG3qrbgYih1mhcHBxtpV8LcKIl?= =?us-ascii?Q?/No+tggq0YRClo/7aCHTQfZRWzM67/pz3asaIfxnMVwY7ybsmAMNG3ylCT4q?= =?us-ascii?Q?4qqUtvzAiAVa4J2U55cafLafBJ6SKpGnSNCjYThmDVXFDE9VykgUOwmmJTLN?= =?us-ascii?Q?ZsF9MWdEc3C3gi43q542wDysJoHVr8+mzhpEYc82NOU4a680ueWpyxI+XHKQ?= =?us-ascii?Q?8UeoCrHw/EZbAvj+V1mrMHmBg0hOgvoNnkaJfHc0XZgyhhnoQs+wQ6szSeKs?= =?us-ascii?Q?RhoyqG+SIR6O5kVOvdhuo+k371At2D0RPWkpv3LzMlUA7nU+9wR34nJqyWm9?= =?us-ascii?Q?HmldffrXFvz28//VVBrQGBUAChCliiKvzw4184b56oAReeul6262qAnsA6So?= =?us-ascii?Q?joL3knxBQaL4rI4ggxFVgQ4RVzY6E5KVGDFTomg/tzwh87ydjhZ61X9SCPba?= =?us-ascii?Q?sNdCKZ64hJbUY/vFl+AuLfpN4A/jIsbbmWuOSltcK7TdbjacTL7dZt7zbzgj?= =?us-ascii?Q?zStb58C2gmzfRMwd23uPWTEnFtqyRJhkOb4iPZuBDBZaHPVk4OFIW3rr90f6?= =?us-ascii?Q?mQ=3D=3D?= Content-ID: <7EEC1B2F9B173543B697EE41C70DE22C@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72a976aa-e163-4770-e278-08da90d1ebc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 13:07:30.4631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LV/sABZvX0Rx2xGzF0NUcK8VYFSE25JEEV9pOl7LjZXe2k1UTMcdPqHQUTHn/fky25YKsdCX+2+FqXcz25jtRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8591 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_060736_867586_22D80A36 X-CRM114-Status: GOOD ( 24.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 07, 2022 at 10:56:37AM +0200, Michael Walle wrote: > > > I think we are on the same track here. I was ignoring any VFs for now. > > > So I guess, what I'm still missing here is why enet#2 and enet#3 (or > > > even swp4 and swp5) would need a non-random MAC address. Except from > > > your example above. Considering the usecase where swp0..3 is one bridge > > > with eno2 and eno3 being the CPU ports. Then I'd only need a unique > > > MAC address for eno0, eno1 and swp0, correct? > > > > Don't say "unique MAC address for swp0", since swp0's MAC address is not > > unique, you probably mean to say "a MAC address which will be shared by > > swp0-swp3". > > That I actually don't understand. I have the following addresses after > booting: > > # ip link > .. > 4: gbe0: mtu 1500 qdisc mq state UP group > default qlen 1000 > link/ether 00:a0:a5:5c:6b:62 brd ff:ff:ff:ff:ff:ff > inet 172.16.1.2/24 scope global gbe0 > valid_lft forever preferred_lft forever > inet6 fe80::2a0:a5ff:fe5c:6b62/64 scope link > valid_lft forever preferred_lft forever > 5: gbe1: mtu 1500 qdisc noop state DOWN group default > qlen 1000 > link/ether 00:a0:a5:5c:6b:63 brd ff:ff:ff:ff:ff:ff > 6: eno2: mtu 1504 qdisc noop state DOWN group default > qlen 1000 > link/ether 8e:6c:20:8a:ab:52 brd ff:ff:ff:ff:ff:ff > 7: eno3: mtu 1504 qdisc noop state DOWN group default > qlen 1000 > link/ether c6:fd:b1:88:3c:36 brd ff:ff:ff:ff:ff:ff > 8: swp0@eno2: mtu 1500 qdisc noop state DOWN > group default qlen 1000 > link/ether 00:a0:a5:5c:6b:66 brd ff:ff:ff:ff:ff:ff > 9: swp1@eno2: mtu 1500 qdisc noop state DOWN > group default qlen 1000 > link/ether 00:a0:a5:5c:6b:67 brd ff:ff:ff:ff:ff:ff > 10: swp2@eno2: mtu 1500 qdisc noop state DOWN > group default qlen 1000 > link/ether 00:a0:a5:5c:6b:68 brd ff:ff:ff:ff:ff:ff > 11: swp3@eno2: mtu 1500 qdisc noop state DOWN > group default qlen 1000 > link/ether 00:a0:a5:5c:6b:69 brd ff:ff:ff:ff:ff:ff > > gbe0 is eno0 and gbe1 is eno1. So in my case they are unique. > > When adding all the ports to a bridge, the bridge gets the lowest MAC. > > # ip link add name br0 type bridge > # ip link set swp0 master br0 > # ip link set swp1 master br0 > # ip link set swp2 master br0 > # ip link set swp3 master br0 > > 12: br0: mtu 1500 qdisc noop state DOWN mode DEFAULT > group default qlen 1000 > link/ether 00:a0:a5:5c:6b:66 brd ff:ff:ff:ff:ff:ff > > Is that what you mean with "a MAC address which will be shared by > swp0-swp3"? No, what I'm trying is only to reformulate what you've said, "Then I'd only need a unique MAC address for eno0, eno1 and swp0". My understanding of what you mean by "unique address for swp0" is that the addresses for swp1-swp3 don't matter (hence they can be set to the same address as swp0) since there will be a bridge that serves as the IP termination point, with its own MAC address, inherited from the first bridge port, swp0. But this makes it improper to call it a "unique address for swp0". _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel