From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E708ECAAD3 for ; Fri, 9 Sep 2022 12:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gUlWBl9hPY3/G9/pzqM29C1QjbIAInEztJGGGoWDjTU=; b=fBYU9yHKJPSJP7 Mzm2Nms9C/g/psyP2bm5CutS804VfHqzmBk5uOlNh+N01GGV29SnWnGBxyV4+2xSr76CjQHwTWGTj j8a729ZfJGaqbbp0nf32KpEi1uFN7+Rt5cM/6ObFMFe2tpVUoa/n8smRBRWcq8v7FL4lRaEUGeLpe ewd3CgDAa+OB5BaU7AwnMI4dy8uzpJCX0Lp3aa0sHfO4AIhMc7WrmHjEXXgNOzW8FXN5koW3O+uxT EN0UfnBnFxBwh/Wy/PF7f9XV3cOBCrSTw5bvCYyRZEQCrt9CqrzaZFFcqluA9QUGqkaKOS6YnAT+l w0qreUB5EntknvTjyydg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWdZz-00GBPi-Eq; Fri, 09 Sep 2022 12:57:55 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWdZx-00GBOG-9E for linux-arm-kernel@lists.infradead.org; Fri, 09 Sep 2022 12:57:54 +0000 Received: by mail-lf1-x133.google.com with SMTP id u18so2518671lfo.8 for ; Fri, 09 Sep 2022 05:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=S4/m6aJI9RYrEBxRHv4vOa1BDy2/J11xb+qcIeUTq4Y=; b=chKaoVYxLtYqjBSP/4q/+lWZ9IYwPzQcFdhYdydTIMSaWWVpK3WfDTZ3vIs5phQ0my 5/06w6DKnzHyBdoxAD9virgcWldBdte6NXVJN+HbA9SiDJrYYMAJIsoclGROWSp1nNhN iZlk/7Dsoh8XVES3v7+Q2G+n/LdLku+D8U1GNeO1W4KP7RTn+kzuLp2f4ZLCNuQl2p/3 3WLnqgR7gr3lQ7AWe5bQZpw3R1c9hvN2X2zfKJvwxTYWnAvoRCiMXY4w/fxJ46oaQZ8y iLCnyZc16O4uJ3+eZ63mwvU+zsBCg7oPLG5Mx95ebgjeL0GBC+iCQyVJJhAKcsG6AAP0 nkoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=S4/m6aJI9RYrEBxRHv4vOa1BDy2/J11xb+qcIeUTq4Y=; b=jzgK0Z3Z+fd8Gmbfp2UEiE6K9vGnBHoliUg3LcxDu8YRNFSQXAP0oZuQZ2i4p2MLlu Bjm2/XSvJtWU1vBENilozK9hzAywn9/5P9xiYTBpgHlknRXBACspMJ60zpYVJ4ZFx1p6 aOPDCLLkBToI6hGKHN5EKEznjQgHgNkI0rGqbdgcOJSN++YnoQGuemzICVo3PogxyxPx 0Yu0uiV/ZzD3r+HC/aDD4dTiqGqev31mFzgqiFu5I0o28jqIFa5EL5/qrAdkl8nxwGO+ KdDZ5UdGCK/7rv4dzS2TgfdXF+bHXllr2zKuUDJNxYE93TAHJ3Sc02JMqGa7ZTVnZ27Y 6xWw== X-Gm-Message-State: ACgBeo1+TewK9cvc64wAjcaOg736UUGQDZEO13dn7DxWnjho2VNoKi1o 4Fyf+dO+5y41YDFhomssQbg= X-Google-Smtp-Source: AA6agR7Sz7rXYWYQKDSTMczmekU48EdA1TJUJPL7yFZTbw7xckVNXhdmOUhAsNxxA8z/6IZjCaHcgg== X-Received: by 2002:a05:6512:ad3:b0:492:d78f:2c09 with SMTP id n19-20020a0565120ad300b00492d78f2c09mr4126789lfu.99.1662728268489; Fri, 09 Sep 2022 05:57:48 -0700 (PDT) Received: from mobilestation ([95.79.140.178]) by smtp.gmail.com with ESMTPSA id f29-20020a05651c03dd00b002688cceee17sm64429ljp.131.2022.09.09.05.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 05:57:47 -0700 (PDT) Date: Fri, 9 Sep 2022 15:57:45 +0300 From: Serge Semin To: Rob Herring Cc: Serge Semin , Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Krzysztof Kozlowski , Manish Narani , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH 02/13] dt-bindings: memory: snps: Add Baikal-T1 DDRC support Message-ID: <20220909125745.42myr3zwwbfn2tea@mobilestation> References: <20220822191957.28546-1-Sergey.Semin@baikalelectronics.ru> <20220822191957.28546-3-Sergey.Semin@baikalelectronics.ru> <20220830180028.GA1758236-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220830180028.GA1758236-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220909_055753_327984_51D86890 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Sorry for missing your message. It has kind of got lost among the Krzysztof' comments. On Tue, Aug 30, 2022 at 01:00:28PM -0500, Rob Herring wrote: > On Mon, Aug 22, 2022 at 10:19:45PM +0300, Serge Semin wrote: > > Baikal-T1 DDR controller is based on the DW uMCTL2 DDRC IP-core v2.51a > > with up to DDR3 protocol capability and 32-bit data bus + 8-bit ECC. There > > are individual IRQs for each ECC and DFI events.The dedicated scrubber > > clock source is absent since it's fully synchronous to the core clock. > > In addition to that the DFI-DDR PHY CSRs can be accessed via a separate > > registers space. > > Are you sure the phy and dfi irq shouldn't be a separate device? I am sure that the DFI IRQ is a part of the DW uMCTl2 DDR controller specification. The DFI interface has a special signal called "dfi_alert_n". It is supposed to be supplied to the DDR controller from the DDR PHY. The signal state indicates the CRC/Parity errors detected on the address/command sent to the PHY/SDRAM side. Aside with some other statuses the signal state is reflected in the DW uMCTL2 CRCPARSTAT register. The CSR state in its turn is then sent out via the corresponding output wire (dfi_err_int) up to the IRQ controller. So to speak there is no doubts the DFI errors IRQ is a part of the DW uMCTL2 DDRC IRQs interface. Regarding the PHY CSR space. You are right. It is a separate device indeed. I'll drop the PHY CSR region from here. -Sergey > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel