From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B66B6ECAAA1 for ; Tue, 13 Sep 2022 02:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k42Ah5NCdvm6EhYTkLonrpdI/kUL31KmE4ABwowXGdg=; b=Zj/+RJy1T2G82E bgJ6UAArTDQ3oG1R6V2aSQ6S+FyYhtlvfpF0TbxXs8O1dcJmXoQgde9jOas7HkJ97NLA/pPvzjnIU ebx8HmOnIyPwAqeNCHgiFVJRPiBQ4BRuSW7q3Ery80y+FjAU1xwGJGyqRglIYWSzpdPWpVhlEdI6b VLzPuixRhBmAzrP4gCJdMQkwLN92OZ04+FsgJnBNvwL7Gy9JCFH/23m+o5EF54OG05jQAJMAUqmum j0UnkteAvv/d5cAt2dyneNG0tEeQ6lZbeqV0p/d/i1xd2XjDCB8BQEWCH3bR1F/5BgNB2W94SJezY y1DFbEC9aVM3O/Hcak5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXvKb-0007fi-Lk; Tue, 13 Sep 2022 02:07:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXvKY-0007Wg-H7 for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 02:07:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 006E061251; Tue, 13 Sep 2022 02:07:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88AEEC433D6; Tue, 13 Sep 2022 02:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663034834; bh=6szBzBcA80yfhLBaS718DT01/BeRIqYhT2meY4Qtyl8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qELHrdFTR09Frx+jF5R60y3ci5sXEhT7FFIDHMy6X86j7OdAjHlGKKStEYtC3cCDv A+eNDPM+RP8cAxXVTitYUtzuYD+drHwNahrzf7l0XqNXOR6tbFLKaGahnOpQJYtkB/ E3BkaAoUCOOqC+j4tCzcw8btbLfJAnMV/kR36Xaf1vyvOk7WtFlU8ExdddpJlP17ir MrndvPFBwk5m6CXe/lDnC8gQ6Xku17AoqPFnA/aKV3XH9mj3k4kqykvt7Z7GCCGZZ1 wQU2PcEvsyZOgnAjpnCwKxzXyQM6mR1FXeeJDVJAoHO3SE0Fn6Onq/rZ9MxoTnP9ua 8OgyY6cron0Wg== Date: Tue, 13 Sep 2022 10:07:08 +0800 From: Shawn Guo To: Shenwei Wang Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Peng Fan , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" , dl-linux-imx Subject: Re: [EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board Message-ID: <20220913020708.GE1728671@dragon> References: <20220822175245.222691-1-shenwei.wang@nxp.com> <20220822175245.222691-6-shenwei.wang@nxp.com> <20220903034819.GF1728671@dragon> <20220912081649.GR1728671@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_190718_628812_CDF1A991 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 12, 2022 at 02:35:18PM +0000, Shenwei Wang wrote: > > > > -----Original Message----- > > From: Shawn Guo > > Sent: Monday, September 12, 2022 3:17 AM > > To: Shenwei Wang > > Cc: Rob Herring ; Krzysztof Kozlowski > > ; Sascha Hauer ; > > Pengutronix Kernel Team ; Peng Fan > > ; devicetree@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; imx@lists.linux.dev; dl-linux-imx > imx@nxp.com> > > > > > + > > > > > + reg_fec1_sel: regulator-1 { > > > > > + compatible = "regulator-fixed"; > > > > > + regulator-name = "fec1_supply"; > > > > > + regulator-min-microvolt = <3300000>; > > > > > + regulator-max-microvolt = <3300000>; > > > > > + gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>; > > > > > > > > Missing enable-active-high? > > > > > > No. Enabling this regulator to select the fec1 interface instead of usdhc2. > > Pulling this GPIO pin to low is to use FEC1 interface. > > > > Then the polarity cell should be GPIO_ACTIVE_LOW rather than > > GPIO_ACTIVE_HIGH? > > > > That doesn't matter since any GPIO phandle flags are ignored in the node of "regulator-fixed". The final flag is only determined by the property of "enable-active-high". If there is a "enable-active-high", the GPIO line works as active high. If no such a property, it works as active low by default. Right? > Well, we are talking about the correctness of DT (hardware description), not how kernel driver works with DT. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel