From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 082E2C6FA82 for ; Tue, 13 Sep 2022 15:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kSq/ixTXF9fuKSVPdie7iwU1107SLMOdm4gGsA5afno=; b=VjMmxxI10IXApw B6KH3qY9cILDZKwBHyE6CyiKZAbyHmtZPaSGkNqjOMcovK059IsUtNL4C6fVbWGo9hS4+uIdQrB+m 4vIWtIFiaCXLfCHf3lf3ox1dSblIaP5lg44XNQgRq30mPrIUL8np8CHvX+P1cJLkegw7k2/D2wEEN SQW8qG3q+CCTILh5Dv2uZdtryg45LDJKzDdfZQnr13mF2H2tZxohl/yZyEm6SvnMWLoTotOYI28ex SGrPBT91V0UPcyySwgoWa0OYZkmDEH6RkNkYhcAn5ByhT0N7hqjihELefrcoJ2RkOGHuW+6707SZA V1ZvW0U1r4T1MpfUKV1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY8C5-00CokO-FH; Tue, 13 Sep 2022 15:51:27 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY8C2-00CohE-J4; Tue, 13 Sep 2022 15:51:23 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1274ec87ad5so33334953fac.0; Tue, 13 Sep 2022 08:51:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=6Zxhbl7LxU5qELLtcpL71bgm+csNbrX5/FOGxIAUqIw=; b=dL/2rMfA5webXUd4+Y4PCLlNTvH7bCB97EVUmOFHd0/XEGnzw7NHpG6ppc19B+HZej eBsGjqwkkqRNrTyvaawJoFmRaOXtGVk3bCpcsqwYtRwXUyRC1UN7VaRsl7u4m+MzmBSU 6cD4x7HKarsmROakpmeqX8crH9p9yM5Lheg7U0e1kBkz4wFQBlAgb6JLgbkajrRWfqoF HYuGir0+qItlqUz/l3YGKAjgUdO3I6ASL7dalZgBAdwjIg32JBUKQ3SFp0AoAVVHdB5t XC98zKUAAHd5E3Hx/KYT3e22toiraTIhF2EXWXvL/t1wQL0SZd0A+yf9m/0yel69MpCM cVCQ== X-Gm-Message-State: ACgBeo199QMM3Wac4tqQ+DW9MPrnxzz690WzZp793hg5/7/HwHrxHk5t 62dWTNMN5VpfGrx1keyvlw== X-Google-Smtp-Source: AA6agR7sudikaulOJjDjKBhjit+p3YIiP/+/9fBG0IadZMnM/tMs/qmmt53+RNlMkYVlbg91XHE0aQ== X-Received: by 2002:a05:6870:a713:b0:127:70ba:aa86 with SMTP id g19-20020a056870a71300b0012770baaa86mr2184471oam.154.1663084278229; Tue, 13 Sep 2022 08:51:18 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x7-20020a4a8d47000000b004728e64dc0fsm5616486ook.38.2022.09.13.08.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 08:51:17 -0700 (PDT) Received: (nullmailer pid 3801723 invoked by uid 1000); Tue, 13 Sep 2022 15:51:16 -0000 Date: Tue, 13 Sep 2022 10:51:16 -0500 From: Rob Herring To: Vladimir Oltean Cc: Sean Wang , Paolo Abeni , Kurt Kanzenbach , DENG Qingfang , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , linux-kernel@vger.kernel.org, George McCollister , linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, "David S. Miller" , Florian Fainelli , Linus Walleij , Andrew Lunn , Woojung Huh , Eric Dumazet , Jakub Kicinski , UNGLinuxDriver@microchip.com, =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-mediatek@lists.infradead.org, Matthias Brugger , Rob Herring , Landen Chao , Vladimir Oltean , John Crispin , Vivien Didelot , Marek Vasut , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks Message-ID: <20220913155116.GA3801652-robh@kernel.org> References: <20220912175058.280386-1-vladimir.oltean@nxp.com> <20220912175058.280386-2-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220912175058.280386-2-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_085122_657940_5D123195 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Sep 2022 20:50:56 +0300, Vladimir Oltean wrote: > The fact that some DSA device trees use 'label = "cpu"' for the CPU port > is nothing but blind cargo cult copying. The 'label' property was never > part of the DSA DT bindings for anything except the user ports, where it > provided a hint as to what name the created netdevs should use. > > DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(), > but this is only for non-OF code paths (platform data). > > The proper way to identify a CPU port is to look at whether the > 'ethernet' phandle is present. > > Signed-off-by: Vladimir Oltean > --- > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel