From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B104C6FA86 for ; Wed, 14 Sep 2022 18:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s+26FAoBChNy6YxiLtAMUI2ZtOVYYnCN7YDrsC1gnIU=; b=Y/bLfW4lgNTHc/ y9wmt0ZLoOgjMde+IeoIVJtnMEPk7KvWUHEsxmWclCPaA6NjlqQkXr4Zoef72IjdAXFNIcvT9deT6 2Ll3L0Mit6lSJdtfGaHqDgBFqClxdtKdsu1vWSjIsXRSColErUEcISs4Yu43tqrACzwIB/rMZWV56 UWpG1HushE2r8sh17Yy1+9KV8eb/XSh8sP+2V0Y6xCLrfXrnDk9WnfhE4jGYtIgv4pGZOkWeHuH4o LC65g04AwT0Z+gkueaEbR7n8x714aYSL6ZE+aE2LJQweCUBfTKtPJxTAKlOITiff4iKiNlhWaGf5k Xkz/k8bDUoR90hwAAugA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYWuc-006liT-Gh; Wed, 14 Sep 2022 18:15:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYWuZ-006lhW-TO; Wed, 14 Sep 2022 18:15:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 75BDF61E53; Wed, 14 Sep 2022 18:14:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6FCCC433C1; Wed, 14 Sep 2022 18:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663179298; bh=YSZCfCgBas7sM38vNqjuLIpxrhdHOeh3iNoKuSZSNgQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=urqn2kULlBPEfMnbgZ253cO6nn/5Qh9LuC6Lcr4XqSnVkxp5LlrLMjWdMBtzclWE2 lVxyH9SClgzxpd73uTmD1BDxZVd9Yx8bgP6wNuKevZMEabNN/6hTl9/a+ffQoaysbg wLX/uJDhnoCu/XniMB0advt5wYr3AAFxWz6f6G/6tQ6/NzUmepf2ComI5equDKSwy+ qPescjzuN3MXPeivEFaHZopIhwR4++Tvs5xSwTcYAumlj+xH10EhT/DSwFCdHOUAS5 rXRxSTm5FE9nW1AYg3qtKJ2nqxtQCm26QlzSTraQt6QaXAjBct3ZXTzi1nP9ZWRYF3 kadx1bR66QF3Q== MIME-Version: 1.0 In-Reply-To: References: <20220815-rpi-fix-4k-60-v1-0-c52bd642f7c6@cerno.tech> <20220815-rpi-fix-4k-60-v1-2-c52bd642f7c6@cerno.tech> <20220914155035.88E45C433C1@smtp.kernel.org> <50e8f1e8-806a-3599-7cbe-0c7d4bec1c51@i2se.com> <20220914180508.0EDD9C433D6@smtp.kernel.org> Subject: Re: [PATCH v1 2/7] clk: bcm: rpi: Add a function to retrieve the maximum From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Dom Cobley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Broadcom internal kernel review list , Daniel Vetter , David Airlie , Emma Anholt , Florian Fainelli , Maxime Ripard , Maxime Ripard , Michael Turquette , Ray Jui , Scott Branden , Stefan Wahren Date: Wed, 14 Sep 2022 11:14:56 -0700 User-Agent: alot/0.10 Message-Id: <20220914181458.C6FCCC433C1@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_111500_002605_8FCB169D X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Stefan Wahren (2022-09-14 11:09:04) > Am 14.09.22 um 20:05 schrieb Stephen Boyd: > > Quoting Stefan Wahren (2022-09-14 10:45:48) > >> Am 14.09.22 um 17:50 schrieb Stephen Boyd: > >>> Furthermore, I wonder if even that part needs to be implemented. Why > >>> not make a direct call to rpi_firmware_property() and get the max rate? > >>> All of that can live in the drm driver. Making it a generic API that > >>> takes a 'struct clk' means that it looks like any clk can be passed, > >>> when that isn't true. It would be better to restrict it to the one use > >>> case so that the scope of the problem doesn't grow. I understand that it > >>> duplicates a few lines of code, but that looks like a fair tradeoff vs. > >>> exposing an API that can be used for other clks in the future. > >> it would be nice to keep all the Rpi specific stuff out of the DRM > >> driver, since there more users of it. > > Instead of 'all' did you mean 'any'? > yes Why? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel