Re: [PATCH v1 1/2] dt-bindings: power: Add MT8188 power domains

Bo-Chen Chen
2022-09-16T06:35:51Z

On Fri, 2022-09-16 at 13:52 +0800, Garmin.Chang wrote:
> Add power domains dt-bindings for MT8188.
>
> Signed-off-by: Garmin.Chang <Garmin.Chang@mediatek.com>
> Change-Id: I62dff8af2bd74d6148712bfaa1caafc0b49e4b0c

Hello Garmin,

please remove change-id.

BRs,
Bo-Chen

> ---
> .../power/mediatek,power-controller.yaml | 2 +
> .../dt-bindings/power/mediatek,mt8188-power.h | 44
> +++++++++++++++++++
> 2 files changed, 46 insertions(+)
> create mode 100644 include/dt-bindings/power/mediatek,mt8188-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> b/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> index 605ec7ab5f63..c9acef80f452 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-
> controller.yaml
> @@ -28,6 +28,7 @@ properties:
> - mediatek,mt8173-power-controller
> - mediatek,mt8183-power-controller
> - mediatek,mt8186-power-controller
> + - mediatek,mt8188-power-controller
> - mediatek,mt8192-power-controller
> - mediatek,mt8195-power-controller
>
> @@ -84,6 +85,7 @@ $defs:
> "include/dt-bindings/power/mt8167-power.h" - for
> MT8167 type power domain.
> "include/dt-bindings/power/mt8173-power.h" - for
> MT8173 type power domain.
> "include/dt-bindings/power/mt8183-power.h" - for
> MT8183 type power domain.
> + "include/dt-bindings/power/mediatek,mt8188-power.h" -
> for MT8188 type power domain.
> "include/dt-bindings/power/mt8192-power.h" - for
> MT8192 type power domain.
> "include/dt-bindings/power/mt8195-power.h" - for
> MT8195 type power domain.
> maxItems: 1
> diff --git a/include/dt-bindings/power/mediatek,mt8188-power.h
> b/include/dt-bindings/power/mediatek,mt8188-power.h
> new file mode 100644
> index 000000000000..57e75cf3aa2c
> --- /dev/null
> +++ b/include/dt-bindings/power/mediatek,mt8188-power.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +/*
> + * Copyright (c) 2022 MediaTek Inc.
> + * Author: Garmin Chang <garmin.chang@mediatek.com>
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_MT8188_POWER_H
> +#define _DT_BINDINGS_POWER_MT8188_POWER_H
> +
> +#define MT8188_POWER_DOMAIN_MFG0 0
> +#define MT8188_POWER_DOMAIN_MFG1 1
> +#define MT8188_POWER_DOMAIN_MFG2 2
> +#define MT8188_POWER_DOMAIN_MFG3 3
> +#define MT8188_POWER_DOMAIN_MFG4 4
> +#define MT8188_POWER_DOMAIN_PEXTP_MAC_P0 5
> +#define MT8188_POWER_DOMAIN_PEXTP_PHY_TOP 6
> +#define MT8188_POWER_DOMAIN_CSIRX_TOP 7
> +#define MT8188_POWER_DOMAIN_ETHER 8
> +#define MT8188_POWER_DOMAIN_HDMI_TX 9
> +#define MT8188_POWER_DOMAIN_ADSP_AO 10
> +#define MT8188_POWER_DOMAIN_ADSP_INFRA 11
> +#define MT8188_POWER_DOMAIN_ADSP 12
> +#define MT8188_POWER_DOMAIN_AUDIO 13
> +#define MT8188_POWER_DOMAIN_AUDIO_ASRC 14
> +#define MT8188_POWER_DOMAIN_VPPSYS0 15
> +#define MT8188_POWER_DOMAIN_VDOSYS0 16
> +#define MT8188_POWER_DOMAIN_VDOSYS1 17
> +#define MT8188_POWER_DOMAIN_DP_TX 18
> +#define MT8188_POWER_DOMAIN_EDP_TX 19
> +#define MT8188_POWER_DOMAIN_VPPSYS1 20
> +#define MT8188_POWER_DOMAIN_WPE 21
> +#define MT8188_POWER_DOMAIN_VDEC0 22
> +#define MT8188_POWER_DOMAIN_VDEC1 23
> +#define MT8188_POWER_DOMAIN_VENC 24
> +#define MT8188_POWER_DOMAIN_IMG_VCORE 25
> +#define MT8188_POWER_DOMAIN_IMG_MAIN 26
> +#define MT8188_POWER_DOMAIN_DIP 27
> +#define MT8188_POWER_DOMAIN_IPE 28
> +#define MT8188_POWER_DOMAIN_CAM_VCORE 29
> +#define MT8188_POWER_DOMAIN_CAM_MAIN 30
> +#define MT8188_POWER_DOMAIN_CAM_SUBA 31
> +#define MT8188_POWER_DOMAIN_CAM_SUBB 32
> +
> +#endif /* _DT_BINDINGS_POWER_MT8188_POWER_H */