From: Sudeep Holla <sudeep.holla@arm.com>
To: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
suzuki.poulose@arm.com, thomas.abraham@arm.com
Subject: Re: [PATCH] coresight: acpi: add support for amba dma-330 controller
Date: Fri, 16 Sep 2022 14:00:35 +0100 [thread overview]
Message-ID: <20220916130035.pbavnjlkh4envc4u@bogus> (raw)
In-Reply-To: <20220916111912.42733-1-vijayenthiran.subramaniam@arm.com>
On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote:
> Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
> probing of the device.
>
$subject pattern is simply wrong and I see this is just copied from the
previous commit which makes no sense here. You can see other commits
and their patterns too.
Use prefix something like:
ACPI / amba:
or
ACPI: amba:
Also "Add .." in the $subject sounds like you are adding the support for
the controller here which is not the case.
Enable support for Arm Primecell PL330 dma controller
Or
Add Arm Primecell PL330 dma controller to the supported list
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-16 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 11:19 [PATCH] coresight: acpi: add support for amba dma-330 controller Vijayenthiran Subramaniam
2022-09-16 11:40 ` Suzuki K Poulose
2022-09-16 12:59 ` Vijayenthiran Subramanian
2022-09-16 13:00 ` Sudeep Holla [this message]
2022-09-21 14:42 ` Vijayenthiran Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916130035.pbavnjlkh4envc4u@bogus \
--to=sudeep.holla@arm.com \
--cc=coresight@lists.linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=thomas.abraham@arm.com \
--cc=vijayenthiran.subramaniam@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox