From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6E1CECAAA1 for ; Fri, 16 Sep 2022 18:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GoVxU1UrcCYXZAT+coA+9SObc5b8lxLM7GAm/2UdSBA=; b=JkNZTQGed2N8Kx lEs7ZqQnZVW9OmlAVhRHhyjuyrLBwgOTHPt0gvEYPMgPWuKXUlEEJ5ZHOqkLx8pXCKdO/0Gu3a/LB vUmlc5Vr3xJqsUw19OHKDMl2J95GlEENZJwbLsO9b+W/36yk0Pqgm6YsYq/tjPEUrqTfZLqCqjs4G SIoVIQn1DAUnQYMJofIj36P3bagtoKtxDcMSXYTv+QDAx+t76gBETDqFdtwu9WWTgsBLzGGIrMM/P LS8v1+THhGxtpn+ACB/IXbF9HqN+6VrY2Y36ov71WIjZjLCbsNUIRSSlSqZYV7As0lVaSr+yuFEGE mkNDCy87izbuCQcwYt0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZGMb-00Fyif-4u; Fri, 16 Sep 2022 18:46:57 +0000 Received: from mail-oa1-f54.google.com ([209.85.160.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZGMQ-00Fyap-23 for linux-arm-kernel@lists.infradead.org; Fri, 16 Sep 2022 18:46:53 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1278a61bd57so53344475fac.7 for ; Fri, 16 Sep 2022 11:46:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=QUdpooO9e0LGNAHrNgijCx8KjhavOiFYv353gJdgjLg=; b=0d7u9JP/ByxpPfoI/3S3exHRfQH8yqm0r/oPX4Xrxt7leANxozc4UkGGZP+XKX1nNF aqaGjMQtArbcsi8PsHN7cg1s7UKYPI1TMuaSBTBKlHQh5gkb6EaZY+AB+RvS2kHAdRBz JNYT2hiMAAWImgkadhbmXtn8iBSucI98IB91yuYlHBRLy5qMaSAoeHKwfq4iYp+W3X9Y TYaCzqt8D11GjcHXCjJhQziyut4pyAOAc0Oql7l9UQ8Rb1FMpNNjdkacdbmYrkbtml9a LXLtKNFfOVl+WXG022SotlF8xM3OkPKCWutDLaLIGZb+xqkryA75JaV5PtAfiGZOpxB+ xUkA== X-Gm-Message-State: ACgBeo3jeT9Diwj02XJg1Zy+Nppxgyi8+L47Ueq6WC4TLUvkjvt4GK/1 I312xfAdh5wYljDtQNuNaQ== X-Google-Smtp-Source: AA6agR6KmphzttLac6xuaL6iI0nS11BIfzySChDgOV0I3cczYqIwZ94ESDSla3WlqkrWI/woZzMqcw== X-Received: by 2002:a05:6870:a710:b0:127:b0be:3d39 with SMTP id g16-20020a056870a71000b00127b0be3d39mr9253715oam.119.1663354001504; Fri, 16 Sep 2022 11:46:41 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j17-20020a056830271100b00638ac7ddb77sm10290804otu.10.2022.09.16.11.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 11:46:40 -0700 (PDT) Received: (nullmailer pid 1057721 invoked by uid 1000); Fri, 16 Sep 2022 18:46:40 -0000 Date: Fri, 16 Sep 2022 13:46:40 -0500 From: Rob Herring To: Serge Semin Cc: Krzysztof Kozlowski , Rob Herring , Serge Semin , linux-arm-kernel@lists.infradead.org, Dinh Nguyen , Manish Narani , linux-kernel@vger.kernel.org, Punnaiah Choudary Kalluri , Krzysztof Kozlowski , Borislav Petkov , Michail Ivanov , Tony Luck , James Morse , Alexey Malahov , Pavel Parkhomenko , linux-edac@vger.kernel.org, Krzysztof Kozlowski , Mauro Carvalho Chehab , Michal Simek , devicetree@vger.kernel.org, Robert Richter Subject: Re: [PATCH v2 15/19] dt-bindings: memory: snps: Use more descriptive device name Message-ID: <20220916184640.GA1057644-robh@kernel.org> References: <20220910194237.10142-1-Sergey.Semin@baikalelectronics.ru> <20220910194237.10142-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220910194237.10142-16-Sergey.Semin@baikalelectronics.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_114646_181430_1FDEB07F X-CRM114-Status: GOOD ( 21.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Sep 2022 22:42:33 +0300, Serge Semin wrote: > The DT-schema name and the corresponding generic compatible string look > inappropriate in the current DW uMCTL2 DDRC DT-bindings: > 1. DT-schema name contains undefined vendor-prefix. It's supposed to be > "snps", not "synopsys". > 2. DT-schema name has "ecc" suffix. That is a device property, and has > nothing to do with the controller actual name. > 3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC > doesn't identify the IP-core in subject. > 4. There is no much point in using the IP-core version in the device name > since it can be retrieved from the corresponding device CSR. Moreover the > DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the > current state. > > In order to fix all the inconsistencies described above we suggest to > rename the DT-schema to "snps,dw-umctl2-ddrc.yaml", deprecate the > compatible string "snps,ddrc-3.80a" and define a new generic device > name as "snps,dw-umctl2-ddrc". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - This is a new patch created on v2 by detaching the DT-schema renaming > from the previous patch in the series. (@Krzysztof) > - Fix the compatible string name so one would match the new DT-schema > name. > --- > .../{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} | 7 +++++-- > MAINTAINERS | 1 + > 2 files changed, 6 insertions(+), 2 deletions(-) > rename Documentation/devicetree/bindings/memory-controllers/{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} (83%) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel