From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8131FECAAA1 for ; Mon, 19 Sep 2022 17:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=B69u0KfFrQf+rH9BZ8LN9m/w6QTfGQVSDBH7ul+JWII=; b=zyu4ZWy+HNjL6z FvSQCgUEiGBRIJBuxEoFkKskyZrjs0PCDlcc8BdB/HMK+s4yaubsbixYr52Bu+ziAxYg0GdXItP2X Yg58eSIQitpEBtE78nhwEg8XANGa1Mx6pc8Q5TXGlQZk4t4eBLneLw71/21qkPTphXGOEL76JNh6i gE6AsMfch8KuatInXBX3Yz1/gyNV1ZAxnV+1lLwS3yhjoHvdZcwMcg2+nVt3KhnhTGg5I2BZUS8UY +jYPrmgq8Xf+5XRg/IMMYFGdUN0LZJGTqbzTOYmHb8m35CpFa8XBzNQ9kY9SluOF39Vpr8+fDcmal 4yb2egbDwGvgpiOGfnKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaKAm-00D6Rb-2g; Mon, 19 Sep 2022 17:03:08 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaKAc-00D6Mu-Vt for linux-arm-kernel@lists.infradead.org; Mon, 19 Sep 2022 17:03:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E419EB81DBC; Mon, 19 Sep 2022 17:02:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33278C433D6; Mon, 19 Sep 2022 17:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663606975; bh=X4h9HckllndXS+TNcSz6L4GDhtvtdBz4D8Y07rreB3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kEHd9cE/KYe6tru3Ista5AFLiDJ5X39rzR3J7TjYfPmCCROsgrWkPSwzquxzD5P/p XUsy59b/I6/KWxa000yEY9oC7baf3HYflwKSR2+fX91VoI0lyRDidwMghItFyRRiW0 U2vtNNQcRUNNjVL6nGD8a2v/T5xS0tTVmwzj2G/YcZva5sXPbFeBSpv/lp6O3fgWEf aDHa8pRSy7yMfM+10RVhB9/UBnPmVqdFlzEiMWfPnRkeIRmzglFlrwJ2cAGViFU6Uq Llc0f2Yy1wj6BSV5pdPnYTOYePBHF17bjLjWq2H/dOuWMFkP9aNDnwr0YlnBkU2+TA 9jw5Brdz3dUww== Date: Mon, 19 Sep 2022 12:02:53 -0500 From: Bjorn Helgaas To: Frank Li Cc: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev, lznuaa@gmail.com, imx@lists.linux.dev, manivannan.sadhasivam@linaro.org Subject: Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c Message-ID: <20220919170253.GA1011825@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220919154038.187168-6-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_100259_225686_1EAD7328 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In subject (I mentioned this last time, too): PCI: endpoint: pci-epf-vntb: Clean up On Mon, Sep 19, 2022 at 10:40:37AM -0500, Frank Li wrote: > Remove unused field: epf_db_phy. > Remove __iomem before epf_db. > Change epf_db to u32* from void * > Remove dupicate check if (readl(ntb->epf_db + i * 4)). s/dupicate/duplicate/ > Using sizeof(u32) instead of number 4 at all place. > > Clean up sparse build warning > Using epf_db[i] instead of readl() because epf_db is located in local memory > and allocated by dma_alloc_coherent() Is "Using epf_db[i] ..." an sparse warning? The indentation suggests that it is, but it doesn't seem related. > Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error handle path > to match pci_epf_alloc_space(). > > Cleanup warning found by scripts/kernel-doc > Fix indentation of the struct epf_ntb_ctrl > Consildate term s/Consildate/Consolidate/ > host, host1 to HOST > vhost, vHost, Vhost, VHOST2 to VHOST _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel