Re: [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce property

Francesco Dolcini
2022-09-21T12:29:43Z

On Wed, Sep 21, 2022 at 02:23:17PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 21, 2022 at 02:15:05PM +0200, Francesco Dolcini wrote:
> > +Greg, to get an opinion on the fixes tag.
> >
> > On Tue, Sep 20, 2022 at 11:22:27AM +0200, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > Remove spurious debounce property from linux,extcon-usb-gpio.
> > >
> > > Note that debouncing is hard-coded to 20 ms (USB_GPIO_DEBOUNCE_MS
> > > define).
> > >
> > > Fixes: 0ef1969ea569 ("ARM: dts: imx7-colibri: move aliases, chosen, extcon and gpio-keys")
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > Hello all,
> > we did have some (internal) discussion if this patch should have the
> > fixes tag or not.
> >
> > I do personally think it should not have it and should not be backported
> > to stable tree, since this is not fixing a real bug, it's just a
> > cleanup.
>
> If it's not a real bug, why would you have a Fixes: tag on the commit?
>
> > On the other hand the original patch was not correct, and this change is
> > making it right.
>
> Ah, so it is a bugfix.

The DTS file should not contain this unknown property, however having
this property present does not change the behavior of the code.

It's more like an unused variable kind of error that could trigger a
warning in the compiler.

Francesco