From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A375ECAAD8 for ; Wed, 21 Sep 2022 09:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8w3iWQBNEx5u2M+xTww/Dn8NESteZTwYUO9+4X+154A=; b=262FeBkdr+69euic/Jqdho9wTx yhWpK9GWxrbOVQxiarkDDyWcNFTp1E/zM2Rrbu0igvqrCU0JKPwyWg3lkaFnJxSUNAz3fRZYjfPo/ nFJAX2ecNo9Iv/e0Rc4U4qB+F5vNTkwETCr5lYtXMLEfhrkc9D64OIMFOfWo2PbbYF24mMT/F1PL0 ycVGgW3HlzbOeJRhPdnUjipg6MQB3PR6w8MTbM4wSMqpf//gtv5/6yf5MRONIi5jFjc5+AzTg1wU2 l63PmDrNjdMdnZj9NHwqTNZcOy18wWK3Aa52FT7gQoIHDb/favByG/DbJLvvTuAFW3AaOFQIEpqMR 29SfRLrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaw0H-00AOHh-1O; Wed, 21 Sep 2022 09:26:49 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oavrh-00AJv0-H6; Wed, 21 Sep 2022 09:17:59 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id E8F0E5817D8; Wed, 21 Sep 2022 05:17:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 21 Sep 2022 05:17:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1663751872; x=1663759072; bh=mDRCW58754 cJxsMgzdDDTe0R8uGcv3CYi1zG8IpvdW8=; b=J6Y9pJauLu6Ni+2JRRbpeLEBUG KCrjiOg7u5/nvy1tfBlBXdLThLcQbw010xly84RHJAb8MsrKt6tsecxAmo5to0x0 LbNwbcDe9+VBoU8ShH4QCV9mbjvGzxpUL4fxW23ftAON3xmHQRwh/7E1hiwqU+TZ LEMwHQzZhrfEOx+5NAlROYE7STj7HwTvu206sxNPd/4q0gIoHsfhbCyCWCQBKhbm YcEY+OPRIt4bZH57edAs6Ve3AivmSw/oqWmSwe4HRo35urF4KD0CqT2xnuCcAV/E aWybGKcvUi1uMvApEht/6nlow+STqVbQxfwLDFryEqlJ+gnb+ELjHUkDZV2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663751872; x=1663759072; bh=mDRCW58754cJxsMgzdDDTe0R8uGc v3CYi1zG8IpvdW8=; b=eEIceKVPN0B77cF3oztkJIgtT3vMZEE4z/ja3I1oTJcz hlzSZ7fY7QqXvFXfIJGuenjd3/HV1nQ1wpc/BpWFfz1QGQsCJ82q3zBsqUoO/wM8 doOPVQPFilJjiRElC7bO0wlFRu0s/EyPL0mdxaYdbbPMAqaZDFwbyGEXSZQkYgk7 oDw3hbrOMrAJzcUgbwsdSBLiNt2B5vn5a/FU8JoTaxzsazKGhrfnhOyKUXo1S2b3 ipqAu9ube0T8iCDLQUocA+LkbndEh3NUc1kk3UmXTzMxqGScqND8Xp170pqp0xt1 PTTx13K7c2QODzbAG9OmOybBOZnD3tv/7TdApBY2Bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefuddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 05:17:51 -0400 (EDT) Date: Wed, 21 Sep 2022 11:17:48 +0200 From: Maxime Ripard To: Stefan Wahren Cc: Daniel Vetter , Florian Fainelli , David Airlie , Broadcom internal kernel review list , Michael Turquette , Scott Branden , Stephen Boyd , Emma Anholt , Ray Jui , linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dom Cobley , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header Message-ID: <20220921091748.u6qcba6nwclvezzg@houat> References: <20220815-rpi-fix-4k-60-v2-0-983276b83f62@cerno.tech> <20220815-rpi-fix-4k-60-v2-2-983276b83f62@cerno.tech> <688777fc-e6af-8cbe-b19d-c531a7a66b32@i2se.com> MIME-Version: 1.0 In-Reply-To: <688777fc-e6af-8cbe-b19d-c531a7a66b32@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_021758_065447_E48BFC02 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8838124677542929649==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8838124677542929649== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="itnh57rcj5wjjcou" Content-Disposition: inline --itnh57rcj5wjjcou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 20, 2022 at 06:01:08PM +0200, Stefan Wahren wrote: > Am 20.09.22 um 14:50 schrieb Maxime Ripard: > > We'll need the clock IDs in more drivers than just the clock driver from > > now on, so let's move them in the firmware header. >=20 > recently as i reviewed the clk-raspberrypi i noticed this, too. But from = my > point of view the clock ids should go to include/dt-bindings/clock (like > bcm2835.h) because these clock ids are actually referenced in the DTS fil= es > and we need to make sure they are in sync. AFAIR this would also result in > change from enum to defines. >=20 > Sorry, i didn't had the time to send a patch for this. IMO, we need both, and this enum still belongs in the firmware header. We have two separate things, the firmware interface and the DT interface. The kernel is a consumer for both, but the fact that they match is an implementation detail. It might even change in the future for all we know. So having a header to use defines for the clock indices in the DT looks like a good idea to me, but I think we should keep that enum in the firmware header as well. Maxime --itnh57rcj5wjjcou Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYyrWvAAKCRDj7w1vZxhR xQb6AP9gsTEDLx4N2ddX7AdtvgY6eQfDUqVGB8S6WhNsSuhe/gD7B0sPmldeC8DV XTcG9b2xt1s+i4ha7GqV2l+eQU2chAQ= =Um8H -----END PGP SIGNATURE----- --itnh57rcj5wjjcou-- --===============8838124677542929649== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8838124677542929649==--