From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Marcel Ziswiler <marcel@ziswiler.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce property
Date: Wed, 21 Sep 2022 14:15:05 +0200 [thread overview]
Message-ID: <20220921121505.GA41442@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20220920092227.286306-5-marcel@ziswiler.com>
+Greg, to get an opinion on the fixes tag.
On Tue, Sep 20, 2022 at 11:22:27AM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Remove spurious debounce property from linux,extcon-usb-gpio.
>
> Note that debouncing is hard-coded to 20 ms (USB_GPIO_DEBOUNCE_MS
> define).
>
> Fixes: 0ef1969ea569 ("ARM: dts: imx7-colibri: move aliases, chosen, extcon and gpio-keys")
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Hello all,
we did have some (internal) discussion if this patch should have the
fixes tag or not.
I do personally think it should not have it and should not be backported
to stable tree, since this is not fixing a real bug, it's just a
cleanup.
On the other hand the original patch was not correct, and this change is
making it right.
What is the general opinion on this topic? What do the stable kernel
maintainers would expect?
Documentation/process/stable-kernel-rules.rst is about rules for
backporting, it does not really talk about the fixes tag, but today this
is used to decide if a patch should be backported or not.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-21 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 9:22 [PATCH v1 0/4] arm: dts: colibri-imx6: usb dual-role switching et. al Marcel Ziswiler
2022-09-20 9:22 ` [PATCH v1 1/4] arm: dts: colibri-imx6: usb dual-role switching Marcel Ziswiler
2022-09-20 9:22 ` [PATCH v1 2/4] arm: dts: colibri-imx6: move vbus-supply to module level device tree Marcel Ziswiler
2022-09-20 9:22 ` [PATCH v1 3/4] arm: dts: colibri-imx6: specify usbh_pen gpio being active-low Marcel Ziswiler
2022-09-20 9:22 ` [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce property Marcel Ziswiler
2022-09-21 12:15 ` Francesco Dolcini [this message]
2022-09-21 12:23 ` Greg Kroah-Hartman
2022-09-21 12:28 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921121505.GA41442@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox