From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10302C6FA82 for ; Wed, 21 Sep 2022 14:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mStI45AxHq/rkKcUSbvBhPs3sScycRphVpQUjRZReKE=; b=N4YUbaNZ5squh/ f5pij+ndXizkaE7MZPu3PqXt6nQYb+VSijZ+3a+3vHu7KzNpCV1cV8I8Y+8ITi+XS5IOSbyPrN5s/ 8mM9owmJFJWnZ1fEOTS5Ezy1aDH60TiWSod+3FE04fHO6CSBUnAel/qlRWLZ7IXLNEK0tz5XVX6Wg xoh6r2uIh6a8vpNfivVTxJp+lVPoFZd/aB+2bxg4hgPkOKi8O6uUhKmTKfJVRP3tAMTRSdYX1cZSb iaC0QRsVipxGGUNxP9fqPecQvAckXkvKEDhoHgyZKcvLftmJYoIM577xzosFh/9wGoSQPTbFGNYxT 5g91UIlPsPgeTgruWoLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ob0q7-00Bc6j-9Q; Wed, 21 Sep 2022 14:36:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ob0pz-00Bc4o-E3 for linux-arm-kernel@lists.infradead.org; Wed, 21 Sep 2022 14:36:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7AA113D5; Wed, 21 Sep 2022 07:36:34 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 118D33F73B; Wed, 21 Sep 2022 07:36:26 -0700 (PDT) Date: Wed, 21 Sep 2022 15:36:24 +0100 From: Sudeep Holla To: Dmitry Baryshkov Cc: Mark Rutland , Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] firmware/psci: Print a warning if PSCI doesn't accept PC mode Message-ID: <20220921143624.eulpt56r4cn4vcrx@bogus> References: <20220804130750.3706897-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_073631_566038_9EE71938 X-CRM114-Status: GOOD ( 24.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 19, 2022 at 02:58:57PM +0300, Dmitry Baryshkov wrote: > On 05/08/2022 17:19, Mark Rutland wrote: > > On Thu, Aug 04, 2022 at 04:07:50PM +0300, Dmitry Baryshkov wrote: > > > The function psci_pd_try_set_osi_mode() will print an error if enabling > > > OSI mode fails. To ease debugging PSCI issues print corresponding > > > message if switching to PC mode fails too. > > > > > > Signed-off-by: Dmitry Baryshkov > > > > Acked-by: Mark Rutland > > > > Mark. > > Granted that this patch has been acked by the maintainers of PSCI interface, > how do I proceed? Should I submit it to Russel's patch tracker? Or do PSCI > patches land via some other tree? > Not sure if I mentioned it elsewhere or in v1, we generally ask Arm SoC team to pick up patches directly as they are always 1-2 and rarely large set. You need to cc soc@kernel.org for the same. > > > > > --- > > > This is a replacement for [1], now moving the warning from > > > psci_set_osi_mode() callers to the function iself. > > > > > > https://lore.kernel.org/all/20220727182034.983727-1-dmitry.baryshkov@linaro.org/ > > > > > > --- > > > drivers/cpuidle/cpuidle-psci-domain.c | 4 +--- > > > drivers/firmware/psci/psci.c | 2 ++ > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > > index 3db4fca1172b..821984947ed9 100644 > > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > > @@ -124,10 +124,8 @@ static bool psci_pd_try_set_osi_mode(void) > > > return false; > > > ret = psci_set_osi_mode(true); > > > - if (ret) { > > > - pr_warn("failed to enable OSI mode: %d\n", ret); > > > + if (ret) > > > return false; > > > - } > > > return true; > > > } > > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > > > index cfb448eabdaa..1628f1edef4a 100644 > > > --- a/drivers/firmware/psci/psci.c > > > +++ b/drivers/firmware/psci/psci.c > > > @@ -163,6 +163,8 @@ int psci_set_osi_mode(bool enable) > > > PSCI_1_0_SUSPEND_MODE_PC; > > > err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); > > > + if (err < 0) > > > + pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); > > > return psci_to_linux_errno(err); > > > } > > > -- > > > 2.35.1 > > > > > -- > With best wishes > Dmitry > -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel