From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF881C54EE9 for ; Thu, 22 Sep 2022 11:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mjy57BrIkdH+JGt1sguNjw6XAEHvMTfzB5faMQgzaxE=; b=o6joaeNUX6zOqy MT1pSakuZTq9PWYW4pmeikGXG7XtlAGscJnMfV9HMeqx+3ZBDxRRHZ4EnI01ZSOuey4L6ghW+pUgZ Bs0L0XbQgpWO1VV5/vjij/PJczj5qi++G3XjOJHQCH3+4/A6sUf7+cWyB6ATJhp6sumFaDJ/nm2RA xGJZT2c8YfoMsRe+cifB5TyFLFlYKyjcrKAtA9bWAPUz1rSHzYYuojaZziGeZPjVNqaQ3BFUFgyiD qtO+CXrEtQ4WwENcdn02dL1yHY/fNGxWxE9DJCx/CTMcN0G3nWIfSNE33IIQz44MhSSpz0PQn9bWE esjxHRUPvf4b1TezPzkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obK08-00F4GM-84; Thu, 22 Sep 2022 11:04:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obK04-00F4FQ-Mg for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 11:04:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EDD85ED1; Thu, 22 Sep 2022 04:04:16 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 148303F73B; Thu, 22 Sep 2022 04:04:08 -0700 (PDT) Date: Thu, 22 Sep 2022 12:04:06 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Dien Pham , Gaku Inami , Cristian Marussi , linux-arm-kernel@lists.infradead.org, Peng Fan , Geert Uytterhoeven , Nicolas Pitre , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "firmware: arm_scmi: Add clock management to the SCMI power domain" Message-ID: <20220922110406.cuovmxtw2jkn4f4h@bogus> References: <20220919122033.86126-1-ulf.hansson@linaro.org> <20220921155634.owr5lncydsfpo7ua@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_040412_808038_2D2BF327 X-CRM114-Status: GOOD ( 26.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 21, 2022 at 08:46:21PM +0200, Ulf Hansson wrote: > On Wed, 21 Sept 2022 at 17:56, Sudeep Holla wrote: > > > > Hi Dien, Gaku, > > > > On Mon, Sep 19, 2022 at 02:20:33PM +0200, Ulf Hansson wrote: > > > This reverts commit a3b884cef873 ("firmware: arm_scmi: Add clock management > > > to the SCMI power domain"). > > > > > > Using the GENPD_FLAG_PM_CLK tells genpd to gate/ungate the consumer > > > device's clock(s) during runtime suspend/resume through the PM clock API. > > > More precisely, in genpd_runtime_resume() the clock(s) for the consumer > > > device would become ungated prior to the driver-level ->runtime_resume() > > > callbacks gets invoked. > > > > > > This behaviour isn't a good fit for all platforms/drivers. For example, a > > > driver may need to make some preparations of its device in its > > > ->runtime_resume() callback, like calling clk_set_rate() before the > > > clock(s) should be ungated. In these cases, it's easier to let the clock(s) > > > to be managed solely by the driver, rather than at the PM domain level. > > > > > > For these reasons, let's drop the use GENPD_FLAG_PM_CLK for the SCMI PM > > > domain, as to enable it to be more easily adopted across ARM platforms. > > > > > > Fixes: a3b884cef873 ("firmware: arm_scmi: Add clock management to the SCMI power domain") > > > Cc: Nicolas Pitre > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Ulf Hansson > > > --- > > > > > > To get some more background to $subject patch, please have a look at the > > > lore-link below. > > > > > > https://lore.kernel.org/all/DU0PR04MB94173B45A2CFEE3BF1BD313A88409@DU0PR04MB9417.eurprd04.prod.outlook.com/ > > > > > > > If you have any objections, this is your last chance to speak up before > > the original change gets reverted in the mainline with this patch. > > > > Hi Ulf, > > > > I don't have any other SCMI changes for v6.0 fixes or v6.1 > > I am fine if you are happy to take this via your tree or I can send it > > to SoC team. Let me know. I will give final one or 2 days for Renesas > > to get back if they really care much. > > I have a slew of fixes for mmc that I intend to send next week, I can > funnel them through that pull request. > > Assuming, Renesas folkz are okay, I consider that as an ack from you, right? > Yes for official reasons, here is the formal :) Acked-by: Sudeep Holla in case you manage to get this in via your tree. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel