From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51454ECAAD8 for ; Fri, 23 Sep 2022 14:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3w52m9lygdrWRZiosVb9v8AIrfRzgS6GgnGkVWMXYYQ=; b=XD0QtzsMBjqHXS 9uqobJj1VOkpuJdZnqExtOdvolWPg7+abJnLPZOFoBRX5i162H4lTTYkH/FLP1OpTh3DpgROOSa5j 2Y5uBvbCbEw1NTzAkkmnT4+er5VzlABkJo7YFhkn57aX2Gbq6eZMo2ke203+WTimSwE/dUsOlLPFp cx986AhVCyktcNlCmr92h+CMd8F8UYUl+8iYt9iyizKV2FonnCI1J3+qogM/XJsB983g6NU8FnNJy GEWctFypwoY7L0dfICQYur+QsT5Z9Sq8MXZ/KRCyjoqV1+iQLoJZtNhPw6HM9TKMyz/K46+O0wDMB 707mhUZByuMK88EEqqOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1objSs-004bWs-7e; Fri, 23 Sep 2022 14:15:39 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1objSl-004bVT-6J for linux-arm-kernel@lists.infradead.org; Fri, 23 Sep 2022 14:15:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 760ABB83646; Fri, 23 Sep 2022 14:15:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1778C433D6; Fri, 23 Sep 2022 14:15:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663942528; bh=1AEcv2sMJqybL3a/melDfwWejdXEdqsvn6UZFqQXk0w=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=KO/FydUZ6XN6vBhLT7QRnwB5Xe/lkshw7359t/XGWUVY3nZ6Brhtd/b4mj51hk5Ya teE0g2+L/r9SpFkcVnl9ISTxozo4Ew6R6BpfAd9LsOETTzQj/jZQKis2PH3fMjV266 QcJwIELCFD9UNnWUnlmMUWV7qNNk97IsP7CHEwppi2meC3pMzKQwOUx6KKV0IjcnOl dms4TAusM5nqHJk8tPVe03Z0yfOUZMocomBgW1lNMyAT6jKUmzMsFKapsS4AXPKBmk 86g55mvkOHVPvxjNW79d8LFrtmT0T6fVf9Kq8y4BbVvr1sryoDbx43j8LXgutChbIB We6XJ/zOy1iBw== Date: Fri, 23 Sep 2022 09:15:26 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, lorenzo.pieralisi@arm.com, shawnguo@kernel.org, kishon@ti.com, kw@linux.com, frank.li@nxp.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v3 04/14] PCI: dwc: Kconfig: Add iMX PCIe EP mode support Message-ID: <20220923141526.GA1388290@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1663913220-9523-5-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_071531_550706_C46F6C44 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 23, 2022 at 02:06:50PM +0800, Richard Zhu wrote: > Since i.MX PCIe is one dual mode PCIe controller. This is not a sentence. > Add i.MX PCIe EP mode support, and split the PCIe modes to the Root > Complex mode and Endpoint mode. Add blank lines between paragraphs or rewrap into a single paragraph that fills 75 columns. I think you should split "[12/14] PCI: imx6: Add iMX8MM PCIe EP mode" into: - A patch that adds the generic endpoint infrastructure, e.g., imx6_pcie_ep_init(), imx6_pcie_ep_raise_irq(), imx6_add_pcie_ep(). - A second patch that adds the i.MX8MM identifiers. That way the i.MX8MM patch will be analogous to the i.MX8MQ and i.MX8MP patches. Then you could squash this Kconfig patch into the generic endpoint infrastructure patch because this patch is what selects PCIE_DW_EP, which is what ensures that dw_pcie_ep_reset_bar(), dw_pcie_ep_raise_legacy_irq(), etc., are available. > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -92,10 +92,33 @@ config PCI_EXYNOS > functions to implement the driver. > > config PCI_IMX6 > - bool "Freescale i.MX6/7/8 PCIe controller" > + bool > + > +config PCI_IMX6_HOST > + bool "Freescale i.MX6/7/8 PCIe controller host mode" > depends on ARCH_MXC || COMPILE_TEST > depends on PCI_MSI_IRQ_DOMAIN > select PCIE_DW_HOST > + select PCI_IMX6 > + help > + Enables support for the PCIe controller Root Complex mode in the > + iMX6/7/8 SoCs. > + This controller can work either as EP or RC. In order to enable > + host-specific features PCIE_DW_HOST must be selected and in order > + to enable device-specific features PCIE_DW_EP must be selected. I don't think these three lines are useful to the user. They only describe what Kconfig does when PCI_IMX6_HOST is enabled, which is really an internal implementation detail. > +config PCI_IMX6_EP > + bool "Freescale i.MX6/7/8 PCIe controller endpoint mode" > + depends on ARCH_MXC || COMPILE_TEST > + depends on PCI_ENDPOINT > + select PCIE_DW_EP > + select PCI_IMX6 > + help > + Enables support for the PCIe controller endpoint mode in the > + iMX6/7/8 SoCs. > + This controller can work either as EP or RC. In order to enable > + host-specific features PCIE_DW_HOST must be selected and in order > + to enable device-specific features PCIE_DW_EP must be selected. Ditto. > config PCIE_SPEAR13XX > bool "STMicroelectronics SPEAr PCIe controller" > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel