From: "Pali Rohár" <pali@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: maukka@ext.kapsi.fi, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net,
sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com,
linux@armlinux.org.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on Device Tree
Date: Fri, 23 Sep 2022 20:02:26 +0200 [thread overview]
Message-ID: <20220923180226.vmjcefxlujg2r6u3@pali> (raw)
In-Reply-To: <Yy2iqE8XgXe8qYd9@lunn.ch>
On Friday 23 September 2022 14:12:24 Andrew Lunn wrote:
> > > > + if (of_machine_is_compatible("dlink,dns323a1")) {
> > > > + writel(0, MPP_DEV_CTRL); /* DEV_D[31:16] */
> > >
> > > I spotted this in dns323-setup.c as well. Do you have any idea what it
> > > does?
> > >
> >
> > No idea. I have tried to replicate what was in dns323-setup.c as exactly as
> > possible.
> > I can try to leave it out and see if anything changes.
>
> It is best to keep what we don't understand. It will be there for a
> reason.
>
> Andrew
Hello! I tried to index all publicly available Marvell SoC
documentations into kernel documentation subfolder:
https://docs.kernel.org/arm/marvell.html
For Orion there is linked Datasheet and User Manual, so you could try to
find in those documents that mentioned register and check what it is
doing.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-23 18:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 16:21 [RFC RFT PATCH v1 0/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree Mauri Sandberg
2022-04-27 16:21 ` [RFC RFT PATCH v1 1/1] " Mauri Sandberg
2022-04-27 18:12 ` Arnd Bergmann
2022-04-28 20:06 ` Mauri Sandberg
2022-04-28 20:47 ` Arnd Bergmann
2022-04-28 7:13 ` Krzysztof Kozlowski
2022-04-28 20:09 ` Mauri Sandberg
2022-04-27 18:10 ` [RFC RFT PATCH v1 0/1] " Arnd Bergmann
2022-04-28 0:18 ` Andrew Lunn
2022-04-28 20:25 ` Mauri Sandberg
2022-04-28 23:26 ` Andrew Lunn
2022-05-03 8:20 ` Mauri Sandberg
2022-04-28 20:01 ` Mauri Sandberg
2022-04-28 20:56 ` Arnd Bergmann
2022-05-08 14:06 ` Mauri Sandberg
2022-05-08 15:02 ` Arnd Bergmann
2022-05-08 15:22 ` Pali Rohár
2022-05-08 15:41 ` Pali Rohár
2022-05-09 7:21 ` Arnd Bergmann
2022-05-09 10:48 ` Mauri Sandberg
2022-05-09 11:03 ` Pali Rohár
2022-05-08 19:34 ` Mauri Sandberg
2022-05-08 20:10 ` Pali Rohár
2022-05-09 10:52 ` Mauri Sandberg
2022-04-28 0:29 ` Andrew Lunn
2022-09-22 20:24 ` [PATCH v2 0/3] ARM: orion5x: add D-Link DNS323 based on device treee Mauri Sandberg
2022-09-22 20:24 ` [PATCH v2 1/3] dt-bindings: arm: add DT binding for D-Link DNS-323 Mauri Sandberg
2022-09-22 20:36 ` Andrew Lunn
2022-09-23 9:18 ` Krzysztof Kozlowski
2022-09-22 20:24 ` [PATCH v2 2/3] ARM: dts: orion5x: Add D-Link DNS-323 Device Tree Mauri Sandberg
2022-09-22 20:45 ` Andrew Lunn
2022-09-22 21:14 ` Pali Rohár
2022-09-22 21:32 ` Andrew Lunn
2022-09-23 9:19 ` Krzysztof Kozlowski
2022-09-22 20:24 ` [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on " Mauri Sandberg
2022-09-22 21:10 ` Andrew Lunn
2022-09-23 9:03 ` maukka
2022-09-23 12:12 ` Andrew Lunn
2022-09-23 18:02 ` Pali Rohár [this message]
2022-09-26 11:56 ` maukka
2022-09-22 21:39 ` Arnd Bergmann
2022-09-23 9:13 ` maukka
2022-09-23 9:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923180226.vmjcefxlujg2r6u3@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maukka@ext.kapsi.fi \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).