From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6483AC07E9D for ; Sat, 24 Sep 2022 02:55:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HtejAjXpVZBmGLYnjlPs4Is1cw/oe7MPfwy/zDujwL0=; b=u3hp4m+ly6eGrj yQusWdL63rqkG491UBaPXnl2+Y7ElvAVE1FlE5p97Yj3E1vzdEj+UWfghntzZQfgNLPq/U55yzR+J avnovRmCxvRbFMKmFV5IEtVSXOZfeOPIHATpEw+7gc4FrdOjVRum8+N6tivI8qMPO7xltnGfUflZ8 sSEXTZYcbrXrudPA+pgtlk+GhGUeRzlo/Ku5ibUTHSZnePwkZ3WuEL4Obsb7GBZXmKnVxbzk4iVfG s776QEM1yzDK+MZVilYOtTyh6mzqjcMCfm9rQBQPbMPU2xDpvI4RuHmUvAeza0rvEi3NSAOPKAtSX 4mU6hr00fQg5Xs6j1ogQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obvJ9-006Clm-1Y; Sat, 24 Sep 2022 02:54:23 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obvJ6-006Cjh-BP for linux-arm-kernel@lists.infradead.org; Sat, 24 Sep 2022 02:54:21 +0000 Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MZD7n4qLlzHpW8; Sat, 24 Sep 2022 10:52:05 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 24 Sep 2022 10:54:17 +0800 From: Yuan Can To: , , CC: Subject: [PATCH] firmware: arm_scmi: Use dev_err_probe() to simplify code Date: Sat, 24 Sep 2022 02:51:46 +0000 Message-ID: <20220924025146.34976-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220923_195420_611542_1ABD6F8A X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can --- drivers/firmware/arm_scmi/mailbox.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c index 08ff4d110beb..85b84be85458 100644 --- a/drivers/firmware/arm_scmi/mailbox.c +++ b/drivers/firmware/arm_scmi/mailbox.c @@ -94,13 +94,10 @@ static int mailbox_chan_setup(struct scmi_chan_info *cinfo, struct device *dev, cl->knows_txdone = tx; smbox->chan = mbox_request_channel(cl, tx ? 0 : 1); - if (IS_ERR(smbox->chan)) { - ret = PTR_ERR(smbox->chan); - if (ret != -EPROBE_DEFER) - dev_err(cdev, "failed to request SCMI %s mailbox\n", - tx ? "Tx" : "Rx"); - return ret; - } + if (IS_ERR(smbox->chan)) + return dev_err_probe(cdev, PTR_ERR(smbox->chan), + "failed to request SCMI %s mailbox\n", + tx ? "Tx" : "Rx"); cinfo->transport_info = smbox; smbox->cinfo = cinfo; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel