From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C176C04A95 for ; Sun, 25 Sep 2022 17:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4YSqq0QgRK8HhTvlmn71b3PVk9msE2fdZMZgULcrvG0=; b=l4XzvwWzjY8CM8 O5ReRWK/q27ZKB+leePliv/Qr54Jyuwm0ggzTm1FIwt4LbyVVAngIM66oDuBIqXC4QRr2Rqn9CraC oEIvbiazTyMsWmYqxmTnGQ3ScgeERUfqb/nFWggmPkrDjD5bgCeZpaTXAfiAzLsyHD36JIL4JkmHB pcKABfDfAoZ3/k8Yin9TsHKwodLDCcGHgRcKQaQmr9cwrKbrZ0ExZ2ADlD/5HZveLt2wUrmVelfMc qgEMXuA5VAGkSHq5UrOdqTog0hW1XHVAObAcFF4O65tumFHLWrwNh09tor3JJkgRRse/NL9fitx5E 7oHlj1shboI2APzL6keg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVZP-00FKRu-Bd; Sun, 25 Sep 2022 17:37:35 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVZM-00FKQQ-TM for linux-arm-kernel@lists.infradead.org; Sun, 25 Sep 2022 17:37:34 +0000 Received: by mail-pf1-x432.google.com with SMTP id a29so4638973pfk.5 for ; Sun, 25 Sep 2022 10:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=LvcwNzv4Ih0dEIU3Z97vDHQe8FGkDkmzBOXb4/gsOks=; b=A8VWtO/SDapcveMPwicIvNuGIjgyYLmS26k+6AERfB0Qw9s7ODw4kg6iJfsDL2zhUf 8uh4f5fOiql206lN2OXR2w33iihuI9OagShXpwnOkDFIey0GULWX/mOYpW0WKhUqMzGW PTZb5US8kgZC9OicPnBTjiKni5oFChWytxXQQX4g69GKRi9wFGyplc1M5S8FVkAgq+Rw Pkja+4upBTH7VnBRAa9l3yMlzx3vYU3GNR0Hib5DA0FzOdAfKWbRP+Qf42dRp1GDA6nY ujgWBplA93Zf2It3TYRgeGzcBQwSt3X8OnO8gPcZYv+a7uyROtmM7W1tBnnRyPwcJHPq AGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=LvcwNzv4Ih0dEIU3Z97vDHQe8FGkDkmzBOXb4/gsOks=; b=U2WovYWW6BGrUGMXu8GqYgPfJKa1CEBpqd2sAU6dm4gvejtCG0JPSnI/iclPcQgW9u +AJYN5YZHHBMeGrpp/1ncXg5ckD+YZWa9jrpJ97n2a1HNdgwvwl+3FIMVlMatzaBdUjz xBFTTWMnVBemzct3F/n+QZKsWgsoRPfGZccGfATbptNsvnP2onKcYHw4q0ixp16dUpUO 6k6+HF6ZgzYICygvivAVxWzsxS/evy/3/MfShqbUr5H7acdqpHY8z8vbQBDRv0bDH9iw +on/78VKHRBqGxTT7gCVPiAOzxqz19ILbF5CbKrzbD74OmdE24Nt8LEUeDlPS8aL1Vwy WRvQ== X-Gm-Message-State: ACrzQf3Mh+bJ1tRpQTnhp1nxytjGvc3r/IZuj5+13UPhlBcVL8UrpjmK gOgtGmaU9IjPm1IgsA+FdcE= X-Google-Smtp-Source: AMsMyM5ukmC+J/nWhj8tLSkU8PdtCBITUCyL6PKTXo1KQOrY+LELb8G+1SnL0RrOzpEqiVb5xY/vWw== X-Received: by 2002:a63:6685:0:b0:43a:107:d45a with SMTP id a127-20020a636685000000b0043a0107d45amr16267002pgc.49.1664127451353; Sun, 25 Sep 2022 10:37:31 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k2-20020a634b42000000b0043bed49f31fsm8444720pgl.8.2022.09.25.10.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 10:37:30 -0700 (PDT) Date: Sun, 25 Sep 2022 10:37:29 -0700 From: Guenter Roeck To: "Alice Guo (OSS)" Cc: m.felsch@pengutronix.de, wim@linux-watchdog.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] watchdog: imx7ulp: Move suspend/resume to noirq phase Message-ID: <20220925173729.GA1763764@roeck-us.net> References: <20220825083256.14565-1-alice.guo@oss.nxp.com> <20220825083256.14565-2-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220825083256.14565-2-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_103732_973711_49BA7C0F X-CRM114-Status: GOOD ( 19.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 04:32:50PM +0800, Alice Guo (OSS) wrote: > From: Anson Huang > > The i.MX7ULP's watchdog is enabled by default when out of reset, so the > resume callback which is to disable watchdog should be called earlier > to avoid unexpected timeout, move suspend/resume callback to noirq phase. > > Signed-off-by: Anson Huang > Signed-off-by: Alice Guo > Reviewed-by: Jacky Bai > Tested-by: Peter Chen > Tested-by: Li Jun Reviewed-by: Guenter Roeck > --- > > Changes for v2: > - none > > drivers/watchdog/imx7ulp_wdt.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c > index 922b60374295..014f497ea0dc 100644 > --- a/drivers/watchdog/imx7ulp_wdt.c > +++ b/drivers/watchdog/imx7ulp_wdt.c > @@ -255,7 +255,7 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev) > return devm_watchdog_register_device(dev, wdog); > } > > -static int __maybe_unused imx7ulp_wdt_suspend(struct device *dev) > +static int __maybe_unused imx7ulp_wdt_suspend_noirq(struct device *dev) > { > struct imx7ulp_wdt_device *imx7ulp_wdt = dev_get_drvdata(dev); > > @@ -267,7 +267,7 @@ static int __maybe_unused imx7ulp_wdt_suspend(struct device *dev) > return 0; > } > > -static int __maybe_unused imx7ulp_wdt_resume(struct device *dev) > +static int __maybe_unused imx7ulp_wdt_resume_noirq(struct device *dev) > { > struct imx7ulp_wdt_device *imx7ulp_wdt = dev_get_drvdata(dev); > u32 timeout = imx7ulp_wdt->wdd.timeout * WDOG_CLOCK_RATE; > @@ -286,8 +286,10 @@ static int __maybe_unused imx7ulp_wdt_resume(struct device *dev) > return 0; > } > > -static SIMPLE_DEV_PM_OPS(imx7ulp_wdt_pm_ops, imx7ulp_wdt_suspend, > - imx7ulp_wdt_resume); > +static const struct dev_pm_ops imx7ulp_wdt_pm_ops = { > + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx7ulp_wdt_suspend_noirq, > + imx7ulp_wdt_resume_noirq) > +}; > > static const struct of_device_id imx7ulp_wdt_dt_ids[] = { > { .compatible = "fsl,imx7ulp-wdt", }, > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel