From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BC00C54EE9 for ; Sun, 25 Sep 2022 17:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uZgW4g+G8y3HSzHIbGz+coBY3oAvi7K1zV6g1g+JDko=; b=vCwjS0xIg7QTYg ql56TUE+xm2EACcy93EY2aaeSwO3HzxSSKOQP1eSRWQ+Ey/9bnQvuEwlmV+VgVQZpPRcCfwNMXgKj VvheX08FZNhRaOeUoS5KUv2M2mMhmETGn0J6X8MsLj2RStgSQvVjeePPv/hlmr3SXmmn7IBQANI2a RYzbEmG7VIIx71u3zSuZq+LOVyB0buxNIv8t16IgkEzF2ac0YHfxm0rdIyRq36pLUFTcjH5wkhBrH v6UGQhXhhVdo3V8g8YXNj4cOYWr1WihKZOYplfimiGu0fqTiTmHBsRrYGLaA4lDY8BW9y76KM582H gs8UEdqZFLn3Z5NMZuKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVZq-00FKeo-Gp; Sun, 25 Sep 2022 17:38:02 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVZn-00FKdE-Pe for linux-arm-kernel@lists.infradead.org; Sun, 25 Sep 2022 17:38:01 +0000 Received: by mail-pl1-x629.google.com with SMTP id t3so4358488ply.2 for ; Sun, 25 Sep 2022 10:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=xO448KceCisavgnMEtu9+mgSatT/mAr0e7j2jQiXQOs=; b=DSS1aszJsakUZlcb7/PTe16dIZzZYm4BhnUgSuNVpOT2LZ1uqlazjrdX42YPGVAkiD k78sYxx9jWssLTAkbM5vCPAHMDKBtAUKLwo23v3m6xkw7GLsySs71OSCxNFxEB9p6nNU XlySIQVQkRTnSRgjeJpJAkVHEpBy7Jz5XW5j+hdjBQDITVGlm5Hk11L1XkFFqy4Q7CCa dNlJaoHqd2fAqj1AGqTzxLFfnHGsudwiFxrWS4XEhgiP7xa/dpZ9N63WSXjv6EKvQSG+ ZPVa/5I9IQ/R0FoAhh0kv48jrS++cDCXZm1LNGVBVH2QQD1E4eHSY3tK/7v9tGjhYYMs lDmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=xO448KceCisavgnMEtu9+mgSatT/mAr0e7j2jQiXQOs=; b=AC3rkF/eDDt6/j2g18suCAB1kU57upR+cJAxtc3491od98gqNYdUJ/zgFGKsOVf+R4 Mjt6/lKdSnbZtyyBoqO8+SMJ5SIC0Ydm89Lo+r4/RNRO183rPoJGtilJn4q4XsGmSpVz rlNO8+8wX4jTNeXD7JJKN73vTozw/x0u3UrF447672P3b0hJWklKw8MiVxogF2JFWAv8 fdv7DjQoWUjRBQY/7v3hhXRZVoqd0GRgfafXrP1d5uh+Dh49YJrqK6ZnFwk9w0okHfxE mk43cZ9AUCeOIaR74e9kGhIyNROZQRPWd1ZyctqKSAmXIwGphnuI98mxpzXE3pszh4N+ X/VA== X-Gm-Message-State: ACrzQf0Ehq3Bm1ohgzqbTou6PT5PAOKDLyPNP9gRubuOldX1vJcrZvRN y4eVhHTptOysRtxCF8d83Z8= X-Google-Smtp-Source: AMsMyM6Fn/F4zHe5vkGrtbUhUFxGb86wljflha7lD+1Ypm8Et09ZnFu5Xy60yHwXmZ/fJxvmm9znmg== X-Received: by 2002:a17:90b:3803:b0:203:a31c:e2e9 with SMTP id mq3-20020a17090b380300b00203a31ce2e9mr20398444pjb.13.1664127478675; Sun, 25 Sep 2022 10:37:58 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p4-20020a170902bd0400b0016f057b88c9sm9547644pls.26.2022.09.25.10.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 10:37:58 -0700 (PDT) Date: Sun, 25 Sep 2022 10:37:57 -0700 From: Guenter Roeck To: "Alice Guo (OSS)" Cc: m.felsch@pengutronix.de, wim@linux-watchdog.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] watchdog: imx7ulp_wdt: Check CMD32EN in wdog init Message-ID: <20220925173757.GC1763764@roeck-us.net> References: <20220825083256.14565-1-alice.guo@oss.nxp.com> <20220825083256.14565-4-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220825083256.14565-4-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_103759_852014_1C44C88B X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 04:32:52PM +0800, Alice Guo (OSS) wrote: > From: Ye Li > > When bootloader has enabled the CMD32EN bit, switch to use 32bits > unlock command to unlock the CS register. Using 32bits command will > help on avoiding 16 bus cycle window violation for two 16 bits > commands. > > Signed-off-by: Ye Li > Signed-off-by: Alice Guo > Reviewed-by: Jacky Bai > Acked-by: Jason Liu Reviewed-by: Guenter Roeck > --- > > Changes for v2: > - none > > drivers/watchdog/imx7ulp_wdt.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c > index b8ac0cb04d2f..a0f6b8cea78f 100644 > --- a/drivers/watchdog/imx7ulp_wdt.c > +++ b/drivers/watchdog/imx7ulp_wdt.c > @@ -180,11 +180,16 @@ static int imx7ulp_wdt_init(void __iomem *base, unsigned int timeout) > > local_irq_disable(); > > - mb(); > - /* unlock the wdog for reconfiguration */ > - writel_relaxed(UNLOCK_SEQ0, base + WDOG_CNT); > - writel_relaxed(UNLOCK_SEQ1, base + WDOG_CNT); > - mb(); > + val = readl(base + WDOG_CS); > + if (val & WDOG_CS_CMD32EN) { > + writel(UNLOCK, base + WDOG_CNT); > + } else { > + mb(); > + /* unlock the wdog for reconfiguration */ > + writel_relaxed(UNLOCK_SEQ0, base + WDOG_CNT); > + writel_relaxed(UNLOCK_SEQ1, base + WDOG_CNT); > + mb(); > + } > > ret = imx7ulp_wdt_wait(base, WDOG_CS_ULK); > if (ret) > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel