From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE51CC54EE9 for ; Sun, 25 Sep 2022 17:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9rqG21pRbLtr4kMIka0eXUwsg+S4Puc6AlGJxpBi1kY=; b=ENpYN6+dGkWMUz 0Pe0711EdKSgjTLn5kQV+skS9+QjhNS/ME/7CC8TCPZlzmg3v8SUh26E3GDHMfE5975DD+RzldDm7 gn+iBhCD7MBC8yCds2pR5nYSXUadIzPwx+FPMbHoCJH3snnzt/YTSxZ2fy7jWdVIMjGtV1opXcGD7 JiUjNGP2v1rNCrl8fiUxrH4pglsJbNWAAi3+KFcCeZLN+0N7EGIUatrRW7Caau33yPgasKU1txeuQ 58QRKu/dK4rkzfTisrUoPpEDnhLvOqVqOOL0n7tLqFss1Ycg4913pYg/qDQfqhtgs41V3elLP2fme pTfW+QuhPgFxG4YzZv9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVak-00FLBg-Lp; Sun, 25 Sep 2022 17:38:59 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocVaN-00FKx4-Iv for linux-arm-kernel@lists.infradead.org; Sun, 25 Sep 2022 17:38:37 +0000 Received: by mail-pl1-x634.google.com with SMTP id d24so4346238pls.4 for ; Sun, 25 Sep 2022 10:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=vQZO1T+2P9vB/pAMKD6Wmpnh4LsSpeo97BnzaUWc8kw=; b=V1WwtKj2hYjgQkYuV+CzUcuHJcJKeuorLIpBql4WK464n0rrnZ4eLe8jNObsTSw5eh DfAB2aHJUTkIEOJq79ArH3vWGT3HHoRwSiszdZRUXiegTHJxU7mEmv98fvL41WDbyIdF jYGTp4hKyvZgJotOy3xeRpIM4lCrAA9JovVlenZ9B6fscRiPG6526u2lrZAqZbhKhKNS sjPTyRImZcvE7q/6ucWLQOzoKBSBp3RoCSBCCfdJcIGd7zfu9Ex3eoGRaHjm/w1NSoI9 xh4rGkDEA0I65J1oREAeCDfQFOPrffpjcYC/FPgVm+iK1r70MbQ4Ln1PiN1R3FpbwqoB T+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=vQZO1T+2P9vB/pAMKD6Wmpnh4LsSpeo97BnzaUWc8kw=; b=HMAJj0NSDM6gX0z5ustmY6b4p1CyF0qJygIzaHjbtVuRdKCCjagZpBxsahrCiHBnms RrxVXRDT3zxyqLoOCFX2U3JDGTzkcL6N7uKZH6YKn5XnH5pmo/7ZxT8k5K5DN9rL+EiM 1OBJT5NEwGA1FaGpoQmOCZ6JQnyDqInAgmZuJJogoI4ZuoWZ2JdqPK0tMbLkcuIqtXkc oFBGYfEz+alIgLBekP0q8f7t9UMTaiQQuX1jCoo7FqKrC8vDkSMKBcxw1zNAVJJuhrNs gMeva2Dw9We/Myae+Oz7Bhs81l1eaAkrY4WU4by9Lng65W9WlJFDcAWai6k4eUk9GCaS drrQ== X-Gm-Message-State: ACrzQf3iKMV8b5QHDRRbDtt5yXvRO6IBkWlwk98C12bTPaZGbIyVoB6A ef7S9kv0tausvJlFpqIgRFc= X-Google-Smtp-Source: AMsMyM7OIFM4CJxHM2BKDOc/BYhHvukBGHOTZosq9H5BaZKKIe0cn6ZLE92n09UAsXpQbjAFIo3CnA== X-Received: by 2002:a17:902:f707:b0:178:77ca:a770 with SMTP id h7-20020a170902f70700b0017877caa770mr18142218plo.54.1664127513845; Sun, 25 Sep 2022 10:38:33 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id w16-20020a170902e89000b00176d8e33601sm9555031plg.203.2022.09.25.10.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 10:38:33 -0700 (PDT) Date: Sun, 25 Sep 2022 10:38:32 -0700 From: Guenter Roeck To: "Alice Guo (OSS)" Cc: m.felsch@pengutronix.de, wim@linux-watchdog.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] watchdog: imx7ulp_wdt: init wdog when it was active Message-ID: <20220925173832.GF1763764@roeck-us.net> References: <20220825083256.14565-1-alice.guo@oss.nxp.com> <20220825083256.14565-7-alice.guo@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220825083256.14565-7-alice.guo@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_103835_657524_4A4A6D13 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 25, 2022 at 04:32:55PM +0800, Alice Guo (OSS) wrote: > From: Jason Liu > > Paired with suspend, we can only init wdog again when it was active > and ping it once to avoid the watchdog timeout after it resumed. > > Signed-off-by: Jason Liu > Signed-off-by: Alice Guo > Reviewed-by: Ye Li > Reviewed-by: Jacky Bai > Tested-by: Jacky Bai Reviewed-by: Guenter Roeck > --- > > Changes for v2: > - none > > drivers/watchdog/imx7ulp_wdt.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c > index 0cafa86fff7f..dee02c2a52c9 100644 > --- a/drivers/watchdog/imx7ulp_wdt.c > +++ b/drivers/watchdog/imx7ulp_wdt.c > @@ -136,13 +136,6 @@ static int imx7ulp_wdt_enable(struct watchdog_device *wdog, bool enable) > return ret; > } > > -static bool imx7ulp_wdt_is_enabled(void __iomem *base) > -{ > - u32 val = readl(base + WDOG_CS); > - > - return val & WDOG_CS_EN; > -} > - > static int imx7ulp_wdt_ping(struct watchdog_device *wdog) > { > struct imx7ulp_wdt_device *wdt = watchdog_get_drvdata(wdog); > @@ -382,11 +375,11 @@ static int __maybe_unused imx7ulp_wdt_resume_noirq(struct device *dev) > if (ret) > return ret; > > - if (imx7ulp_wdt_is_enabled(imx7ulp_wdt->base)) > + if (watchdog_active(&imx7ulp_wdt->wdd)) { > imx7ulp_wdt_init(imx7ulp_wdt, timeout); > - > - if (watchdog_active(&imx7ulp_wdt->wdd)) > imx7ulp_wdt_start(&imx7ulp_wdt->wdd); > + imx7ulp_wdt_ping(&imx7ulp_wdt->wdd); > + } > > return 0; > } > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel