From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA098C433FE for ; Thu, 29 Sep 2022 21:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYlEXUKdCoX4A4EoDdM7bPDsfOxS8/qAg3GmYj8W8aA=; b=oDLmMcuP61CwPf 8QaDbRoiqMtCM4wiQW5WfHf5ajyYIBHIpS3C8Bo2IAj9BOiXDXWxxJNYBfzRiwQr99mmDY6qL876d pPW052z4f1b69AsDDc6Z4Qq8gl5YQ0R5wy1o6LITwQsCysQ6nCvToSoEgzT4tTPoirE0dFP5Mduat eXVCaP0/M2/g/FVM7t01So1NXrYaEgtzX8KiMFNha+CYdp7Dq/nuDf9Lz7DA6XmftXzN6WWN+G+md Ic8G1TjgIZDq1tcoxyDZKrFRNuAaCOTtW5mjadbVPMxQYsTq2n0FbTOeTiNmQ9Te3H9yAlNUh3rhV FyHOMzT7i15L/348SS1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe15P-005WH7-6X; Thu, 29 Sep 2022 21:28:51 +0000 Received: from mail-oa1-f50.google.com ([209.85.160.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe15M-005WGU-HZ for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 21:28:49 +0000 Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-12c8312131fso3358436fac.4 for ; Thu, 29 Sep 2022 14:28:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=3bn05vns/+BJdL+cVZ+KI4bs4xLeU8Ssku17kR1tQdw=; b=PrdP7bH/RvlEPVtP9/ks6OTp6ADo5w1hH7237Jars33rotHAIH/1ICd7FVj2KH8HSP 06iHolp2oOPVOpLW7yw71nsLaQaNNDKUebKWd+/aNTb9kiUGOTfRd7gza/tTmbUzRVyB m/FEu+RgqCI+Fqs6byytF8BZVZgZjQJv73vTucoXuZoGfBijZmQl4FJ+uEIFEGbAVy9J qGdBb6eNggRNfQKNvyevBY0z77CzBNEyzA7LVFu3aM7AXQrhylb+c+TwXxttd5aTGo7v /nG2JatT50cU4IbU2KDn53ANN744iNRexKDRnwpD0bVdq/toRI0hdf3pdH57XrGoV7Wl Yb6w== X-Gm-Message-State: ACrzQf17P356ufUaI1CqUb1mxo3j5Ig2x7joE+m8Egc8G6TF4rHvw9VP 680JNZ5/U5i47p9dlFjoUlXh6MdkiQ== X-Google-Smtp-Source: AMsMyM6VIaKSo/VfUni9X7fBpo31lixw5SSw48UWYpbP8bGmWl5kpjEyhqfCPPFogPV8NsqUBYVGZg== X-Received: by 2002:a05:6870:4184:b0:131:55a3:2fef with SMTP id y4-20020a056870418400b0013155a32fefmr9707128oac.223.1664486926657; Thu, 29 Sep 2022 14:28:46 -0700 (PDT) Received: from macbook.herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id k28-20020a05680808dc00b00342df642fd3sm99651oij.48.2022.09.29.14.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 14:28:46 -0700 (PDT) Received: (nullmailer pid 2744344 invoked by uid 1000); Thu, 29 Sep 2022 21:28:45 -0000 Date: Thu, 29 Sep 2022 16:28:45 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: samsung: soc: match preferred naming in entire compatible Message-ID: <20220929212845.GA2725627-robh@kernel.org> References: <20220926124757.475471-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220926124757.475471-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_142848_598389_926D4A56 X-CRM114-Status: GOOD ( 17.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 26, 2022 at 02:47:57PM +0200, Krzysztof Kozlowski wrote: > Compatible is a string-array, therefore the "select" should look for > anything containing Samsung SoC part. This allows to validate cases > like: > - "samsung,exynos5250-gsc", "samsung,exynos5-gsc" > - "samsung,exynos5250-pmu", "syscon" > - "tesla,fsd-mct", "samsung,exynos4210-mct" > > Since Tesla FSD builts on top of Exynos blocks, add an adidtional > pattern for it. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/arm/samsung/samsung-soc.yaml | 26 +++++++++++++++---- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml > index 653f85997643..bb1fdc205b44 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml > @@ -18,17 +18,33 @@ description: | > samsung,exynos5433-cmu-isp > > select: > - properties: > - compatible: > - pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$" > + allOf: > + - properties: > + $nodename: > + pattern: '^[a-z]' Why do you need this? > + - properties: > + compatible: > + contains: > + pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$" > required: > - compatible > > properties: > compatible: > oneOf: > - - description: Preferred naming style for compatibles of SoC components > - pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$" > + - description: Preferred naming style for compatibles of S3C/S5P/Exynos SoC components > + minItems: 1 > + items: > + - pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$" > + - {} > + - {} Wouldn't just contains be fine here too: contains: pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$" > + > + - description: Preferred naming style for compatibles of Tesla FSD SoC components > + minItems: 1 > + items: > + - pattern: "^tesla,fsd-.*$" > + - {} > + - {} > > # Legacy compatibles with wild-cards - list cannot grow with new bindings: > - enum: > -- > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel