From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 059AAC433F5 for ; Sun, 2 Oct 2022 13:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ov6n2MbSFakEO97G5khOMLJkvt/+l0K8F+knqpZOoSY=; b=huFlHld5NrdmeO 5wRcARy2jOFHdaawaiWa2whxRO+sOsBplL1oq/bkV7tqnXAL37sa/e2+yhDJgWjf5S7v/OAQVQT+D nkrOfL7RmChKAeEw4msbSEbSqZB+2zRe8N+iOpywYLOoPaimXd53/U/Q0LeRUz9YmUdd/MOPaEXul al0TGYCHCnksjJm3ODm3Z353IfQvqCyasHcKqo+PaiYduGJhWrX9yUNUS/KxKoKYuNvNTcHP21AB0 5AnHkj6V1O9xgdBnG31JrK9BiBKaijHI8G2kwa7GwSB/ihiT0JsAAGC/StfiC/hl8FNl1in+a2Wy4 ulfo7fV5uiw3yAL4fUJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oez5c-001LBL-Rz; Sun, 02 Oct 2022 13:33:04 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oez5a-001LAv-UN for linux-arm-kernel@lists.infradead.org; Sun, 02 Oct 2022 13:33:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B329F60D2D; Sun, 2 Oct 2022 13:33:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2991FC433D6; Sun, 2 Oct 2022 13:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664717581; bh=ip2SEwPEk79/NVSLR/aKzp9lX2c3j+xDgmd4CAEEvAc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MfjLc+nyXECLHzOijUKe92NOenb1ZvhnQKXYzLVDJHC6T9zVC3J+zo3iCcjyskjqF k/NOePyASmXK/x/pMlRhTUaPrXIKEnu3xjRuq5OQ4AGot1ywkF54TO/58xlxAmT0gp qSjqDc3Upw/IwYnQLxRIhAvSvO6PKdSi70UopjKIclFpX60UA8Nl3pIF9cxh/9RBJt Zz92vVPrWrvx8YpaKc3XbU4azjzhXhre3yEto8BljAj4uAwskH8xNZgvE7IHAaRcb0 Ycym//1UGWiVY5vkciQLNcjKkyKLA18q5C8LpUH3OgI7rkdQHtaUTs7BuGCLGrBJFz 9Pk2FmEeF7mzA== Date: Sun, 2 Oct 2022 14:33:15 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Olivier Moysan , Alexandre Torgue , Fabrice Gasnier , Lars-Peter Clausen , Maxime Coquelin , nuno.sa@analog.com, Paul Cercueil , Sebastian Andrzej Siewior , Wan Jiabing , Yannick Brosseau , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 1/8] iio: adc: stm32-adc: fix channel sampling time init Message-ID: <20221002143315.05b867a2@jic23-huawei> In-Reply-To: References: <20220928164114.48339-1-olivier.moysan@foss.st.com> <20220928164114.48339-2-olivier.moysan@foss.st.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221002_063303_044712_015A37C1 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Sep 2022 19:51:04 +0300 Andy Shevchenko wrote: > On Wed, Sep 28, 2022 at 7:42 PM Olivier Moysan > wrote: > > > > Fix channel init for ADC generic channel bindings. > > In generic channel initialization, stm32_adc_smpr_init() is called > > to initialize channel sampling time. The "st,min-sample-time-ns" > > property is an optional property. If it is not defined, > > stm32_adc_smpr_init() is currently skipped. However stm32_adc_smpr_init() > > must always be called, to force a minimum sampling time for > > the internal channels, as the minimum sampling time is known. > > Make stm32_adc_smpr_init() call unconditional. > > What is the text width here? It's okay to use Up to ~72 (or slightly > more) as a limit and format accordingly. > > > Fixes: 796e5d0b1e9b ("iio: adc: stm32-adc: use generic binding for sample-time") > > > > Signed-off-by: Olivier Moysan > > Tag blocks mustn't have the blank lines. > For this one, please make it clear if this is breaking current systems or if this is more theoretical, so I can judge whether to rush it in (and potentially slow down the rest of this patch set!) Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel