From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58AD6C433F5 for ; Mon, 3 Oct 2022 19:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iueu07mjMVqbdXqNN1qIhYTvNmFyA/DJwSLCjLDtxPc=; b=Ndx28wCH6F91qL a3F4xGXwvhu4USkA0GAM2BDOu1OYhXF6PsdPO+rXDlj9YLKE3e44PqrW4NE8jjOpBP/hrHjevi7qF YrmGrFO9JXdmj+2IWhH5Wmz6TXuMaitpxYaMRBQVFuJsAwRacADN8l75PI78z+HG8j9W/itg6W5JW UG4miXeB3uoIKhOe1o4LzpFx8ziyCZeS3qKasitrtkEvxBM/607+CdZjcZacIfIDXV6K/9gk6neCj 2ULVBRTPclRQAGB+pTspUB/fSTwgs401KiquriCckk9cvKl6Tv7422W/5mSH1pxd5Zjp8oTvfhn5a sU5g44BcYf+L873Lw/xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofR7q-007McF-OS; Mon, 03 Oct 2022 19:29:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofR7n-007MbC-Nf for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 19:29:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D660611B5; Mon, 3 Oct 2022 19:29:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4FDFC433C1; Mon, 3 Oct 2022 19:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664825349; bh=Ohxb9wVDCtANaJlNvXb161+sInuADg+bmODHASpwDzI=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=cEF9RaEDd3RP6PirkvbpABkj2JwRnBIjLoQsMY3JCgO504sptM+ojZNkqtzR9x40p eVq66NdgGwpbpMObcHo6OHnBL9fEY4OUEh0H6PA3Xoj+3uZBKtChbgAOVTAGQzi/mJ q6K3WOnvIJW1MlFenYlquR2dJo3uRW5FnhyJADv9ws40td29YHa5D+/LuTJIesaBCI wfoxPR5YWu97LSiQG83oz0419mWrBkJR/jrOgyWm/O5WHOgj1mGOLMA0MllubfLnNZ 6a9Omzs2P/TyPfMqN+s/Hr6OEThZp6jZEQKNoh963IRD6utEJ3ZbLGN/PB/RBL+4me c7+hKy9YS5GwQ== MIME-Version: 1.0 In-Reply-To: <663cdebe-755f-3a93-07f4-da662ccb5a43@gmail.com> References: <20220901183343.3188903-1-Mr.Bossman075@gmail.com> <20220901183343.3188903-9-Mr.Bossman075@gmail.com> <20220930202819.C4952C433D6@smtp.kernel.org> <663cdebe-755f-3a93-07f4-da662ccb5a43@gmail.com> Subject: Re: [PATCH v6 08/10] clk: imx: Add initial support for i.MXRT1170 clock driver From: Stephen Boyd Cc: robh+dt@kernel.org, mturquette@baylibre.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, daniel.lezcano@linaro.org, tglx@linutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, dev@lynxeye.de, marcel.ziswiler@toradex.com, tharvey@gateworks.com, leoyang.li@nxp.com, sebastian.reichel@collabora.com, cniedermaier@dh-electronics.com, clin@suse.com, giulio.benetti@benettiengineering.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org To: Jesse Taube , linux-imx@nxp.com Date: Mon, 03 Oct 2022 12:29:07 -0700 User-Agent: alot/0.10 Message-Id: <20221003192908.E4FDFC433C1@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_122911_847130_F95F852A X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jesse Taube (2022-10-01 09:15:38) > On 9/30/22 16:28, Stephen Boyd wrote: > > Quoting Jesse Taube (2022-09-01 11:33:41) > >> + > >> + anp = of_find_compatible_node(NULL, NULL, "fsl,imxrt-anatop"); > >> + pll_base = of_iomap(anp, 0); > >> + of_node_put(anp); > >> + if (WARN_ON(!pll_base)) > >> + return -ENOMEM; > > > > The kzalloc() leaked. > LOL `grep -r of_find_compatible_node drivers/clk/imx`... > Shall I send patches for the rest of IMX. > Sure? Introducing more things to cleanup isn't useful, that's all. If you have other things to do then don't worry about it. > >> + > >> + imx_check_clk_hws(hws, IMXRT1170_CLK_END); > >> + > >> + ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_hw_data); > > > > Use devm? Or implement a driver remove function? > Uh this is the same in the rest of imx could you explain a bit more? > Use devm_of_clk_add_hw_provider() so that the provider is removed on driver unbind. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel