From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Russell King <linux@armlinux.org.uk>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Viresh Kumar <vireshk@kernel.org>,
soc@kernel.org
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: spear: Move prototype to accessible header
Date: Mon, 10 Oct 2022 18:01:14 -0700 [thread overview]
Message-ID: <20221011010116.A6245C433C1@smtp.kernel.org> (raw)
In-Reply-To: <f334e8bcc22fde795de9c8067898d4c0522d44ae.1665375739.git.viresh.kumar@linaro.org>
Quoting Viresh Kumar (2022-10-09 21:22:37)
> Fixes the following W=1 kernel build warning(s):
>
> drivers/clk/spear/spear6xx_clock.c:116:13: warning: no previous prototype for function 'spear6xx_clk_init' [-Wmissing-prototypes]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
> diff --git a/include/linux/clk/spear.h b/include/linux/clk/spear.h
> index a64d034ceddd..eaf95ca656f8 100644
> --- a/include/linux/clk/spear.h
> +++ b/include/linux/clk/spear.h
> @@ -8,6 +8,20 @@
> #ifndef __LINUX_CLK_SPEAR_H
> #define __LINUX_CLK_SPEAR_H
>
> +#ifdef CONFIG_ARCH_SPEAR3XX
> +void __init spear3xx_clk_init(void __iomem *misc_base,
__init is meaningless in header files
> + void __iomem *soc_config_base);
> +#else
> +static inline void __init spear3xx_clk_init(void __iomem *misc_base,
> + void __iomem *soc_config_base) {}
> +#endif
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-11 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 4:22 [PATCH] clk: spear: Move prototype to accessible header Viresh Kumar
2022-10-11 1:01 ` Stephen Boyd [this message]
2022-10-11 3:11 ` Viresh Kumar
2022-10-11 3:46 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011010116.A6245C433C1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).