From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FCB6C433FE for ; Wed, 12 Oct 2022 15:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qn4HNTBu55NmqiCym/Rekwgg9W4TaXJzXGaKiVzwSE0=; b=mzjHJRMczgxk3+ V49tDxc/xCuWs2Vh221Pc8RfdppE8hTEAI1IZOWOeRuPh/k01fdQAI5Z1jUJy4BiDeZ/mLtEimrze SbFkzyXR5TXk0vCxVe8KNyvkN8cUSS0+OuhV4lLvyuDWl9OKJOtiWi1Cx67aNqqw8YBYTjdr1EVFa XgENHNezR+NnX4Cl1LhqaF5eI5O8v7vEQ6W4KIxl5vAsD4+PQXR4DhtiW+hbggPE0vPrmem1wBEh5 +QlVN2nuv4aVTtUKg1rV+o/pkBhJDz81SUDoy7Yr6VE3cfjzjfNwlM0Os3M5MHTdkGRGTrTwYCnh8 nMmRQjDWPhXlynpjn4lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oie6H-008crj-91; Wed, 12 Oct 2022 15:56:53 +0000 Received: from mail-oa1-f46.google.com ([209.85.160.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oie6D-008cqV-9l for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 15:56:50 +0000 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1321a1e94b3so19954059fac.1 for ; Wed, 12 Oct 2022 08:56:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+J5rBH2Ax6+Mtwp/uLP5yn6FuEpFbZJdzQoPclekoRQ=; b=sNBcmyblyr5LWZuDFrTUwh14oeUI2kr9p5eHI9n7dO06QByHdHFI6OtWQfq+SeA1te T43h2clqYhPkgEF6Cxw0F9cxftwlS1fxahN2a/iH9hsJaHsdxu+UqClMni687PcJbZdj 3mLtK3DLjQm44x4m68EEBXyXlK3BBAV2nMYorX1uHWgKL6o0QvQ8Jdc4UaxoeiNXCSqU 74Ccl2ryBU5i71jGZs5v/Qm64hMElP02ZndkJSAeGTBNEnhXYo2y3z84+oYJgQFVQ9Ms E57opCotrdGqpuhxs+zssZ9VdQv+0uv3nnwbPZgKVU1hOxnaM03kDgJ80fvI9Ad/C5sb lrPQ== X-Gm-Message-State: ACrzQf0iJY3GFwDaiEhQuQNR7L6GoPtV79GyuZ9I3h2m3COufTsnDM34 0T0o316iUE1SH7Ye6Q8xnQ== X-Google-Smtp-Source: AMsMyM7eg6DI/M1+ccTCr5c2InEdknfBOftpJQN1uw9+vlHkdneRdNuwICBHaQyeqK5xSUvxtk/P7Q== X-Received: by 2002:a05:6870:ac2b:b0:132:f761:8f4c with SMTP id kw43-20020a056870ac2b00b00132f7618f4cmr2730690oab.17.1665590205023; Wed, 12 Oct 2022 08:56:45 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bi35-20020a05680818a300b00354978180d8sm2981717oib.22.2022.10.12.08.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 08:56:44 -0700 (PDT) Received: (nullmailer pid 2187963 invoked by uid 1000); Wed, 12 Oct 2022 15:56:45 -0000 Date: Wed, 12 Oct 2022 10:56:45 -0500 From: Rob Herring To: Elliot Berman Cc: Bjorn Andersson , Krzysztof Kozlowski , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 02/13] dt-bindings: Add binding for gunyah hypervisor Message-ID: <20221012155645.GA2173829-robh@kernel.org> References: <20221011000840.289033-1-quic_eberman@quicinc.com> <20221011000840.289033-3-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221011000840.289033-3-quic_eberman@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_085649_365803_1A9CA050 X-CRM114-Status: GOOD ( 29.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 10, 2022 at 05:08:29PM -0700, Elliot Berman wrote: > When Linux is booted as a guest under the Gunyah hypervisor, the Gunyah > Resource Manager applies a devicetree overlay describing the virtual > platform configuration of the guest VM, such as the message queue > capability IDs for communicating with the Resource Manager. This > information is not otherwise discoverable by a VM: the Gunyah hypervisor > core does not provide a direct interface to discover capability IDs nor > a way to communicate with RM without having already known the > corresponding message queue capability ID. Add the DT bindings that > Gunyah adheres for the hypervisor node and message queues. > > Signed-off-by: Elliot Berman > --- > .../bindings/firmware/gunyah-hypervisor.yaml | 87 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 88 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml > > diff --git a/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml b/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml > new file mode 100644 > index 000000000000..f0a14101e2fd > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/gunyah-hypervisor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Gunyah Hypervisor > + > +maintainers: > + - Murali Nalajala > + - Elliot Berman > + > +description: |+ > + On systems which support devicetree, Gunyah generates and overlays a deviceetree overlay which How you end up with the node (applying an overlay) is not relavent to the binding. > + describes the basic configuration of the hypervisor. Virtual machines use this information to determine > + the capability IDs of the message queues used to communicate with the Gunyah Resource Manager. Wrap at 80. That is the coding standard still though 100 is deemed allowed. And yamllint only complains at 110 because I didn't care to fix everyones lines over 100. > + See also: https://github.com/quic/gunyah-resource-manager/blob/develop/src/vm_creation/dto_construct.c > + > +properties: > + compatible: > + items: > + - const: gunyah-hypervisor-1.0 > + - const: gunyah-hypervisor 2 compatibles implies a difference between the 2. What's the difference? Where does '1.0' come from? > + > + "#address-cells": > + description: Number of cells needed to represent 64-bit capability IDs. > + const: 2 > + > + "#size-cells": > + description: must be 0, because capability IDs are not memory address > + ranges and do not have a size. > + const: 0 > + > +patternProperties: > + "^gunyah-resource-mgr(@.*)?": > + type: object > + description: > + Resource Manager node which is required to communicate to Resource > + Manager VM using Gunyah Message Queues. > + > + properties: > + compatible: > + items: > + - const: gunyah-resource-manager-1-0 > + - const: gunyah-resource-manager Same comment here. > + > + reg: > + items: > + - description: Gunyah capability ID of the TX message queue > + - description: Gunyah capability ID of the RX message queue > + > + interrupts: > + items: > + - description: Interrupt for the TX message queue > + - description: Interrupt for the RX message queue > + > + additionalProperties: false > + > + required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +examples: > + - | > + #include > + > + hypervisor { > + #address-cells = <2>; > + #size-cells = <0>; > + compatible = "gunyah-hypervisor-1.0", "gunyah-hypervisor"; > + > + gunyah-resource-mgr@0 { > + compatible = "gunyah-resource-manager-1-0", "gunyah-resource-manager"; > + interrupts = , /* TX full IRQ */ > + ; /* RX empty IRQ */ > + reg = <0x00000000 0x00000000>, <0x00000000 0x00000001>; > + /* TX, RX cap ids */ > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 91d00b00d91c..ef6de7599d98 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8884,6 +8884,7 @@ M: Elliot Berman > M: Murali Nalajala > L: linux-arm-msm@vger.kernel.org > S: Supported > +F: Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml > F: Documentation/virt/gunyah/ > > HABANALABS PCI DRIVER > -- > 2.25.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel