From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29303C4332F for ; Thu, 13 Oct 2022 10:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5RdbC2G0NVppGLYP8zLbwkiBjFGijg4JgxmBSpP+dgM=; b=jJHOdc2LcnCxfF OWm86iTIBRIpRCnwAY7FgKEUlF34mTZ6lImup0U4T5yCXY5G8ES13kViXUdOA06vvVeBqHvNcWnrx nQTu+1J7vQJj9N0HAhvkQLlJ1Yu/VfhDR0p3cFzM6yK6cWt0ghGzU916KXh5sVTKo1WSskFptWN/B cKb6B8Z/9h0Hzlkd/thkWGb3wOGyPl9Pfn6IgoznpAXZeYWj0jgBxRul4SK9q0UXm4xbceGqx+5QQ t7UD5Y4HnHxD0bKDPysiAcZROhar7+XCPDhNh3HOKjta+b6USnbzcMPZ2Jl8DHlUQkasGwnxkGi46 aqHtIVL62Z9Ytr3SVyiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oivEL-00BOD8-6f; Thu, 13 Oct 2022 10:14:21 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oivEI-00BOCU-Mo for linux-arm-kernel@lists.infradead.org; Thu, 13 Oct 2022 10:14:20 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivEC-0004MS-Vg; Thu, 13 Oct 2022 12:14:12 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oivEC-0008EZ-EU; Thu, 13 Oct 2022 12:14:12 +0200 Date: Thu, 13 Oct 2022 12:14:12 +0200 From: Sascha Hauer To: Rob Herring Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Chen , Peng Fan , Pengutronix Kernel Team , devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] dt-bindings: usb: ci-hdrc-usb2: Add more phy tuning properties Message-ID: <20221013101412.GI6702@pengutronix.de> References: <20221011082924.884123-1-s.hauer@pengutronix.de> <20221011082924.884123-7-s.hauer@pengutronix.de> <20221012160806.GA2189350-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221012160806.GA2189350-robh@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_031418_769080_611A0C71 X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 12, 2022 at 11:08:06AM -0500, Rob Herring wrote: > On Tue, Oct 11, 2022 at 10:29:24AM +0200, Sascha Hauer wrote: > > Following the example of samsung,picophy-dc-vol-level-adjust more > > phy tuning properties are added for configuring the remaining bitfields > > in the USBNC_n_PHY_CFG1 register. > > All these properties really doesn't scale. These properties should go > in the phy node as they are properties or the phy. There's no rule that > you can only read properties from the driver's device node. I understand and agree. On i.MX8M we currently use the usb-nop-xceiv. I guess it's not an option to just add these properties there, so we'll need a phy node with a new compatible like fsl,imx8mm-usbphy. The driver would basically just register a usb-nop-xceiv and the node would be a container for the new property. Does this sound sane? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel