From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F659C433FE for ; Thu, 13 Oct 2022 14:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Zd+IlacrovLxadXB3b6uOH0nfIHbJAc4P/h6bjxRM+Q=; b=dJiaFcKUtVitrq 8ygX5yMVA1ctU9BE6qr7jVuYSf+3EMxnBDEpT9zYR3vb1XnRHAiTfkgcpazauzFWnsu5rPYkOpsUE rBakeXbDUUY7YDBR3cY5euUh0sKcZmqic2EwRwID/2Qn0QxVMHMe/GpTIKVzja0lEH/fUlAY4/edT A4pTM+MkQ+XoJKanFe9nrq7gmIFSb6lTk3FtNCVHmijyi1b5SbB8SMqOAk85axPuCdcsS4QcFTuo+ ukdIZbKT3Ja0i2nGop4TLg94crZ9PcnGirBGiZPNXfkhay4PySUvt7F8UXHb8COJpx9HWu4cBtoae qTUNI0vfaINLT1qvJm9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiyw3-00C6ns-SG; Thu, 13 Oct 2022 14:11:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiyw0-00C6n5-K4; Thu, 13 Oct 2022 14:11:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 04767B81E53; Thu, 13 Oct 2022 14:11:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6416DC433D6; Thu, 13 Oct 2022 14:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665670297; bh=mpFbZHArAaQgmD7RTxwwRekiQKVwpKraUwtRqWMUdYY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=B77rUDC5VLnYV3z9CTVT9A86ODZkirniB9tdWCE3MZPO3snv90muE8TJdSM+Gx0BZ 9BDPSmcxbSE0jcQL9z9ZD3EqOUTBDGGJF2qbCem2lwwBk0yb+8Tu3EeMI2nJsxYV1Z XcRKnVh0jVtOWrH64ZQdluPGA7RLBxEABBDUFvJz4E9yPdikzqLBGiktSoUpSELuIa eHDYW2A2BtZlYto2Gx0X16y5LDi2FoQuA3wFTuJXHoJhu5gFn35nn/X9j8MCIKA6HQ sMRun6/oeuxYbaEgrDIuQELrn7TGjgkpoqNPT7NoF04HLifCNU/DkvqrE2p1/F81F6 mk9cOFUUZF36g== Date: Thu, 13 Oct 2022 09:11:35 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2 4/5] PCI: brcmstb: Functions needlessly specified as "inline" Message-ID: <20221013141135.GA3245411@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221011184211.18128-5-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221013_071140_975000_93349021 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If you have occasion to revise this series, update the subject to be a sentence like the others, e.g., something like PCI: brcmstb: Drop needless 'inline' annotations On Tue, Oct 11, 2022 at 02:42:09PM -0400, Jim Quinlan wrote: > A number of inline functions are called rarely and/or are not > time-critical. Take out the "inline" and let the compiler do its work. > > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli Thanks, looks good to me! Reviewed-by: Bjorn Helgaas > --- > drivers/pci/controller/pcie-brcmstb.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index c7210cec1f58..e3045f1eadbc 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -723,7 +723,7 @@ static void __iomem *brcm7425_pcie_map_bus(struct pci_bus *bus, > return base + DATA_ADDR(pcie); > } > > -static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) > +static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) > { > u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; > u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; > @@ -733,7 +733,7 @@ static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, > writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > } > > -static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) > +static void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) > { > u32 tmp, mask = RGR1_SW_INIT_1_INIT_7278_MASK; > u32 shift = RGR1_SW_INIT_1_INIT_7278_SHIFT; > @@ -743,7 +743,7 @@ static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 > writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > } > > -static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) > +static void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) > { > if (WARN_ONCE(!pcie->perst_reset, "missing PERST# reset controller\n")) > return; > @@ -754,7 +754,7 @@ static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) > reset_control_deassert(pcie->perst_reset); > } > > -static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) > +static void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) > { > u32 tmp; > > @@ -764,7 +764,7 @@ static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) > writel(tmp, pcie->base + PCIE_MISC_PCIE_CTRL); > } > > -static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) > +static void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) > { > u32 tmp; > > @@ -773,7 +773,7 @@ static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) > writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); > } > > -static inline int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, > +static int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, > u64 *rc_bar2_size, > u64 *rc_bar2_offset) > { > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel