Re: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table (APMT) initial support

Sudeep Holla
2022-10-14T10:57:02Z

On Fri, Sep 30, 2022 at 07:46:08PM +0200, Rafael J. Wysocki wrote:
> On Thu, Sep 29, 2022 at 2:29 AM Besar Wicaksono <bwicaksono@nvidia.com> wrote:
> >
> > ARM Performance Monitoring Unit Table describes the properties of PMU
> > support in ARM-based system. The APMT table contains a list of nodes,
> > each represents a PMU in the system that conforms to ARM CoreSight PMU
> > architecture. The properties of each node include information required
> > to access the PMU (e.g. MMIO base address, interrupt number) and also
> > identification. For more detailed information, please refer to the
> > specification below:
> > * APMT: https://developer.arm.com/documentation/den0117/latest
> > * ARM Coresight PMU:
> > https://developer.arm.com/documentation/ihi0091/latest
> >
> > The initial support adds the detection of APMT table and generic
> > infrastructure to create platform devices for ARM CoreSight PMUs.
> > Similar to IORT the root pointer of APMT is preserved during runtime
> > and each PMU platform device is given a pointer to the corresponding
> > APMT node.
> >
> > Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> for the change in bus.c, but as a side note, it would be good to move
> all of the ARM-specific initialization into one place, so it is not
> necessary to touch bus.c every time a new piece of it is added.
>

Agreed, I will look into that and move them all under single acpi_arm_init()
or something.

--
Regards,
Sudeep