From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B74F9C433FE for ; Fri, 14 Oct 2022 13:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HPkkX7jFQ53xuKGkuSPNtxajjFFoq4FqytvRPpywP8E=; b=djqztgXZeMEyy/ 2rbmVVfNnnLJRkLxM++loRvzqtX3ToIQQJqYbSgoDfjR21IYa+VWb92XINKDpzlCoWIVCX+ltILqc gACH8M5OBN4bFmUr9JS7LEbtJI3AxfPyPmwR8T5Cu56NyQwM0JssmhuXRYXRUaaKfoPfljnufD55U tsqv6cTX9oJP/9FsCuKpFA1n7uUdB+hNVOmjVNNxmDPF4wJRPw/ioxPRGA+6D/dOcshwKT7yfRBiu vmF04P8fQhRjuk85fCG3w86STqbBfmw5RsRBi0+hCJgAqMLlEaRAvEhUAiCn6rHaj0WBa+hyOY7Ty 5BtzX+bWtRveTm/cBjeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojL00-00Ep8y-8i; Fri, 14 Oct 2022 13:45:16 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojKzx-00Ep82-30 for linux-arm-kernel@bombadil.infradead.org; Fri, 14 Oct 2022 13:45:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tB3OHq7bYnhkcWPFlFs5S7PCgQ9HEyIk8ZzvhKNoftg=; b=rGTLy6nicixfLGKntVmfUPPeBy k2WALV595PMpuyuFGwKet6H8pQR72yb/CSIKL53rcpSZi8JOpM1p+IMwLqrQxrDrKtTTp23kUdUWQ gixgCBJjVk48DrzV2BhYMQ2jTohYtLv6H0CakeTbxrSZvgLnXGz2JOZyHZY1Vcw/0iaTY5St4qymY uObV8t9QxRub1rYICH0sgN1TCwU70BdJW2zCdQBU6H2uL8gFDYK4PlpUYMQgsreAs1MJGCnBzkeZZ HG/bOOqCeL97oyruUi1WxnsOYEjCjFoc8qboXrzyfinMvWuk/wK7nrvDy5DPoBRGx0AEmlTwTeVws zlcuihoA==; Received: from post.baikalelectronics.com ([213.79.110.86]) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojKzs-003QAI-Pp for linux-arm-kernel@lists.infradead.org; Fri, 14 Oct 2022 13:45:11 +0000 Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1]) by post.baikalelectronics.com (Proxmox) with ESMTP id 493A7E0EB0; Fri, 14 Oct 2022 16:38:10 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= baikalelectronics.ru; h=cc:cc:content-type:content-type:date :from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=post; bh=tB3OHq7bYnhkcWPFlFs5 S7PCgQ9HEyIk8ZzvhKNoftg=; b=ovGonsdt2qJz2rPQrFmlmhF1O+1Va9yh6CuK +ugln6+efOHDJKjYYHGesL6HZenZVyZ7+OSn8qXhzRuEeC552HRSQFssikMeWh2Z Z2Kr1dj7SFoCwPhS5x2JNDyaAuilQRjp3aMyGW3n8imkbv8nGqopUjgj/HeFyS8E d6JPlwY= Received: from mail.baikal.int (mail.baikal.int [192.168.51.25]) by post.baikalelectronics.com (Proxmox) with ESMTP id 3412FE0E6A; Fri, 14 Oct 2022 16:38:10 +0300 (MSK) Received: from mobilestation (192.168.168.10) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 14 Oct 2022 16:38:09 +0300 Date: Fri, 14 Oct 2022 16:38:09 +0300 From: Serge Semin To: Arnd Bergmann CC: Serge Semin , Damien Le Moal , Anders Roxell , Naresh Kamboju , open list , Linux ARM , , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , , Lukas Bulwahn , Niklas Cassel Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Message-ID: <20221014133809.y7wvbxx2cvmsjoo7@mobilestation> References: <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com> X-Originating-IP: [192.168.168.10] X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221014_144509_170058_84DA3862 X-CRM114-Status: GOOD ( 38.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 14, 2022 at 09:31:55AM +0200, Arnd Bergmann wrote: > On Fri, Oct 14, 2022, at 2:22 AM, Damien Le Moal wrote: > > On 10/14/22 07:07, Anders Roxell wrote: > > [...] > >>> 8) > >>>> If reverting these patches restores the eSATA port on this board, then you need > >>>> to fix the defconfig for that board. > >>> > >>> OTOH, > >>> Anders, enabled the new config CONFIG_AHCI_DWC=y and tried but the > >>> device failed to boot. > >> > >> I thought it would work with enabling CONFIG_AHCI_DWC=y, but it didn't... > > > > As mentioned in my previous reply to Naresh, this is a new driver added in > > 6.1. Your board was working before so this should not be the driver needed > > for it. > > > >> However, reverting patch 33629d35090f ("ata: ahci: Add DWC AHCI SATA > >> controller support") > >> from next-20221013 was a success, kernel booted and the 'mkfs.ext4' cmd was > >> successful. > > > > Which is very strange... There is only one hunk in that commit that could > > be considered suspicious: > > > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > > index 9b56490ecbc3..8f5572a9f8f1 100644 > > --- a/drivers/ata/ahci_platform.c > > +++ b/drivers/ata/ahci_platform.c > > @@ -80,9 +80,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend, > > static const struct of_device_id ahci_of_match[] = { > > { .compatible = "generic-ahci", }, > > /* Keep the following compatibles for device tree compatibility */ > > - { .compatible = "snps,spear-ahci", }, > > { .compatible = "ibm,476gtr-ahci", }, > > - { .compatible = "snps,dwc-ahci", }, > > { .compatible = "hisilicon,hisi-ahci", }, > > { .compatible = "cavium,octeon-7130-ahci", }, > > { /* sentinel */ } > > > > Is your board using one of these compatible string ? > > The x15 uses "snps,dwc-ahci". I would expect it to detect the device > with the new driver if that is loaded, but it's possible that the > driver does not work on all versions of the dwc-ahci hardware. > > Anders, can you provide the boot log from a boot with the new driver > built in? There should be some messages from dwc-ahci about finding > the device, but then not ultimately working. > Yes. The boot-log would be very useful. > Depending on which way it goes wrong, the safest fallback for 6.1 is > probably to move the "snps,spear-ahci" and "snps,dwc-ahci" compatible > strings back into the old driver, and leave the new one only for > the "baikal,bt1-ahci" implementation of it, until it has been > successfully verified on TI am5/dra7, spear13xx and exynos. Right. This would be a possible solution. But I'd rather suggest to at least try to debug the problem. -Sergey > > Arnd > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel