From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Maxime Ripard <maxime@cerno.tech>
Cc: mturquette@baylibre.com, matthias.bgg@gmail.com,
chun-jie.chen@mediatek.com, miles.chen@mediatek.com,
wenst@chromium.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: mediatek: clk-mux: Add .determine_rate() callback
Date: Fri, 14 Oct 2022 12:36:50 -0700 [thread overview]
Message-ID: <20221014193652.0C745C433D6@smtp.kernel.org> (raw)
In-Reply-To: <20221012135619.wxyzuqheolhypoec@houat>
Quoting Maxime Ripard (2022-10-12 06:56:19)
>
> I think we need to address this in multiple ways:
>
> - If you have ftrace enabled on that platform, running with "tp_printk
> trace_event=clk:*" in the kernel command line on a failing kernel would
> be great, so that we can figure out what is happening exactly.
>
> - We really need to merge your patch above as well;
>
> - And, if we can, we should forbid to register a mux without a
> determine_rate implementation. We have to take into account that some
> muxes are going to be RO and won't need a determine_rate
> implementation at all, but a clock with a set_parent and without a
> determine_rate seems like a weird combination.
>
So should I apply this patch now on clk-next? Given this regression I'm
leaning towards not sending off the clk rate request this merge window
and letting it bake another cycle.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-14 19:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 13:55 [PATCH v2] clk: mediatek: clk-mux: Add .determine_rate() callback AngeloGioacchino Del Regno
2022-10-12 8:55 ` Maxime Ripard
2022-10-12 9:09 ` AngeloGioacchino Del Regno
2022-10-12 9:40 ` Maxime Ripard
2022-10-12 9:57 ` AngeloGioacchino Del Regno
2022-10-12 11:48 ` Maxime Ripard
2022-10-12 12:14 ` AngeloGioacchino Del Regno
2022-10-12 13:56 ` Maxime Ripard
2022-10-12 16:42 ` Maxime Ripard
2022-10-12 16:52 ` Chen-Yu Tsai
2022-10-13 7:19 ` Maxime Ripard
2022-10-13 8:13 ` AngeloGioacchino Del Regno
2022-10-13 8:25 ` Maxime Ripard
2022-10-14 19:36 ` Stephen Boyd [this message]
2022-10-18 7:06 ` Maxime Ripard
2022-10-28 0:30 ` Stephen Boyd
2022-10-14 20:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014193652.0C745C433D6@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).