From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 222AAC433FE for ; Sat, 15 Oct 2022 16:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pYQjppxDXVVki5o26FYycoxlRasHuRZBoujcvYHT4JA=; b=grHqSP3ve+PXLJ dbYSV6jBrbUbB3LBv4MS8laYHFGkZxwsfzIm4fkzrDrqWgG9Zi8nvuD/O0Gv1hI/JSAqk7Pdh+XSu JQ9rk0vmwTydsFzEt67sifKMBxS26/XofjQVvihccGu/bzFKoMOLUb3pbUWEjVI1IeNUSD3e8Fx2R nwmv7vv0n99pA1t5gJ7KNI0S7j6C9wQMgsfP7Den4cyGxa6/nFm3SMCLY1S+zLIc0D6AXVL3TzVwi Rw1Da9IwWxpOeB8fHprtHJjEcu7yGRbUPkClxtO4iH1LpQNHIIEbnM3apxmV7XAznhJowEkktRGb6 k4gTB6pi7Bfa9ppbQaTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojjbD-00HCZL-33; Sat, 15 Oct 2022 16:01:19 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojjb8-00HCYQ-RC for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 16:01:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6EAD4B80AC2; Sat, 15 Oct 2022 16:01:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42F48C433C1; Sat, 15 Oct 2022 16:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665849671; bh=5DW+KfgeP2TSoBevcMQCqBiQ6w16gwzYO6dEt63VsXM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CrprHuiVK/GF8bX9i7S1Mqi8ckPruPrhU+xVvLoDKcNvL9kRQVY88Z7s142oyo7zH 25wSgw00z2SKr/1QVKTnC386ROpES7+yNG2CJEWNSIsLst7613jgHHQPMR76AbaO6L G0VgqsnUYLYvgtNf+YFj1KUZXCcwa5HxFO4e+Bpm4UQXusl5AWoJNyw4wOX4Lj5ZZb LU3+Ypv5fKBNuADSpBcDowG/Sd5iwj9Yu8QiQUYY3qa/4K6nTyyB2Nyycfma3G6Hsr 4riLWL+QXsdOpiuawbQPRo0oeih90R9c53+u8Fhvmfg4bliTLJg2qbWjmuKkSMSt1f r3IY9qYJtWN1Q== Date: Sat, 15 Oct 2022 17:01:37 +0100 From: Jonathan Cameron To: Fabrice Gasnier Cc: Olivier Moysan , Rob Herring , Alexandre Torgue , Andy Shevchenko , Lars-Peter Clausen , Maxime Coquelin , , , , , Subject: Re: [PATCH v4 0/8] iio: stm32-adc: add support of adc for stm32mp13 Message-ID: <20221015170137.072b143a@jic23-huawei> In-Reply-To: References: <20221012142205.13041-1-olivier.moysan@foss.st.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_090115_191786_2C4D3717 X-CRM114-Status: GOOD ( 27.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 14 Oct 2022 14:52:49 +0200 Fabrice Gasnier wrote: > On 10/12/22 16:21, Olivier Moysan wrote: > > On STM32MP13 SoCs, each ADC peripheral has a single ADC block. > > These ADC peripherals, ADC1 and ADC2, are fully independent. > > The STM32MP131 SoC provides only ADC2, while other STM32MP13x > > SoCs provide both ADC1 and ADC2. > > > > The STM32MP13 ADC features and characteristics are slightly > > different from STM32MP15 ADC ones, requiring a specific support > > in the driver. > > > > This patchset enables the ADC peripheral on STM32MP135F-DK board. > > > > On STM32MP135F-DK board the ADC is connected to VDDA voltage > > provided by the PMIC LOD1 supply, which has to be enabled through > > SCMI regulator framework. > > This serie introduces a fixed regulator to allow ADC probing, > > while SCMI regulators support is not available. This does > > not ensure ADC regulator enabling however. > > > Hi Olivier, > > I've one tiny remark on PATCH 5/8, "ARM: dts: stm32: add adc support to > stm32mp13" > > With that fixed, for the whole series, you can add my: > > Reviewed-by: Fabrice Gasnier Applied 1 to the the fixes-togreg branch of iio.git and 2,3,4 to the togreg branch of iio.git (pushed out as testing only until I can rebase on rc1). No overlap in code affected, so this should work fine and means I don't have to remember to pick up the non fixes later in the cycle. Thanks, Jonathan > > Thanks, > Fabrice > > > > > Changes in v4: > > - reformat patch 1 commit message > > - reorder adc1 node > > > > v3: > > - Remove blank line in tag block > > - Use HZ_PER_MHZ unit for max frequency definition > > - Coding style updates > > > > v2: > > - Rework commit message length > > - Add missing spaces > > - Remove useless defines > > > > Olivier Moysan (8): > > iio: adc: stm32-adc: fix channel sampling time init > > dt-bindings: iio: adc: stm32-adc: add stm32mp13 compatibles > > iio: adc: stm32-adc: add stm32mp13 support > > iio: adc: stm32: manage min sampling time on all internal channels > > ARM: dts: stm32: add adc support to stm32mp13 > > ARM: dts: stm32: add adc pins muxing on stm32mp135f-dk > > ARM: dts: stm32: add dummy vdd_adc regulator on stm32mp135f-dk > > ARM: dts: stm32: add adc support on stm32mp135f-dk > > > > .../bindings/iio/adc/st,stm32-adc.yaml | 68 ++++- > > arch/arm/boot/dts/stm32mp13-pinctrl.dtsi | 7 + > > arch/arm/boot/dts/stm32mp131.dtsi | 43 +++ > > arch/arm/boot/dts/stm32mp133.dtsi | 31 +++ > > arch/arm/boot/dts/stm32mp135f-dk.dts | 33 +++ > > drivers/iio/adc/stm32-adc-core.c | 30 ++- > > drivers/iio/adc/stm32-adc-core.h | 30 +++ > > drivers/iio/adc/stm32-adc.c | 247 +++++++++++++++--- > > 8 files changed, 443 insertions(+), 46 deletions(-) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel