From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE704C43217 for ; Mon, 17 Oct 2022 17:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SgyOd+t7BjZ3xSzycnL+GOrs5KUYWqNtvv65lqfG7Ek=; b=Ti9iL8e8Sf+ABW IIDyMOLxKZOEG0NF7dK/gGTK8sGxoE6Wzpq5d3oCpFbxCO9hqkMdXOP7LbvSthRBbop/YHNdrAFDz 2a4hykO7PYbHW4Z7XuwkjeVtqUFuzKdW/0HkRl5XVsmhUXEpjA4Fzt4cnSrT2HCyIQ4mEBT49W40s 0rMN4anzRGur0DtWBKow4WAThjaeMrloHuaWUhzeNX7cy4/tAkzEkVjGxJ/YLa0UBiXig0jqcXnz/ YsaEaVT8armGfM2WLf/CwQdZ6gla73o0cj3FDQa7jPcB9NqHJae+lcDGTZtQmj33JRaBMTEQLZ6Mn kE8+7gAk1kudYgj7TgqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okTzm-00E1xs-Cb; Mon, 17 Oct 2022 17:33:46 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okTzi-00E1wc-TQ for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 17:33:44 +0000 Received: by mail-pg1-x52e.google.com with SMTP id q1so11042512pgl.11 for ; Mon, 17 Oct 2022 10:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIkU7sOMlV3fHaINlwJ0KYw7btBtSLgw5mO+qXWoUOw=; b=Jmm7D6cRS6zPAgzomDFIyMJ+afNQc/L35rXtWrVxIPB0xDkGpo/668/Qb6CTzR8Mva Aaz6+IsQYV+dHpvRGVptFXcOCjR6wvfgHUaTCD/RLlNfbNy+lzEzvS4QI31Bwzo5R8z7 r82nxp5MGpoWJBmk4hS6s0XWt7CQjHB0fjVD3G7Bs+RRndEmKVK/hY10sRG5dWuEPnhF dW+XfNlc4+OJbMcx7CbXOJmfRiyR8SoQxSEE9g2dXvmOLXI5diciaP0ed3hrULJC3feW vF21rTT9wpE7sPLKC4X4UITtaAyeZjNIqJ64Ulnj66EOWCEea2oCOG5hJqHeZkeB5dQt RtCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VIkU7sOMlV3fHaINlwJ0KYw7btBtSLgw5mO+qXWoUOw=; b=AaSJ2/+TnrREuCsVVg9sOgZT19PcgvPKIaxqrg0sglfCLINxPBnXVsUcqLczV8nhdn AwJnQt5UP1KU/P4sUtq8+bP38Mla118We7gELK9I5eY6hIsEcVv5Os7QV1sH1jPoVTep DqhOfI9+G0AYHY3RCqXLez8LWlHRAkn8dYd0jUCW7A4jVYRWSrDjQgaYgCXUa8rbXziN IAzYiJzHnBzfAEaZ3LBTdJWKQixAjb71jfg5PU7SRpdyIJ+6eFVFnTDhoiR0YhO1QDQ9 mQP4UeG65gRgfp6SgJ09HmXkvUtF51lPJ3YlQxQXyX3M/zeDfcZFpaX2Xc8ii36V98Pj tFsw== X-Gm-Message-State: ACrzQf3bm5Ggy8xgmAr4DHf2OuQarMIu+Mz4zWD+zAGG2M/BxEzGGf0s dyX8v/j6VVFdNzPhkjDyWLwW4g== X-Google-Smtp-Source: AMsMyM5jyy2WbvbjPaz7HjAuqsssAiAvwynoMnTFyb4G8cBccuREHHhkw139+BtRk/gDYP8/CXZJWA== X-Received: by 2002:a63:1609:0:b0:45c:7c1c:4e7d with SMTP id w9-20020a631609000000b0045c7c1c4e7dmr11482387pgl.265.1666028018299; Mon, 17 Oct 2022 10:33:38 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id d11-20020a170902cecb00b00177fb862a87sm6985701plg.20.2022.10.17.10.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 10:33:37 -0700 (PDT) Date: Mon, 17 Oct 2022 11:33:35 -0600 From: Mathieu Poirier To: Peng Fan Cc: "Peng Fan (OSS)" , "andersson@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-remoteproc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V7 6/7] remoteproc: imx_rproc: request mbox channel later Message-ID: <20221017173335.GA121862@p14s> References: <20221014031037.1070424-1-peng.fan@oss.nxp.com> <20221014031037.1070424-7-peng.fan@oss.nxp.com> <20221014174903.GA4125124@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_103342_992709_F349A98D X-CRM114-Status: GOOD ( 42.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 17, 2022 at 03:13:16AM +0000, Peng Fan wrote: > Hi Mathieu, > > > Subject: Re: [PATCH V7 6/7] remoteproc: imx_rproc: request mbox channel > > later > > > > On Fri, Oct 14, 2022 at 11:10:36AM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > It is possible that when remote processor crash, the communication > > > channel will be broken with garbage value in mailbox, such as when > > > Linux is issuing a message through mailbox, remote processor crashes, > > > we need free & rebuild the mailbox channels to make sure no garbage > > > value in mailbox channels. > > > > > > So move the request/free to start/stop for managing remote procesosr > > > in Linux, move to attach/detach for remote processor is out of control > > > of Linux. > > > > > > Previous, we just request mbox when attach for CM4 boot early before > > > Linux, but if mbox defer probe, remoteproc core will do resource > > > cleanup and corrupt resource table for later probe. > > > > > > So move request mbox ealier and still keep mbox request when attach > > > for self recovery case, but keep a check when request/free mbox. > > > > > > Signed-off-by: Peng Fan > > > --- > > > drivers/remoteproc/imx_rproc.c | 39 > > > ++++++++++++++++++++++++++++++++-- > > > 1 file changed, 37 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 917e6db39572..1183de84a4c0 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -84,6 +84,8 @@ struct imx_rproc_mem { > > > #define ATT_CORE_MASK 0xffff > > > #define ATT_CORE(I) BIT((I)) > > > > > > +static int imx_rproc_xtr_mbox_init(struct rproc *rproc); static void > > > +imx_rproc_free_mbox(struct rproc *rproc); > > > static int imx_rproc_detach_pd(struct rproc *rproc); > > > > > > struct imx_rproc { > > > @@ -357,6 +359,10 @@ static int imx_rproc_start(struct rproc *rproc) > > > struct arm_smccc_res res; > > > int ret; > > > > > > + ret = imx_rproc_xtr_mbox_init(rproc); > > > + if (ret) > > > + return ret; > > > + > > > switch (dcfg->method) { > > > case IMX_RPROC_MMIO: > > > ret = regmap_update_bits(priv->regmap, dcfg->src_reg, > > > dcfg->src_mask, @@ -407,6 +413,8 @@ static int imx_rproc_stop(struct > > > rproc *rproc) > > > > > > if (ret) > > > dev_err(dev, "Failed to stop remote core\n"); > > > + else > > > + imx_rproc_free_mbox(rproc); > > > > > > return ret; > > > } > > > @@ -592,6 +600,22 @@ static void imx_rproc_kick(struct rproc *rproc, > > > int vqid) > > > > > > static int imx_rproc_attach(struct rproc *rproc) { > > > + return imx_rproc_xtr_mbox_init(rproc); } > > > + > > > +static int imx_rproc_detach(struct rproc *rproc) { > > > + struct imx_rproc *priv = rproc->priv; > > > + const struct imx_rproc_dcfg *dcfg = priv->dcfg; > > > + > > > + if (dcfg->method != IMX_RPROC_SCU_API) > > > + return -EOPNOTSUPP; > > > + > > > + if (imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) > > > + return -EOPNOTSUPP; > > > + > > > + imx_rproc_free_mbox(rproc); > > > + > > > return 0; > > > } > > > > > > @@ -610,6 +634,7 @@ static struct resource_table > > > *imx_rproc_get_loaded_rsc_table(struct rproc *rproc static const struct > > rproc_ops imx_rproc_ops = { > > > .prepare = imx_rproc_prepare, > > > .attach = imx_rproc_attach, > > > + .detach = imx_rproc_detach, > > > .start = imx_rproc_start, > > > .stop = imx_rproc_stop, > > > .kick = imx_rproc_kick, > > > @@ -720,6 +745,9 @@ static int imx_rproc_xtr_mbox_init(struct rproc > > *rproc) > > > struct device *dev = priv->dev; > > > struct mbox_client *cl; > > > > > > + if (priv->tx_ch && priv->rx_ch) > > > + return 0; > > > + > > > > You did exactly the same things as in V6. I asked you why this is needed and > > all you did is point me to the code in _probe(), which I can read on my own. > > > > Sorry for not wrote down clear. > > > Again - why is this needed when we know it will be done in start() and > > attach()? > > start() and attach() not able to handle mbox defer probe. So I add We are finally at the heart of the problem. I had to go look at the implementation of imx_rproc_xtr_mbox_init() to understand that it can return -EPROBE_DEFER. Had there been a comment in the code to highlight _why_ the if() condition is needed, I would have understood right away and all this waste of time avoided. > the mbox requesting in probe to handle mbox defer probe, and add > a check when requesting mbox channel in start/attach. During first > time attach/start remote core, the imx_rproc_xtr_mbox_init just > return, because channel requested in probe flow. > > Since mbox requested in probe, why still add it in start() and attach()? > It is to support runtime stop and start(M4 is under control of Linux), > to support runtime detach(only for i.MX8QM/QXP attach recovery, > m4 out of control from linux) and attach. > > Thanks, > Peng. > > > > > > > if (!of_get_property(dev->of_node, "mbox-names", NULL)) > > > return 0; > > > > > > @@ -749,8 +777,15 @@ static void imx_rproc_free_mbox(struct rproc > > > *rproc) { > > > struct imx_rproc *priv = rproc->priv; > > > > > > - mbox_free_channel(priv->tx_ch); > > > - mbox_free_channel(priv->rx_ch); > > > + if (priv->tx_ch) { > > > + mbox_free_channel(priv->tx_ch); > > > + priv->tx_ch = NULL; > > > + } > > > + > > > + if (priv->rx_ch) { > > > + mbox_free_channel(priv->rx_ch); > > > + priv->rx_ch = NULL; > > > + } > > > } > > > > > > static void imx_rproc_put_scu(struct rproc *rproc) > > > -- > > > 2.37.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel