From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB0DDC433FE for ; Mon, 17 Oct 2022 22:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ZGLCkUHVWFBb347ppAnTC+Q5JOVB8rBLKIduS/TbjA=; b=GxUvTcNqm80vby t66DHB9/988kD68nhIMWABtpefjhIp67/l/XrK4hDg1X9DEMThEJ9+Xu20Fk2TW+6UO5HKHH5O+iq MCgY6wRFitxTJdeJVFlCwU5MLdTElFf6Uqqur7Xbr6Z2/VJuGnLRQgVuGjejQLROekhm/AUXEiX4k NRtWgjSNqVczxVqeFSCTaSxz/psGukRwaOi6O/JlMNoV1/1ZMHB/tPJHbyVf/nW5uAnTfZRmlfIrQ KVocSU6MImmdJoAIhiOwZQwmVic0sbQAg0UW3udAK2Fp7CMo+c1g4pm4F7o6HBuKs3/GvehmuWPHX qeEciUJ9INlYhA5fFrPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okYOL-00F7mZ-Uu; Mon, 17 Oct 2022 22:15:26 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okYOJ-00F7lM-NX for linux-arm-kernel@lists.infradead.org; Mon, 17 Oct 2022 22:15:25 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 29HMFCeq029720; Mon, 17 Oct 2022 17:15:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1666044912; bh=BGzmTfV3pQBfCr2G+ffdjjoSW3T+rWmHi/YePx1F1Pc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=qbX6/y1WvS9KE/rFPgn2WLbfo2IVno5jE+1Ms+ca96UQl4lUCWWJF8OZX+/+H43D6 vxggIvIvvbACoOd44FCFlD7cd0OJVJXeo2k+h8wbzXLw7Gn347p0G+nvb9rvGfSvak OVtNE8EK8FxlQncPmPxKQ+xe/R1lR8I7iCVTJhOw= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 29HMF9do030246 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Oct 2022 17:15:09 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Mon, 17 Oct 2022 17:15:09 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Mon, 17 Oct 2022 17:15:09 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 29HMF9sh093348; Mon, 17 Oct 2022 17:15:09 -0500 Date: Mon, 17 Oct 2022 17:15:09 -0500 From: Nishanth Menon To: Nicolas Frayer CC: , , , , Subject: Re: [PATCH v2 1/2] soc: ti: Convert allocations to devm Message-ID: <20221017221509.dig3snkpcxlauqb5@catcher> References: <20221010131538.7333-1-nfrayer@baylibre.com> <20221010131538.7333-2-nfrayer@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221010131538.7333-2-nfrayer@baylibre.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221017_151523_901109_21F3EA95 X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:15-20221010, Nicolas Frayer wrote: [...] > +static int k3_chipinfo_remove(struct platform_device *pdev) > +{ > + struct soc_device *soc_dev = platform_get_drvdata(pdev); > > -err_free_rev: > - kfree(soc_dev_attr->revision); > -err: > - kfree(soc_dev_attr); > - return ret; > + if (soc_dev != NULL) next-20221017 checkpatch --strict suggests if (soc_dev) ? > + soc_device_unregister(soc_dev); > + > + return 0; > } > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel