From: Nishanth Menon <nm@ti.com>
To: Chen Jiahao <chenjiahao16@huawei.com>
Cc: <ssantosh@kernel.org>, <m-karicheri2@ti.com>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] drivers: soc: ti: mark knav_acc_firmwares as static
Date: Mon, 17 Oct 2022 17:19:09 -0500 [thread overview]
Message-ID: <20221017221909.ds24hrbivwap5cek@countable> (raw)
In-Reply-To: <20220927061951.103450-1-chenjiahao16@huawei.com>
On 14:19-20220927, Chen Jiahao wrote:
> There is a sparse warning shown below:
>
> drivers/soc/ti/knav_qmss_queue.c:70:12: warning: symbol
> 'knav_acc_firmwares' was not declared. Should it be static?
>
> Since 'knav_acc_firmwares' is only called within knav_qmss_queue.c,
> mark it as static to fix the warning.
>
> Fixes: 96ee19becc3b ("soc: ti: add firmware file name as part of the driver")
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index 92af7d1b6f5b..c466b98a0293 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -67,7 +67,7 @@ static DEFINE_MUTEX(knav_dev_lock);
> * Newest followed by older ones. Search is done from start of the array
> * until a firmware file is found.
> */
> -const char *knav_acc_firmwares[] = {"ks2_qmss_pdsp_acc48.bin"};
> +static const char *knav_acc_firmwares[] = {"ks2_qmss_pdsp_acc48.bin"};
next-20221017 checkpatch suggests:
static const char * array should probably be static const char * const
Could you check to ensure we are clear here?
>
> static bool device_ready;
> bool knav_qmss_device_ready(void)
> --
> 2.31.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-17 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 6:19 [PATCH -next] drivers: soc: ti: mark knav_acc_firmwares as static Chen Jiahao
2022-10-17 22:19 ` Nishanth Menon [this message]
2022-10-19 7:24 ` chenjiahao (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017221909.ds24hrbivwap5cek@countable \
--to=nm@ti.com \
--cc=arnd@arndb.de \
--cc=chenjiahao16@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox