From: Maxime Ripard <maxime@cerno.tech>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Emma Anholt <emma@anholt.net>, Stephen Boyd <sboyd@kernel.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
Dom Cobley <popcornmix@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node()
Date: Tue, 18 Oct 2022 09:32:01 +0200 [thread overview]
Message-ID: <20221018073201.hcptjdalvn47n25t@houat> (raw)
In-Reply-To: <890f6ab1-f6aa-76c8-01e8-f7233143d7ec@gmail.com>
Hi Florian
On Fri, Oct 14, 2022 at 12:43:38PM -0700, Florian Fainelli wrote:
> On 10/13/22 02:13, Maxime Ripard wrote:
> > A significant number of RaspberryPi drivers using the firmware don't
> > have a phandle to it, so end up scanning the device tree to find a node
> > with the firmware compatible.
> >
> > That code is duplicated everywhere, so let's introduce a helper instead.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > drivers/firmware/raspberrypi.c | 7 +++++++
> > include/soc/bcm2835/raspberrypi-firmware.h | 7 +++++++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
> > index 4b8978b254f9..b916e1e171f8 100644
> > --- a/drivers/firmware/raspberrypi.c
> > +++ b/drivers/firmware/raspberrypi.c
> > @@ -311,6 +311,13 @@ static int rpi_firmware_remove(struct platform_device *pdev)
> > return 0;
> > }
> > +static const struct of_device_id rpi_firmware_of_match[];
>
> This shadows the same variable that is used later for matching the firmware
> driver and probe it as a platform_driver, what am I missing here?
I'm not shadowing the variable, but it's a forward-declaration.
Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-18 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:13 [PATCH v3 0/7] drm/vc4: Fix the core clock behaviour Maxime Ripard
2022-10-13 9:13 ` [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node() Maxime Ripard
2022-10-14 19:43 ` Florian Fainelli
2022-10-18 7:32 ` Maxime Ripard [this message]
2022-10-13 9:13 ` [PATCH v3 2/7] firmware: raspberrypi: Move the clock IDs to the firmware header Maxime Ripard
2022-10-14 19:31 ` Stephen Boyd
2022-10-14 19:44 ` Florian Fainelli
2022-10-13 9:13 ` [PATCH v3 3/7] firmware: raspberrypi: Provide a helper to query a clock max rate Maxime Ripard
2022-10-14 19:45 ` Florian Fainelli
2022-10-13 9:13 ` [PATCH v3 4/7] drm/vc4: hdmi: Fix hdmi_enable_4kp60 detection Maxime Ripard
2022-10-13 9:13 ` [PATCH v3 5/7] drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code Maxime Ripard
2022-10-13 9:13 ` [PATCH v3 6/7] drm/vc4: hdmi: Add more checks for 4k resolutions Maxime Ripard
2022-10-13 9:13 ` [PATCH v3 7/7] drm/vc4: Make sure we don't end up with a core clock too high Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018073201.hcptjdalvn47n25t@houat \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=popcornmix@gmail.com \
--cc=rjui@broadcom.com \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox