From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A140DC43217 for ; Wed, 19 Oct 2022 11:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V30yiFMuVSI7PE14FkQ80B0PAlZv2GwWWNomO+MKUjM=; b=VsdAbTwdaXaQrV 1n3YFzuKqQGZ8mqA9EHAklFc+8+weDpsPc0B2bkX7CG/VZAiH3v+WLdFVeCQOCo9QQ/M87WBpcPS9 7hEuS7oPWXxKpRALcq2yz6Jm0FEmndiZTVXvQhOlixXdFnXY28Qve3VWGJXvDWpSjQDXbjWWKu4mz 0Tnxa4fGKY/c+dYa/QDJTE8FifMbYITiKe/ImpFExLvko4aJJFLFXn4vSMseosaZE9pU0tjGD2Lqk +AplgMR+IS9E+XBobGhDiswB0gJnHC/WN06Bq6gIx8LF9gNOZMlCvDZgrIgK+TzBqcLPyJwCSQHsI QAOPdx44QDd3OjU/BUDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol7hd-0017W2-4z; Wed, 19 Oct 2022 11:57:41 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol7hZ-0017S0-Fp for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 11:57:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E81F5B82256; Wed, 19 Oct 2022 11:57:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8FE8C433C1; Wed, 19 Oct 2022 11:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666180651; bh=7dYUeVMl0ljljG/gREOSgn67ek1PhgEFY91pBBbAxwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FhjdSpJQ8uYcQJVX7CfVuAb3mQh4YGQqss/P9iO096UxFvlaBpt8TtUeMiQUKr+3V WcUM4gQVr2OqxxwGV+nwGWU1ZUqiu92l79qBkuCNdrrbvSCqvNdfkhpRDyRQswyL1B 3ZyDIN8dqx/moSdaMaGnzcc4cQHPozAtsWQDz3qO5yqJGPucL/QQlP4z62H94vEfum r4OdzPOlDTUErlKTnWVSfvak8jI3ThyYwH6Lh5QOp7zHuwqS9nhH4IRGLvrJzaVPXb PV6CJdmI8XxYHpt1OdJwfLfz0CqX98/5bA8mOa5ruSs1z+O5VCtfA1O6YRa011A240 /qdl2LNThAvjA== Date: Wed, 19 Oct 2022 12:57:24 +0100 From: Will Deacon To: Quentin Perret Cc: kvmarm@lists.linux.dev, Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , James Morse , Chao Peng , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 12/25] KVM: arm64: Add infrastructure to create and track pKVM instances at EL2 Message-ID: <20221019115723.GA4067@willie-the-truck> References: <20221017115209.2099-1-will@kernel.org> <20221017115209.2099-13-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_045737_690513_F06DF4AC X-CRM114-Status: GOOD ( 14.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 18, 2022 at 04:33:45PM +0000, Quentin Perret wrote: > On Monday 17 Oct 2022 at 12:51:56 (+0100), Will Deacon wrote: > > +void pkvm_hyp_vm_table_init(void *tbl) > > +{ > > + WARN_ON(vm_table); > > + vm_table = tbl; > > +} > > Uh, why does this one need to be exposed outside pkvm.c ? We need to initialise the table using the memory donated by the host on the __pkvm_init path. That's all private to nvhe/setup.c, so rather than expose the raw pointers (of either the table or the donated memory), we've got this initialisation function instead which is invoked by __pkvm_init_finalise() on the deprivilege path. Happy to repaint it if you have a patch? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel