From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E3AAC4332F for ; Wed, 19 Oct 2022 15:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rWQTVQkaITWsXMarZcDAph5cAFY90Qq/bhFasb2Itdk=; b=hI7YAsqigwUJ28 25/os5FltAAYTJjQ9syn8vrLlmwsOUBCPdzAJ87R3hk/5RjFtKY3Q5nEPo2+4zD1wGxlQp3HbyCTf nWQRNE4K5YWBJ6lO3AqeU+T3hguKYV/vbyknv2lywx3K3dxibfx32Nlt+kEGimB/7dxVgp31dldkU s0qAQZ6lJ1D0vOMThlv7cU5E/nFoZu82fCqvRCbQ0vWW/2tB+DULihx3AbBFHuR7tOyVWWQC08E6i yZK1nJR8vCyVHyfMQYVdFeJHTn9gxSnW4hLx9ZdcA3God9MmCyrUzh2wkMDBBSmQxnon1D2GNS2HJ l71nh2aenFaxPfbjCnBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olBHZ-003T2z-4b; Wed, 19 Oct 2022 15:47:07 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olB22-003H5k-FF for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 15:31:00 +0000 Received: by mail-oi1-x231.google.com with SMTP id w74so19680578oie.0 for ; Wed, 19 Oct 2022 08:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=zqy3E7Ljn1Po59QT2BcCLeBrVV82ElW8LGYHfgQZyfA=; b=h6uk8hTCVSRMZqO3bEgxbGEw9bbxFFeNAHazOJc493Gn3IbZEecV6Blo0AP9oeH/nT flh5EASozPgJLpfmYGOJmYLCxOkBq5WU6b3fNdSb1AMdKZgVjZ3aU6K0dWUJBjcvlmX1 ID4Bu9OxeVlRF5mwhJnImPZr/4ltnOdXWU3PtvzcKSOXsjW/I+tFdB6gEUbY7ua+LUON tW5Q+WTuWBTvP5B5JMqnMnZ0xyw4D0hTV2sHyBZkqiFE+TJjfJHDsdnzlASyRWkvX6Qp edkmGXEEXQi8slgtP78r6qI1BOrHJkRdOBfYftE0dUzXm1NW12bZArsqZ5VQYgkR1Gb8 BAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqy3E7Ljn1Po59QT2BcCLeBrVV82ElW8LGYHfgQZyfA=; b=EgxCSRXgZlWaycrM5dOyk5P213ef9mD6FWHPfkHDi7TqJb0O+/ZUxH3S3Lx8Wv5bm+ GW7W3NirzqkhGcpOMVGdyF1pBpobb08QiqTjQUyWqdVi1tYF5cjE4cDqABxX5zNE9Gr0 Q2roo7zUOTIufaklir7LPHbWnFoQU+agkKXMBgutNQcILVGy/ZDlCo7DfIeLnkzi8PJ1 F4Z0wsdcBZXTlyBtNlq9g/bh2F6lB5lSjo7jYBnbHDbg//OPtQRNdGzbRLsmhtDubr8m CK5p8NPK0Go4nQznrdWoeTfibLAmc7XNWJCOSrpXz+7Uc6nN+D/yoaSTRnamDZd5RY2L rmVA== X-Gm-Message-State: ACrzQf1Fw2yhJ79qZQvmFWH6MeRiSoGf+GthA5oNwNvJijZgwOCIti+r mIUCawe0ej4IGTQ6pa6sjQA= X-Google-Smtp-Source: AMsMyM4qW3m6PF9cIZeFfx7xRpFhIthWH8MkgpRbUVgkqFG62NjMpRdchK912Iys3qr6E/J6ftFkvQ== X-Received: by 2002:a05:6808:219a:b0:354:daec:53cb with SMTP id be26-20020a056808219a00b00354daec53cbmr4395176oib.2.1666193456505; Wed, 19 Oct 2022 08:30:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l10-20020a4a434a000000b004768f725b7csm6539649ooj.23.2022.10.19.08.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 08:30:55 -0700 (PDT) Date: Wed, 19 Oct 2022 08:30:54 -0700 From: Guenter Roeck To: Andrej Picej Cc: linux-watchdog@vger.kernel.org, shawnguo@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org Subject: Re: [PATCH 0/3] Suspending i.MX watchdog in WAIT mode Message-ID: <20221019152915.GB4602@roeck-us.net> References: <20221019111714.1953262-1-andrej.picej@norik.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221019111714.1953262-1-andrej.picej@norik.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_083058_595312_F93EA129 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 19, 2022 at 01:17:11PM +0200, Andrej Picej wrote: > The i.MX6 watchdog can't be stopped once started. This means that > special hardware suspend needs to be configured when the device enters > low-power modes. > Usually i.MX devices have two bits which deal with this: > - WDZST bit disables the timer in "deeper" low power modes and > - WDW bit disables the timer in "WAIT" mode which corresponds with > Linux's "freeze" low-power mode. > > WDZST bit support is already in place since 1a9c5efa576e ("watchdog: imx2_wdt: disable watchdog timer during low power mode"). > WDW bit is not common for all imx2-wdt supported devices, therefore use > a new device-tree property "fsl,suspend-in-wait" which suspends the > watchdog in "WAIT" mode. I think that needs to be validated using the "compatible" property; it should not be possible to set/accept the new flag for devices which don't support it. Thanks, Guenter > > Andrej Picej (3): > watchdog: imx2_wdg: suspend watchdog in WAIT mode > dt-bindings: watchdog: fsl-imx: document suspend in wait mode > ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog in wait mode > > .../devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ > arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi | 4 ++++ > drivers/watchdog/imx2_wdt.c | 7 +++++++ > 3 files changed, 16 insertions(+) > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel