* [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
@ 2022-10-20 11:55 Ulf Hansson
2022-10-25 10:21 ` Sudeep Holla
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ulf Hansson @ 2022-10-20 11:55 UTC (permalink / raw)
To: Rafael J . Wysocki, linux-pm
Cc: Johan Hovold, Dmitry Baryshkov, Sudeep Holla, Lorenzo Pieralisi,
Daniel Lezcano, Ulf Hansson, linux-arm-kernel, linux-kernel
It's useful to understand whether we are using OS-initiated (OSI) mode or
Platform Coordinated (PC) mode, when initializing the CPU PM domains.
Therefore, let's extend the print in the log after a successful probe with
this information.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
index 821984947ed9..c80cf9ddabd8 100644
--- a/drivers/cpuidle/cpuidle-psci-domain.c
+++ b/drivers/cpuidle/cpuidle-psci-domain.c
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
if (ret)
goto remove_pd;
- pr_info("Initialized CPU PM domain topology\n");
+ pr_info("Initialized CPU PM domain topology using %s mode\n",
+ use_osi ? "OSI" : "PC");
return 0;
put_node:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
2022-10-20 11:55 [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode Ulf Hansson
@ 2022-10-25 10:21 ` Sudeep Holla
2022-10-25 10:23 ` Dmitry Baryshkov
2022-10-25 13:15 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2022-10-25 10:21 UTC (permalink / raw)
To: Ulf Hansson
Cc: Rafael J . Wysocki, linux-pm, Johan Hovold, Dmitry Baryshkov,
Lorenzo Pieralisi, Daniel Lezcano, linux-arm-kernel, linux-kernel
On Thu, Oct 20, 2022 at 01:55:13PM +0200, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
Looks good to me.
Acked-by: Sudeep Holla <sudeep.holla@arm.com
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
2022-10-20 11:55 [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode Ulf Hansson
2022-10-25 10:21 ` Sudeep Holla
@ 2022-10-25 10:23 ` Dmitry Baryshkov
2022-10-25 13:15 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-10-25 10:23 UTC (permalink / raw)
To: Ulf Hansson, Rafael J . Wysocki, linux-pm
Cc: Johan Hovold, Sudeep Holla, Lorenzo Pieralisi, Daniel Lezcano,
linux-arm-kernel, linux-kernel
On 20/10/2022 14:55, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
2022-10-20 11:55 [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode Ulf Hansson
2022-10-25 10:21 ` Sudeep Holla
2022-10-25 10:23 ` Dmitry Baryshkov
@ 2022-10-25 13:15 ` Rafael J. Wysocki
2022-10-25 13:17 ` Ulf Hansson
2 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2022-10-25 13:15 UTC (permalink / raw)
To: Ulf Hansson
Cc: Rafael J . Wysocki, linux-pm, Johan Hovold, Dmitry Baryshkov,
Sudeep Holla, Lorenzo Pieralisi, Daniel Lezcano, linux-arm-kernel,
linux-kernel
On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> index 821984947ed9..c80cf9ddabd8 100644
> --- a/drivers/cpuidle/cpuidle-psci-domain.c
> +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> if (ret)
> goto remove_pd;
>
> - pr_info("Initialized CPU PM domain topology\n");
> + pr_info("Initialized CPU PM domain topology using %s mode\n",
> + use_osi ? "OSI" : "PC");
> return 0;
>
> put_node:
> --
Am I expected to pick up this one?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
2022-10-25 13:15 ` Rafael J. Wysocki
@ 2022-10-25 13:17 ` Ulf Hansson
2022-10-28 18:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2022-10-25 13:17 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J . Wysocki, linux-pm, Johan Hovold, Dmitry Baryshkov,
Sudeep Holla, Lorenzo Pieralisi, Daniel Lezcano, linux-arm-kernel,
linux-kernel
On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > Therefore, let's extend the print in the log after a successful probe with
> > this information.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > ---
> > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > index 821984947ed9..c80cf9ddabd8 100644
> > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > if (ret)
> > goto remove_pd;
> >
> > - pr_info("Initialized CPU PM domain topology\n");
> > + pr_info("Initialized CPU PM domain topology using %s mode\n",
> > + use_osi ? "OSI" : "PC");
> > return 0;
> >
> > put_node:
> > --
>
> Am I expected to pick up this one?
Yes, please!
Kind regards
Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode
2022-10-25 13:17 ` Ulf Hansson
@ 2022-10-28 18:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2022-10-28 18:09 UTC (permalink / raw)
To: Ulf Hansson
Cc: Rafael J. Wysocki, Rafael J . Wysocki, linux-pm, Johan Hovold,
Dmitry Baryshkov, Sudeep Holla, Lorenzo Pieralisi, Daniel Lezcano,
linux-arm-kernel, linux-kernel
On Tue, Oct 25, 2022 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > > Therefore, let's extend the print in the log after a successful probe with
> > > this information.
> > >
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > ---
> > > drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > > index 821984947ed9..c80cf9ddabd8 100644
> > > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > > if (ret)
> > > goto remove_pd;
> > >
> > > - pr_info("Initialized CPU PM domain topology\n");
> > > + pr_info("Initialized CPU PM domain topology using %s mode\n",
> > > + use_osi ? "OSI" : "PC");
> > > return 0;
> > >
> > > put_node:
> > > --
> >
> > Am I expected to pick up this one?
>
> Yes, please!
Done, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-28 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 11:55 [PATCH] cpuidle: psci: Extend information in log about OSI/PC mode Ulf Hansson
2022-10-25 10:21 ` Sudeep Holla
2022-10-25 10:23 ` Dmitry Baryshkov
2022-10-25 13:15 ` Rafael J. Wysocki
2022-10-25 13:17 ` Ulf Hansson
2022-10-28 18:09 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).