From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bryan Brattlof <bb@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Andrew Davis <afd@ti.com>
Subject: [PATCH 02/12] arm64: dts: ti: k3-j721e: Enable I2C nodes at the board level
Date: Thu, 20 Oct 2022 11:02:55 -0500 [thread overview]
Message-ID: <20221020160305.18711-3-afd@ti.com> (raw)
In-Reply-To: <20221020160305.18711-1-afd@ti.com>
I2C nodes defined in the top-level J721e SoC dtsi files are incomplete
and will not be functional unless they are extended with pinmux
information.
As the pinmux is only known at the board integration level, these
nodes should only be enabled when provided with this information.
Disable the I2C nodes in the dtsi files and only enable the ones that
are actually pinned out on a given board.
Signed-off-by: Andrew Davis <afd@ti.com>
---
.../dts/ti/k3-j721e-common-proc-board.dts | 4 ++++
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 7 ++++++
.../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 +++
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 23 +++----------------
4 files changed, 17 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 01afacfe6faaa..24e9db563b234 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -529,6 +529,7 @@ adc {
};
&main_i2c0 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c0_pins_default>;
clock-frequency = <400000>;
@@ -565,6 +566,7 @@ p10-hog {
};
&main_i2c1 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c1_pins_default>;
clock-frequency = <400000>;
@@ -590,6 +592,7 @@ &k3_clks {
};
&main_i2c3 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c3_pins_default>;
clock-frequency = <400000>;
@@ -628,6 +631,7 @@ pcm3168a_1: audio-codec@44 {
};
&main_i2c6 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c6_pins_default>;
clock-frequency = <400000>;
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5f85d1cc8b277..61bba78ce354e 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1229,6 +1229,7 @@ main_i2c0: i2c@2000000 {
clock-names = "fck";
clocks = <&k3_clks 187 0>;
power-domains = <&k3_pds 187 TI_SCI_PD_SHARED>;
+ status = "disabled";
};
main_i2c1: i2c@2010000 {
@@ -1240,6 +1241,7 @@ main_i2c1: i2c@2010000 {
clock-names = "fck";
clocks = <&k3_clks 188 0>;
power-domains = <&k3_pds 188 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
main_i2c2: i2c@2020000 {
@@ -1251,6 +1253,7 @@ main_i2c2: i2c@2020000 {
clock-names = "fck";
clocks = <&k3_clks 189 0>;
power-domains = <&k3_pds 189 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
main_i2c3: i2c@2030000 {
@@ -1262,6 +1265,7 @@ main_i2c3: i2c@2030000 {
clock-names = "fck";
clocks = <&k3_clks 190 0>;
power-domains = <&k3_pds 190 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
main_i2c4: i2c@2040000 {
@@ -1273,6 +1277,7 @@ main_i2c4: i2c@2040000 {
clock-names = "fck";
clocks = <&k3_clks 191 0>;
power-domains = <&k3_pds 191 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
main_i2c5: i2c@2050000 {
@@ -1284,6 +1289,7 @@ main_i2c5: i2c@2050000 {
clock-names = "fck";
clocks = <&k3_clks 192 0>;
power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
main_i2c6: i2c@2060000 {
@@ -1295,6 +1301,7 @@ main_i2c6: i2c@2060000 {
clock-names = "fck";
clocks = <&k3_clks 193 0>;
power-domains = <&k3_pds 193 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
ufs_wrapper: ufs-wrapper@4e80000 {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
index fce88ed23596d..7bb6613796eab 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
@@ -147,6 +147,7 @@ mcu_i2c0: i2c@40b00000 {
clock-names = "fck";
clocks = <&k3_clks 194 0>;
power-domains = <&k3_pds 194 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
mcu_i2c1: i2c@40b10000 {
@@ -158,6 +159,7 @@ mcu_i2c1: i2c@40b10000 {
clock-names = "fck";
clocks = <&k3_clks 195 0>;
power-domains = <&k3_pds 195 TI_SCI_PD_EXCLUSIVE>;
+ status = "disabled";
};
wkup_i2c0: i2c@42120000 {
@@ -169,6 +171,7 @@ wkup_i2c0: i2c@42120000 {
clock-names = "fck";
clocks = <&k3_clks 197 0>;
power-domains = <&k3_pds 197 TI_SCI_PD_SHARED>;
+ status = "disabled";
};
fss: fss@47000000 {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 23538c5f43575..1d5a90d968497 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -537,6 +537,7 @@ &ospi1 {
};
&main_i2c0 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c0_pins_default>;
clock-frequency = <400000>;
@@ -564,18 +565,15 @@ i2c@1 {
};
&main_i2c1 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c1_pins_default>;
/* i2c1 is used for DVI DDC, so we need to use 100kHz */
clock-frequency = <100000>;
};
-&main_i2c2 {
- /* Unused */
- status = "disabled";
-};
-
&main_i2c3 {
+ status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_i2c3_pins_default>;
clock-frequency = <400000>;
@@ -602,21 +600,6 @@ i2c@1 {
};
};
-&main_i2c4 {
- /* Unused */
- status = "disabled";
-};
-
-&main_i2c5 {
- /* Brought out on RPi Header */
- status = "disabled";
-};
-
-&main_i2c6 {
- /* Unused */
- status = "disabled";
-};
-
&main_gpio2 {
status = "disabled";
};
--
2.37.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-20 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 16:02 [PATCH 00/12] TI J7x Disable Incomplete DT Nodes Andrew Davis
2022-10-20 16:02 ` [PATCH 01/12] arm64: dts: ti: k3-j721e: Enable UART nodes at the board level Andrew Davis
2022-10-20 16:02 ` Andrew Davis [this message]
2022-10-20 16:02 ` [PATCH 03/12] arm64: dts: ti: k3-j721e: Enable MCASP " Andrew Davis
2022-10-20 16:02 ` [PATCH 04/12] arm64: dts: ti: k3-j721e: Enable MCAN " Andrew Davis
2022-10-20 16:02 ` [PATCH 05/12] arm64: dts: ti: k3-j7200: Enable UART " Andrew Davis
2022-10-20 16:02 ` [PATCH 06/12] arm64: dts: ti: k3-j7200: Enable I2C " Andrew Davis
2022-10-20 16:03 ` [PATCH 07/12] arm64: dts: ti: k3-j721s2: Enable UART " Andrew Davis
2022-10-20 16:03 ` [PATCH 08/12] arm64: dts: ti: k3-j721e: Enable Mailbox " Andrew Davis
2022-10-20 16:03 ` [PATCH 09/12] arm64: dts: ti: k3-j7200: " Andrew Davis
2022-10-20 16:03 ` [PATCH 10/12] arm64: dts: ti: k3-j721s2: " Andrew Davis
2022-10-20 16:03 ` [PATCH 11/12] arm64: dts: ti: k3-j721s2: Enable MCAN " Andrew Davis
2022-10-20 16:03 ` [PATCH 12/12] arm64: dts: ti: k3-j721s2: Enable I2C " Andrew Davis
2022-10-20 22:16 ` [PATCH 00/12] TI J7x Disable Incomplete DT Nodes Bryan Brattlof
2022-10-28 13:20 ` Vignesh Raghavendra
2022-10-28 13:31 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020160305.18711-3-afd@ti.com \
--to=afd@ti.com \
--cc=bb@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).