From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4993FC4321E for ; Thu, 20 Oct 2022 16:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=OgQzvfyoCTLE2peu+7sUktTzCTKzqO70Bgz44XroUeU=; b=FocFqpx1ulTJn4 XK6SyNpxAycPrrX3067x6Nhw76XPV5ZWQEvpHDeWAMkZ5CHoDTx/lmUwK0pTMdxbwIx7j3C25Wyys KeQrGNSdQNZBy3iCrnE/1wKhEbRaWRzaZHau5gMICYUC53TMiwv2B98HTEZyBwy4JNsWqzu9OjysT hV0QAuj4v6iRkEdQhgJ2Se6d0Y1+F3Sm3bMybsEbMPR7/xKVAQDWm5jP8oDOgplVNJNRLDwpy6Gq7 S5g/A9Y/3i+13weT/oBaUCmRqHhUwU20TNLs71AODrLsOQ4+AyNt059wpANHQAxwW8NhoI8rl2OGp BP/FRasryGJbizdta2dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olYsR-000h2S-5h; Thu, 20 Oct 2022 16:58:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olYsN-000gzY-Ne for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 16:58:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDBAD61CA0; Thu, 20 Oct 2022 16:58:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF29DC433D6; Thu, 20 Oct 2022 16:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666285114; bh=rPtOiltoyJfynEA4NrlFetR8EwwPDCq16wo8frOCFhM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kGw+7gvshzdQw32mD0b9q4wGKccLD3au3iPs8ZmsZ99KH6HYZPR/ZW/tV4TJGkzkf 7JUueBCzr/7YFM0osiNPO4Uqr2mv1o/kKzHOdblEAK6aEJWsI4Kj+Bq0CBst+4Qflw 6Sqn7OiTghpOHLXYY8lVPD7vE8TbAAvtaqLPoZgqRIgGl/eiAN5B0yrfooXeiRG0WF CX8UUGr91ZLlPJa59i1cgsNIb7J8AOsRnY7+VMFALJm+1hYv0O4f2zZfNP1Mkz+G+N xuFFKfRDJO2dXTh3q5yRzYtNqRK6ji5wBn3td7QFybjXZY3dDPgHUdJAxbaV+JDmJm 98eTPTXvKsRyA== Date: Thu, 20 Oct 2022 11:58:32 -0500 From: Bjorn Helgaas To: Matt Ranostay Cc: robh@kernel.org, tjoseph@cadence.com, nm@ti.com, a-verma1@ti.com, vigneshr@ti.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 3/3] PCI: j721e: Add warnings on num-lanes misconfiguration Message-ID: <20221020165832.GA131977@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221020012911.305139-4-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_095835_826522_E824C7E2 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 19, 2022 at 06:29:11PM -0700, Matt Ranostay wrote: > Added dev_warn messages to alert of devicetree misconfigurations > for incorrect num-lanes setting, or the lack of one being defined. s/Added/Add/ if you repost for anything else: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.16#n95 > + dev_warn(dev, "defined num-lanes %u is greater than the " > + "allowed maximum of %u, defaulting to 1\n", > + num_lanes, data->max_lanes); Don't repost just for this, but I generally prefer to keep printf strings intact even if they exceed 80 columns, because it makes it easier for someone to grep for something like "greater than the allowed". > + num_lanes = 1; > + } > pcie->num_lanes = num_lanes; > > if (dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48))) > -- > 2.38.GIT > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel