From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE1AFA373D for ; Sun, 23 Oct 2022 13:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0+0mhb5esPk/npE3ohBvNcncIQRYH2w2wJahKvR89Ds=; b=yyLhuzz3P/Om/a yIIEIjcbKWKBILa9wqBc0QB3gzWwURim6xOoKCmUakidOZRyF1rKDo+huSq7EgtcMJZxmKiAWUcU6 ql3nE7L72ack6xSHwJrgR8aMTbqgtqbTLpRR4FEbfBaxzBJJjSi0iCQJF01lvOfzpQPwXIsN0uO3K dwMCVfWqoyG1f3YUQdlk+K5gd8vNDo4i34ZQmF+EE/CURBhnyw1k05/bnHzOKHcvX2AoQeW1DwLaj W2TpZhPMeMU21kM82CXFUbDb1DvVgcAJ8AS2LNx8rGL0v5WeMlswqZeFuABYG+7tfO9H8W5/XI+it oTFPY0yEUx6NcmCy/4AQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omamU-00FJ6d-Ab; Sun, 23 Oct 2022 13:12:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omamQ-00FJ5O-4I for linux-arm-kernel@lists.infradead.org; Sun, 23 Oct 2022 13:12:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4752D60E05; Sun, 23 Oct 2022 13:12:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1572C433D6; Sun, 23 Oct 2022 13:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666530760; bh=+6IyGl0MVPkVHS2QT8+DH7EhBIU/cufLxi876OE1DWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAGT9kCaAHGKDvqtQwV95r6i9PfDKr2sRbQzDBsu2P9NJf9pKgtNXGH1ZCgSKrvOX F2e7nN6P54X3hJXo7VM7y2SwAYrQWRj2DVtdmOoYBczH/+n3XPWP/z/OamHJuU2bug 8aYLLBwTV8xrBUrWHUNEyogDVskgbiQX4HslbJaq4G4Xy+oFzeGqHO/0ogE1eiw1iF wH13W6T4wd2wk+lij8n00YBPoGxC5g8xaun43rp6wvyLYaxbHo+qf30sA6Pw1pwuFw vX/ZACzrw3pO+E0g3t5ndKxM87PdAzZKC/jX6mMLkp662HwMDGYH1bHqaxGxAJm60H 5TsclH/ofoH5w== Date: Sun, 23 Oct 2022 21:12:32 +0800 From: Shawn Guo To: Marcel Ziswiler Cc: linux-arm-kernel@lists.infradead.org, Marcel Ziswiler , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Max Krummenacher , NXP Linux Team , Pengutronix Kernel Team , Philippe Schenker , Rob Herring , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/8] arm64: dts: verdin-imx8mp: add pcie support Message-ID: <20221023131232.GN125525@dragon> References: <20220922162925.2368577-1-marcel@ziswiler.com> <20220922162925.2368577-7-marcel@ziswiler.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220922162925.2368577-7-marcel@ziswiler.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221023_061242_263489_43403F31 X-CRM114-Status: GOOD ( 18.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 22, 2022 at 06:29:23PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add PCIe support on the Verdin iMX8M Plus. > > Signed-off-by: Marcel Ziswiler > > --- > This still relies on the PHY part landing [1] and the internal SYSPLL > mode getting sorted [2]. > > [1] https://lore.kernel.org/all/1663659498-5180-1-git-send-email-hongxing.zhu@nxp.com/ > [2] https://lore.kernel.org/all/AS8PR04MB867657D03C61774096A5A1628C4C9@AS8PR04MB8676.eurprd04.prod.outlook.com/ Are these dependencies already landed on v6.1-rc1? Shawn > > .../dts/freescale/imx8mp-verdin-dahlia.dtsi | 9 +++++++- > .../boot/dts/freescale/imx8mp-verdin.dtsi | 22 ++++++++++++++++++- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > index 4b8f86f63081..60f9dc4847db 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > @@ -67,7 +67,14 @@ &i2c4 { > /* TODO: Audio Codec */ > }; > > -/* TODO: Verdin PCIE_1 */ > +/* Verdin PCIE_1 */ > +&pcie { > + status = "okay"; > +}; > + > +&pcie_phy { > + status = "okay"; > +}; > > /* Verdin PWM_1 */ > &pwm1 { > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > index 7be7e922927b..160bb32cb5f7 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > @@ -734,7 +734,27 @@ eeprom_carrier_board: eeprom@57 { > }; > }; > > -/* TODO: Verdin PCIE_1 */ > +/* Verdin PCIE_1 */ > +&pcie { > + assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>; > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>; > + assigned-clock-rates = <10000000>; > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, > + <&clk IMX8MP_CLK_PCIE_ROOT>, > + <&clk IMX8MP_CLK_HSIO_AXI>; > + clock-names = "pcie", "pcie_aux", "pcie_bus"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie>; > + /* PCIE_1_RESET# (SODIMM 244) */ > + reset-gpio = <&gpio4 19 GPIO_ACTIVE_LOW>; > +}; > + > +&pcie_phy { > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>; > + clock-names = "ref"; > + fsl,clkreq-unsupported; > + fsl,refclk-pad-mode = ; > +}; > > /* Verdin PWM_1 */ > &pwm1 { > -- > 2.36.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel