* [PATCH 5.10 301/390] ARM: decompressor: Include .data.rel.ro.local [not found] <20221024113022.510008560@linuxfoundation.org> @ 2022-10-24 11:31 ` Greg Kroah-Hartman 2022-10-24 18:41 ` Pavel Machek 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-10-24 11:31 UTC (permalink / raw) To: linux-kernel Cc: Greg Kroah-Hartman, stable, kernel test robot, Russell King, linux-arm-kernel, Kees Cook, Sasha Levin From: Kees Cook <keescook@chromium.org> [ Upstream commit 1b64daf413acd86c2c13f5443f6b4ef3690c8061 ] The .data.rel.ro.local section has the same semantics as .data.rel.ro here, so include it in the .rodata section of the decompressor. Additionally since the .printk_index section isn't usable outside of the core kernel, discard it in the decompressor. Avoids these warnings: arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.data.rel.ro.local' arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.printk_index' Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/linux-mm/202209080545.qMIVj7YM-lkp@intel.com Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm/boot/compressed/vmlinux.lds.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S index 1bcb68ac4b01..3fcb3e62dc56 100644 --- a/arch/arm/boot/compressed/vmlinux.lds.S +++ b/arch/arm/boot/compressed/vmlinux.lds.S @@ -23,6 +23,7 @@ SECTIONS *(.ARM.extab*) *(.note.*) *(.rel.*) + *(.printk_index) /* * Discard any r/w data - this produces a link error if we have any, * which is required for PIC decompression. Local data generates @@ -57,6 +58,7 @@ SECTIONS *(.rodata) *(.rodata.*) *(.data.rel.ro) + *(.data.rel.ro.*) } .piggydata : { *(.piggydata) -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5.10 301/390] ARM: decompressor: Include .data.rel.ro.local 2022-10-24 11:31 ` [PATCH 5.10 301/390] ARM: decompressor: Include .data.rel.ro.local Greg Kroah-Hartman @ 2022-10-24 18:41 ` Pavel Machek 2022-10-25 13:05 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Pavel Machek @ 2022-10-24 18:41 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-kernel, stable, kernel test robot, Russell King, linux-arm-kernel, Kees Cook, Sasha Levin [-- Attachment #1.1: Type: text/plain, Size: 1324 bytes --] Hi! > From: Kees Cook <keescook@chromium.org> > > [ Upstream commit 1b64daf413acd86c2c13f5443f6b4ef3690c8061 ] > > The .data.rel.ro.local section has the same semantics as .data.rel.ro > here, so include it in the .rodata section of the decompressor. > Additionally since the .printk_index section isn't usable outside of > the core kernel, discard it in the decompressor. Avoids these warnings: > > arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.data.rel.ro.local' > arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from > `arch/arm/boot/compressed/fdt_rw.o' being placed in section > `.printk_index' There's no printk_index in 5.10., so I'm not sure we should be applying it here. Best regards, Pavel > +++ b/arch/arm/boot/compressed/vmlinux.lds.S > @@ -23,6 +23,7 @@ SECTIONS > *(.ARM.extab*) > *(.note.*) > *(.rel.*) > + *(.printk_index) > /* > * Discard any r/w data - this produces a link error if we have any, > * which is required for PIC decompression. Local data generates -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5.10 301/390] ARM: decompressor: Include .data.rel.ro.local 2022-10-24 18:41 ` Pavel Machek @ 2022-10-25 13:05 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2022-10-25 13:05 UTC (permalink / raw) To: Pavel Machek Cc: linux-kernel, stable, kernel test robot, Russell King, linux-arm-kernel, Kees Cook, Sasha Levin On Mon, Oct 24, 2022 at 08:41:03PM +0200, Pavel Machek wrote: > Hi! > > > From: Kees Cook <keescook@chromium.org> > > > > [ Upstream commit 1b64daf413acd86c2c13f5443f6b4ef3690c8061 ] > > > > The .data.rel.ro.local section has the same semantics as .data.rel.ro > > here, so include it in the .rodata section of the decompressor. > > Additionally since the .printk_index section isn't usable outside of > > the core kernel, discard it in the decompressor. Avoids these warnings: > > > > arm-linux-gnueabi-ld: warning: orphan section `.data.rel.ro.local' from `arch/arm/boot/compressed/fdt_rw.o' being placed in section `.data.rel.ro.local' > > arm-linux-gnueabi-ld: warning: orphan section `.printk_index' from > > `arch/arm/boot/compressed/fdt_rw.o' being placed in section > > `.printk_index' > > There's no printk_index in 5.10., so I'm not sure we should be > applying it here. Good point, now dropped. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-25 13:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221024113022.510008560@linuxfoundation.org>
2022-10-24 11:31 ` [PATCH 5.10 301/390] ARM: decompressor: Include .data.rel.ro.local Greg Kroah-Hartman
2022-10-24 18:41 ` Pavel Machek
2022-10-25 13:05 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).